From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D01D5C433E0 for ; Wed, 13 Jan 2021 10:36:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 807FC2339F for ; Wed, 13 Jan 2021 10:36:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727154AbhAMKgh (ORCPT ); Wed, 13 Jan 2021 05:36:37 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:55510 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726874AbhAMKgh (ORCPT ); Wed, 13 Jan 2021 05:36:37 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id F08FD1F41028 Subject: Re: [PATCH v3 2/2] arm64: dts: mt8183: Add krane-sku0 board. To: Hsin-Yi Wang , linux-arm-kernel@lists.infradead.org, Matthias Brugger Cc: Rob Herring , Nicolas Boichat , devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210113062834.4043956-1-hsinyi@chromium.org> <20210113062834.4043956-2-hsinyi@chromium.org> From: Enric Balletbo i Serra Message-ID: <4ccea266-a840-7954-e7b1-ff6a321a9411@collabora.com> Date: Wed, 13 Jan 2021 11:35:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210113062834.4043956-2-hsinyi@chromium.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hsin-Yi, Thank you for your patch. On 13/1/21 7:28, Hsin-Yi Wang wrote: > Similar to krane-sku176 but using a different panel source. > > Signed-off-by: Hsin-Yi Wang > --- > change: > v3: fix yaml > --- > .../devicetree/bindings/arm/mediatek.yaml | 4 +++- I think the binding should be a separate patch? (Rob to confirm). Other than that. Reviewed-by: Enric Balletbo i Serra > arch/arm64/boot/dts/mediatek/Makefile | 1 + > .../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23 +++++++++++++++++++ > 3 files changed, 27 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > index 53f0d4e3ea982..93b3bdf6eaeb7 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > @@ -120,7 +120,9 @@ properties: > - const: mediatek,mt8183 > - description: Google Krane (Lenovo IdeaPad Duet, 10e,...) > items: > - - const: google,krane-sku176 > + - enum: > + - google,krane-sku0 > + - google,krane-sku176 > - const: google,krane > - const: mediatek,mt8183 > > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile > index 18f7b46c4095b..deba27ab76574 100644 > --- a/arch/arm64/boot/dts/mediatek/Makefile > +++ b/arch/arm64/boot/dts/mediatek/Makefile > @@ -13,6 +13,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana-rev7.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-evb.dtb > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku0.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku176.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8192-evb.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts > new file mode 100644 > index 0000000000000..fb5ee91b6fe0e > --- /dev/null > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts > @@ -0,0 +1,23 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +/* > + * Copyright 2019 Google LLC > + * > + * Device-tree for Krane sku0. > + * > + * SKU is a 8-bit value (0x00 == 0): > + * - Bits 7..4: Panel ID: 0x0 (AUO) > + * - Bits 3..0: SKU ID: 0x0 (default) > + */ > + > +/dts-v1/; > +#include "mt8183-kukui-krane.dtsi" > + > +/ { > + model = "MediaTek krane sku0 board"; > + compatible = "google,krane-sku0", "google,krane", "mediatek,mt8183"; > +}; > + > +&panel { > + status = "okay"; > + compatible = "auo,kd101n80-45na"; > +}; >