From: Markus Elfring <Markus.Elfring@web.de>
To: make24@iscas.ac.cn, iommu@lists.linux.dev
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Jörg Rödel" <joro@8bytes.org>,
"Robin Murphy" <robin.murphy@arm.com>,
"Suman Anna" <s-anna@ti.com>, "Tero Kristo" <t-kristo@ti.com>,
"Will Deacon" <will@kernel.org>
Subject: Re: [PATCH] iommu/omap: Fix error handling in omap_iommu_probe_device
Date: Mon, 17 Nov 2025 16:46:11 +0100 [thread overview]
Message-ID: <4ccf660b-9bbe-4f2f-8237-295f6d6f70f9@web.de> (raw)
In-Reply-To: <20251117033943.40749-1-make24@iscas.ac.cn>
> omap_iommu_probe_device() calls of_find_device_by_node() which
> increments the reference count of the platform device, but fails to
> decrement the reference count in both success and error paths. This
> could lead to resource leakage and prevent proper device cleanup when
> the IOMMU is unbound or the device is removed.
1. See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc5#n94
2. May the statement “ret = -EINVAL;” be moved behind an additional label?
3. Would it be helpful to append parentheses to the function name in the summary phrase?
Regards,
Markus
next prev parent reply other threads:[~2025-11-17 15:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 3:39 Ma Ke
2025-11-17 15:46 ` Markus Elfring [this message]
2025-11-17 18:00 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ccf660b-9bbe-4f2f-8237-295f6d6f70f9@web.de \
--to=markus.elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=robin.murphy@arm.com \
--cc=s-anna@ti.com \
--cc=stable@vger.kernel.org \
--cc=t-kristo@ti.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®