From: Vignesh R <vigneshr@ti.com>
To: Frode Isaksen <fisaksen@baylibre.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Mark Brown <broonie@kernel.org>
Cc: Cyrille Pitchen <cyrille.pitchen@atmel.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>, <linux-spi@vger.kernel.org>
Subject: Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce buffer support
Date: Thu, 2 Mar 2017 19:24:43 +0530 [thread overview]
Message-ID: <4cd22ddd-b108-f697-0bde-ad844a386e62@ti.com> (raw)
In-Reply-To: <09ffe06d-565d-afe8-8b7d-d1a0b575595b@baylibre.com>
>>>>
>>> Not really, I am debugging another issue with UBIFS on DRA74 EVM (ARM
>>> cortex-a15) wherein pages allocated by vmalloc are in highmem region
>>> that are not addressable using 32 bit addresses and is backed by LPAE.
>>> So, a 32 bit DMA cannot access these buffers at all.
>>> When dma_map_sg() is called to map these pages by spi_map_buf() the
>>> physical address is just truncated to 32 bit in pfn_to_dma() (as part of
>>> dma_map_sg() call). This results in random crashes as DMA starts
>>> accessing random memory during SPI read.
>>>
>>> IMO, there may be more undiscovered caveat with using dma_map_sg() for
>>> non kmalloc'd buffers and its better that spi-nor starts handling these
>>> buffers instead of relying on spi_map_msg() and working around every
>>> time something pops up.
>>>
>> Ok, I had a closer look at the SPI framework, and it seems there's a
>> way to tell to the core that a specific transfer cannot use DMA
>> (->can_dam()). The first thing you should do is fix the spi-davinci
>> driver:
>>
>> 1/ implement ->can_dma()
>> 2/ patch davinci_spi_bufs() to take the decision to do DMA or not on a
>> per-xfer basis and not on a per-device basis
>>
This would lead to poor perf defeating entire purpose of using DMA.
>> Then we can start thinking about how to improve perfs by using a bounce
>> buffer for large transfers, but I'm still not sure this should be done
>> at the MTD level...
If its at SPI level, then I guess each individual drivers which cannot
handle vmalloc'd buffers will have to implement bounce buffer logic.
Or SPI core can be extended in a way similar to this RFC. That is, SPI
master driver will set a flag to request SPI core to use of bounce
buffer for vmalloc'd buffers. And spi_map_buf() just uses bounce buffer
in case buf does not belong to kmalloc region based on the flag.
Mark, Cyrille, Is that what you prefer?
--
Regards
Vignesh
next prev parent reply other threads:[~2017-03-03 22:07 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 12:08 [RFC PATCH 0/2] mtd: spi-nor: Handle vmalloc'd buffers Vignesh R
2017-02-27 12:08 ` [RFC PATCH 1/2] mtd: spi-nor: Introduce bounce buffer to handle " Vignesh R
2017-02-28 21:39 ` Richard Weinberger
2017-03-01 5:13 ` Vignesh R
2017-03-01 10:09 ` Cyrille Pitchen
2017-03-01 10:18 ` Boris Brezillon
2017-03-01 11:18 ` Frode Isaksen
2017-03-01 12:12 ` Boris Brezillon
2017-03-01 11:50 ` Vignesh R
2017-02-27 12:08 ` [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce buffer support Vignesh R
2017-02-28 21:41 ` Richard Weinberger
2017-03-01 4:54 ` Vignesh R
2017-03-01 10:43 ` Cyrille Pitchen
2017-03-01 11:14 ` Frode Isaksen
2017-03-01 11:46 ` Vignesh R
2017-03-01 12:23 ` Boris Brezillon
2017-03-01 14:21 ` Cyrille Pitchen
2017-03-01 14:28 ` Boris Brezillon
2017-03-01 14:30 ` Cyrille Pitchen
2017-03-01 15:52 ` Mark Brown
2017-03-01 16:04 ` Boris Brezillon
2017-03-01 16:55 ` Boris Brezillon
2017-03-02 9:06 ` Frode Isaksen
2017-03-02 13:54 ` Vignesh R [this message]
2017-03-02 14:29 ` Boris Brezillon
2017-03-02 15:03 ` Frode Isaksen
2017-03-02 15:25 ` Boris Brezillon
2017-03-03 9:02 ` Frode Isaksen
2017-03-02 16:45 ` Cyrille Pitchen
2017-03-02 17:00 ` Mark Brown
2017-03-02 19:49 ` Boris Brezillon
2017-03-03 12:50 ` Mark Brown
2017-03-06 11:47 ` Vignesh R
2017-03-14 13:21 ` Vignesh R
2017-02-27 14:03 ` [RFC PATCH 0/2] mtd: spi-nor: Handle vmalloc'd buffers Frode Isaksen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cd22ddd-b108-f697-0bde-ad844a386e62@ti.com \
--to=vigneshr@ti.com \
--cc=boris.brezillon@free-electrons.com \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=fisaksen@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®