From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 326AAC433DF for ; Mon, 17 Aug 2020 08:43:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E7ED207DF for ; Mon, 17 Aug 2020 08:43:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727890AbgHQInY (ORCPT ); Mon, 17 Aug 2020 04:43:24 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:47376 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726544AbgHQInX (ORCPT ); Mon, 17 Aug 2020 04:43:23 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id B2129354BE937E759B8A; Mon, 17 Aug 2020 16:43:20 +0800 (CST) Received: from [10.174.187.22] (10.174.187.22) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Mon, 17 Aug 2020 16:43:14 +0800 Subject: Re: [PATCH 2/3] KVM: uapi: Remove KVM_DEV_TYPE_ARM_PV_TIME in kvm_device_type To: Marc Zyngier References: <20200817033729.10848-1-zhukeqian1@huawei.com> <20200817033729.10848-3-zhukeqian1@huawei.com> CC: , , , , Catalin Marinas , Will Deacon , James Morse , Suzuki K Poulose , "Steven Price" , From: zhukeqian Message-ID: <4cd543a2-4d5b-882c-38d6-f5055512f0dc@huawei.com> Date: Mon, 17 Aug 2020 16:43:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.187.22] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marc, On 2020/8/17 15:39, Marc Zyngier wrote: > On 2020-08-17 04:37, Keqian Zhu wrote: >> ARM64 PV-time ST is configured by userspace through vCPU attribute, >> and KVM_DEV_TYPE_ARM_PV_TIME is unused. >> >> Signed-off-by: Keqian Zhu >> --- >> include/uapi/linux/kvm.h | 2 -- >> tools/include/uapi/linux/kvm.h | 2 -- >> 2 files changed, 4 deletions(-) >> >> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h >> index 4fdf303..9a6b97e 100644 >> --- a/include/uapi/linux/kvm.h >> +++ b/include/uapi/linux/kvm.h >> @@ -1258,8 +1258,6 @@ enum kvm_device_type { >> #define KVM_DEV_TYPE_ARM_VGIC_ITS KVM_DEV_TYPE_ARM_VGIC_ITS >> KVM_DEV_TYPE_XIVE, >> #define KVM_DEV_TYPE_XIVE KVM_DEV_TYPE_XIVE >> - KVM_DEV_TYPE_ARM_PV_TIME, >> -#define KVM_DEV_TYPE_ARM_PV_TIME KVM_DEV_TYPE_ARM_PV_TIME >> KVM_DEV_TYPE_MAX, >> }; >> >> diff --git a/tools/include/uapi/linux/kvm.h b/tools/include/uapi/linux/kvm.h >> index 4fdf303..9a6b97e 100644 >> --- a/tools/include/uapi/linux/kvm.h >> +++ b/tools/include/uapi/linux/kvm.h >> @@ -1258,8 +1258,6 @@ enum kvm_device_type { >> #define KVM_DEV_TYPE_ARM_VGIC_ITS KVM_DEV_TYPE_ARM_VGIC_ITS >> KVM_DEV_TYPE_XIVE, >> #define KVM_DEV_TYPE_XIVE KVM_DEV_TYPE_XIVE >> - KVM_DEV_TYPE_ARM_PV_TIME, >> -#define KVM_DEV_TYPE_ARM_PV_TIME KVM_DEV_TYPE_ARM_PV_TIME >> KVM_DEV_TYPE_MAX, >> }; > > No. You can't drop anything from UAPI, used or not. Doing so will > break the compilation of any userspace that, for any reason, references > this value. We cannot reuse this value in the future either, as it would > create a we wouldn't know which device to create. > > It is pretty unfortunate that PV time has turned into such a train wreck, > but that's what we have now, and it has to stay. Well, I see. It is a sad thing indeed. Thanks, Keqian