From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 931E1EB64DD for ; Tue, 25 Jul 2023 19:50:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231320AbjGYTuL convert rfc822-to-8bit (ORCPT ); Tue, 25 Jul 2023 15:50:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229572AbjGYTuJ (ORCPT ); Tue, 25 Jul 2023 15:50:09 -0400 Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EF3710D4; Tue, 25 Jul 2023 12:50:08 -0700 (PDT) Received: from omf09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 92CE3C0F0F; Tue, 25 Jul 2023 19:50:05 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA id 6D7F52002A; Tue, 25 Jul 2023 19:50:01 +0000 (UTC) Message-ID: <4ce3c7a980be3ce9012ba02a5d9d4285cdf4fd07.camel@perches.com> Subject: Re: [PATCH v2] net/sched: mqprio: Add length check for TCA_MQPRIO_{MAX/MIN}_RATE64 From: Joe Perches To: Jakub Kicinski Cc: Lin Ma , jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 25 Jul 2023 12:50:00 -0700 In-Reply-To: <20230725123842.546045f1@kernel.org> References: <20230724014625.4087030-1-linma@zju.edu.cn> <20230724160214.424573ac@kernel.org> <63d69a72.e2656.1898a66ca22.Coremail.linma@zju.edu.cn> <20230724175612.0649ef67@kernel.org> <20230725123842.546045f1@kernel.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Rspamd-Queue-Id: 6D7F52002A X-Rspamd-Server: rspamout02 X-Stat-Signature: iafnjui4t1dsw8jioq5af4htufncp3q4 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/1BwcFPMc+exIE8tEWXVMCn8VrkCjkOTc= X-HE-Tag: 1690314601-210224 X-HE-Meta: U2FsdGVkX1/hJEPKF2zr3TJgtWEyLqffK/2NfpekyNdd1d2qPBSjNPF3zb/rolffaxdixAJchpDFZMz6ez43RrK2pcoLUdXJwfWmA3omsXsKY8hZcPV90QuT81iUJziDwfj+9MTNCMk5RD7EmN7QBAkC59majWbDNr55FxvrBhzaRiGJR4ZBo1eL8ESRle1EDGuRr/mc171zFMBT+HGuvp2Vh+JOrqAEOj3VqkonXb8rCD7Jk8UDmx24njhpVn/yz/U+tkb2YBy75Ylk0kumbY1I4+amn7O+ZDkLUcgzS2UOuMGcqQwZipwBsnXqxOs7hxF63acs4rRt2TzSCYQ6zyFjDUh6Y3vKR2+yLqSRGXbR8+NSFZixcHvIY2FPysOZ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2023-07-25 at 12:38 -0700, Jakub Kicinski wrote: > On Mon, 24 Jul 2023 20:59:53 -0700 Joe Perches wrote: > > > Joe, here's another case. > > > > What do you think the "case" is here? > > > > Do you think John Fastabend, who hasn't touched the file in 7+ years > > should be cc'd? Why? > > Nope. The author of the patch under Fixes. It adds that already since 2019. commit 2f5bd343694ed53b3abc4a616ce975505271afe7 Author: Joe Perches Date: Wed Dec 4 16:50:29 2019 -0800 scripts/get_maintainer.pl: add signatures from Fixes: lines in commit message A Fixes: lines in a commit message generally indicate that a previous commit was inadequate for whatever reason. The signers of the previous inadequate commit should also be cc'd on this new commit so update get_maintainer to find the old commit and add the original signers.