mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Davis <afd@ti.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: "Igor Korotin" <igor.korotin@linux.dev>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Tamir Duberstein" <tamird@kernel.org>,
	"Alexandre Courbot" <acourbot@nvidia.com>,
	"Onur Özkan" <work@onurozkan.dev>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2] rust: i2c: Remove use of bindings::i2c_match_id
Date: Mon, 16 Nov 2026 19:40:59 -0600	[thread overview]
Message-ID: <4ce992f0-4f9e-4359-937e-12553fa46b37@ti.com> (raw)
In-Reply-To: <CANiq72my47EZMwqQ7+esPjYv4rcuawhXJVuptPUF-SOWWe5c6g@mail.gmail.com>

On 11/16/26 12:25 PM, Miguel Ojeda wrote:
> On Thu, Nov 12, 2026 at 12:11 AM Andrew Davis <afd@ti.com> wrote:
>>
>> Well Sashiko suggested I take the easy way and just re-use a different C
>> function instead of trying to open-code the loop in Rust. The C function
> 
> I noticed this series while going through Lore threads, and yeah, it
> is generally better to avoid re-implementing logic in Rust if a
> suitable function already exists in C in the subsystem (unless there
> is a good reason to not do so, of course).
> 

Perfect, sounds like v2 here is the right to go then. I'll resend
this RFC as a normal PATCH then.

> By the way, while the maintainers may already know about the removal,
> I would suggest adding a Link: or commit reference to the patch
> removing that C function, i.e. to give context for others.
> 

It's not been coordinated much, I've been just converting drivers over
to better functions until there are none left using this old one. Then
will send a patch to drop the then unused old function. Only a few users
left after this Rust one.

> I hope that helps!
> 

It does, thanks!

Andrew

> Cheers,
> Miguel
> 


      reply	other threads:[~2026-11-17  1:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 20:52 [RFC PATCH] " Andrew Davis
2026-11-11 23:10 ` [RFC PATCH v2] " Andrew Davis
2026-11-16 18:25   ` Miguel Ojeda
2026-11-17  1:40     ` Andrew Davis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ce992f0-4f9e-4359-937e-12553fa46b37@ti.com \
    --to=afd@ti.com \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@garyguo.net \
    --cc=igor.korotin@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tamird@kernel.org \
    --cc=tmgross@umich.edu \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®