mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jules Irenge <jbi.octave@gmail.com>
To: boqun.feng@gmail.com
Cc: juri.lelli@redhat.com, peterz@infradead.org, mingo@redhat.com,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
	linux-kernel@vger.kernel.org, Jules Irenge <jbi.octave@gmail.com>
Subject: [PATCH 06/11] sched/deadline: Add missing annotation for dl_task_offline_migration()
Date: Sun,  9 Feb 2020 22:39:33 +0000	[thread overview]
Message-ID: <4cebf47c30ce24ee1972f4b6330376d8f32802b9.1581282103.git.jbi.octave@gmail.com> (raw)
In-Reply-To: <cover.1581282103.git.jbi.octave@gmail.com>

Sparse reports warning at dl_task_offline_migration()

warning: context imbalance in dl_task_offline_migration()
	 - unexpected unlock

The root cause is the missing annotation for dl_task_offline_migration()

Add the missing __releases(rq->lock) annotation.

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 kernel/sched/deadline.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 43323f875cb9..68ea3a4933db 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -527,6 +527,7 @@ static inline void deadline_queue_pull_task(struct rq *rq)
 static struct rq *find_lock_later_rq(struct task_struct *task, struct rq *rq);
 
 static struct rq *dl_task_offline_migration(struct rq *rq, struct task_struct *p)
+	__releases(rq->lock)
 {
 	struct rq *later_rq = NULL;
 	struct dl_bw *dl_b;
-- 
2.24.1


  parent reply	other threads:[~2020-02-09 22:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0/11>
2020-02-09 22:24 ` [PATCH 00/11] Lock warning cleanup Jules Irenge
2020-02-09 22:27   ` [PATCH 01/11] hrtimer: Add missing annotation to lock_hrtimer_base() Jules Irenge
2020-02-09 22:29   ` [PATCH 02/11] futex: Add missing annotation for wake_futex_pi() Jules Irenge
2020-02-09 22:30   ` [PATCH 03/11] futex: Add missing annotation for fixup_pi_state_owner() Jules Irenge
2020-02-09 22:33   ` [PATCH 04/11] perf/ring_buffer: Add missing annotation to perf_output_end() Jules Irenge
2020-02-09 22:37   ` [PATCH 05/11] sched/fair: Add missing annotation for nohz_newidle_balance() Jules Irenge
2020-02-09 22:39   ` Jules Irenge [this message]
2020-02-10  8:07     ` [PATCH 06/11] sched/deadline: Add missing annotation for dl_task_offline_migration() Juri Lelli
2020-02-09 22:44   ` [PATCH 07/11] fs_pin: Add missing annotation for pin_kill() declaration Jules Irenge
2020-02-09 22:45   ` [PATCH 08/11] fs_pin: Add missing annotation for pin_kill() definition Jules Irenge
2020-02-09 22:48   ` [PATCH 09/11] kasan: add missing annotation for start_report() Jules Irenge
2020-02-10  7:27     ` Dmitry Vyukov
2020-02-09 22:49   ` [PATCH 10/11] kasan: add missing annotation for end_report() Jules Irenge
2020-02-10  7:27     ` Dmitry Vyukov
2020-02-09 22:50   ` [PATCH 11/11] futex: Add missing annotation for futex_wait_queue_me() Jules Irenge
2020-02-10  5:06   ` [PATCH 00/11] Lock warning cleanup Boqun Feng
2020-02-10 23:09     ` Jules Irenge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4cebf47c30ce24ee1972f4b6330376d8f32802b9.1581282103.git.jbi.octave@gmail.com \
    --to=jbi.octave@gmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®