From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E56FD391840 for ; Tue, 9 Jun 2026 09:31:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780997467; cv=none; b=O9357RYC16WEhuUCibIC5tsFhpcUurAl+158zJDAZtDyqgGQog1CMmu7Nukp8P+IhVSiyvan6fumCGM7b2NpTCulm+7aLmzCw4psvg05gWoLx1znV5Km+u6CBWgQR3wzB24Xd8eazk65dHEOqQJktjuzmWEkBCZ6FOX3SASVD1g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780997467; c=relaxed/simple; bh=MNkG34kMsVvnIhkvNI7U4mabmb8YGJmSa1V1L6Dp6No=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nhrbxgoizZ4zfmV4zQ/H2Y5fZuGBSzt6lMwbHghV2m6I/FOv9k4iHGncn/F7MOc38dROAHc/ySWzDyrs5feZJhzTxfkKtf0VjKCBX7wwwpajbDtDXH22ZKjy/4Dxh87nDcXvt9BJFCSDZ23JKgmdCL4QsPxr/B0WkL67VEmRz78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RiQ/uF3m; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NVaX12XM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RiQ/uF3m"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NVaX12XM" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6597rbqd1923228 for ; Tue, 9 Jun 2026 09:31:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BMa3qXAR5txkpAwY5jpKqli4jX9daJVnoCU3TE9NuOI=; b=RiQ/uF3mP/XnZ6bU SId5H3m4HAASGnXJXGsMf3odDzD3ZsQxdsKs5Z1hd7j6+ZSLE7s0pe8eXz+9OW2w GMFWzmITNWuh4yYqvd26yhZrlzVN0cX0JuLPz13twLM1ot3WxcTckKFb8jQPx03t OcSd8PRmTgKtgNdP+Xk8GEEV2L3UKVFwVrCEEVhXzX/nhA0QBg0yjXBTl2aAtMn0 tmAasEXfrPRJwouMqnJRQoRqdfaGWhh13pFnZpAgArLuHQAuQXpfoweFq01jvRHd +/5QA0EvGOwZ8xB6ezMvYtshvnHxUJtD/yG88zIVAKvcrdTFEkURRmjrS9DK1o4+ mHj4MQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epee4ggn0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 09:31:04 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-5177b12d7bbso9460091cf.1 for ; Tue, 09 Jun 2026 02:31:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780997464; x=1781602264; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BMa3qXAR5txkpAwY5jpKqli4jX9daJVnoCU3TE9NuOI=; b=NVaX12XM42/UxPdmc1N8Cbn+lmwD9K+6LsrQq52HGDCLnuG74sSap2h7e5LMhxBfsC 9V4JuWUlm+rJee5Yj9qeNcGyi7HIZaYLboFpZhhF75OqmmxdsgkICvC7VPTVze2psSM8 PPO0qahvqXUYrYZybunKiDUMHVk09VojOe4MSorDfdEdA5tc+tkCjbxqvIvhcR+gHRqg cFTbAxZ0z3inw/zoOPXs17hStYNQgxyiSNkofXBQ8PNwMSQwMcVE+iHbVvptM9Uif0O4 rxcJ3Pr02afvk5Qr0zSPtNMJiC815I1v4/OX+LsugL+BCQk4jpCjU6fo34zGsHPVg6jB BKNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780997464; x=1781602264; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BMa3qXAR5txkpAwY5jpKqli4jX9daJVnoCU3TE9NuOI=; b=H6HbclK2/P4ufljWFVbrXmZcb0Ykr/VM/fV2EDQId4CE/yZWiUQyX6qiWci0pIK05t 9o/31B4nOt0qGftHNT1VbEXBIrKAjMEBscx4GC3rHKFQMsg1sIGdsW/tUBy32G/pzsbP ik6YkD+U+WfSbehW5R5vnMEps/k+NksMMj9AsMoBpXCzq6vKOj+6HsZAXd9naburbkD7 iaqgZLPA0BkLxWKtcJnNKUiykdCOEJMk3rozazEdAMU+JVQly1KYD6fiSBqqy++2ZfGK ZhomDctaE5XAzlaNXztci1E6OxZLVaksUobI/90YixaTaURga4MALGzNJjaa6U6vRng4 0ULg== X-Forwarded-Encrypted: i=1; AFNElJ9XZUqAG9fdrLDGRZNMGOtTAPEEibf2RPmjTCebCZKaul/9aZTeBJ/ne7IsQS84n1sJmrb3x60VnbdToEM=@vger.kernel.org X-Gm-Message-State: AOJu0Yzwg+kY27wtwJJbRzEgB00/iJ3LFZC5CrsvAsMmzQt4iHnnEIZs EvRsxaduD5337w2G9lmf5KBTx5u2IkzM8h8+Lh0Wzva+7wvqVEIZsWyQuyScdC5HP319XQXyDZV UXEg2UgZ7PF3b6AF6rOF9b9AbjMdsQ4Uw+grLKnXnW1IEJSxTqq2si+uqorFkBgHDdwc= X-Gm-Gg: Acq92OEy7+KRu+O9Uz0gBEnOxLkCkQQT6hZLqMOUwdfKuMPJuNAdMSf8qKJ5g2XHhO7 OQMzDa9mU4nD4vkWG5XbKFHP0I3hImm/ZAJG+LLAIUeSxhjwKJ9h2Xt4pomCPy6xtkPi1Yl475e GmIoe04FhIAY35rf7fHjDKaW+iz+liltwWrtCv2Mbu0grrpSf8YI9bwZOIefo+t5wc8rGYxAfzE Gdn369FD7DzlFTxmIGlHE6GkAWDwqSRhmtgEFQiJV9CCnAgJrxZ0wFAQ/WQDdj/cfnwr6ZT8tGu T/2RAXAvDD0Ltp0qMzYw2u7NdzMRj4V6dYKPXUbeo+XVL7qnD127cOJyD3+YjxK1ldIfCn1qAu5 8KGkS0gWR64LA3Ox+Int5+TygHCylCd0HFM92Q/tk2+IeHZXU/jRzucvG X-Received: by 2002:ac8:59c8:0:b0:50b:2875:5782 with SMTP id d75a77b69052e-51795c56077mr168230401cf.6.1780997464171; Tue, 09 Jun 2026 02:31:04 -0700 (PDT) X-Received: by 2002:ac8:59c8:0:b0:50b:2875:5782 with SMTP id d75a77b69052e-51795c56077mr168229991cf.6.1780997463612; Tue, 09 Jun 2026 02:31:03 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf05228a16csm1005080866b.28.2026.06.09.02.30.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 02:30:59 -0700 (PDT) Message-ID: <4ced3207-a132-4ec5-a0eb-79f75f5cb4bb@oss.qualcomm.com> Date: Tue, 9 Jun 2026 11:30:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: Add Microsoft Surface Pro 12in To: Harrison Vanderbyl , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: jikos@kernel.org, bentiss@kernel.org, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, dmitry.baryshkov@oss.qualcomm.com References: <20260529011619.9586-1-harrison.vanderbyl@gmail.com> <20260529011619.9586-3-harrison.vanderbyl@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260529011619.9586-3-harrison.vanderbyl@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=PIs/P/qC c=1 sm=1 tr=0 ts=6a27dd58 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=_XXtN2VGHKrtNHovNKMA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: VFGOSbxiGD_gfzx3wj8I3TsKlh4sKGRK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDA4OCBTYWx0ZWRfX4Q0BSpLlojig qKQp8aFdjPm0LLBXWm4YMNHldxGwFaj9TZpq6pcVZxySlYabU2mGJGmZ5kBC4vwwDRHqrm9Qp5Y u1AouhfIkf40KumjtRa8TovQ3CA8mSVLEVBEMYz9rS9eK/SPJPd3UeE2IV0rV+mm8aE0k1xchYE M1zXOWQdKrMbTHphX6FAZsAbODrMaUzTN8MTcY7v5ywe5KtPXVGlJKbRT9FhO4PEp7yN+YKEi87 JcImHaUzxC+ENrSgkHJgf+fxpS/L1HPq7FBSfcNBTSLlupG189VyrNJkZwhhcy+cj6wZCCaPjC4 U+zALHmJHFgMIpS4LQTyimOa/W5WVemuttJQ4x2COpMH49tK8WTAXptXS4I2BqmY15v65cXHQB9 oEsgyBlrQlFMfIokm8MAdDevaJkpIKfk/HPx7NkjRmz0WIXaAx3vQI0VdrKKRUiBOCdXayUZXXP PacI4mb6ia9jDvrz89Q== X-Proofpoint-ORIG-GUID: VFGOSbxiGD_gfzx3wj8I3TsKlh4sKGRK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_02,2026-06-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 suspectscore=0 adultscore=0 spamscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090088 On 5/29/26 3:16 AM, Harrison Vanderbyl wrote: > Initial device tree for Microsoft Surface Pro 12in > > Currently supported: > - UFS > - Touchscreen > - Pen > - USB 3.2 x2 (DP Alt Mode) > - Audio > - Wifi > - Bluetooth > - CDSP > - ADSP > - GPU > > Not currently supported: > - Accelerometer > - Front, Back and IR cameras > - IRIS video decoder > > Tested on Surface_Pro_12in_1st_Ed_with_Snapdragon_2110 > > Signed-off-by: Harrison Vanderbyl > Reviewed-by: Dmitry Baryshkov > --- lg, just a couple nits [...] > + codec { > + sound-dai = <&left_spkr>, <&right_spkr>, > + <&swr0 0>, <&lpass_wsamacro 0>; Please align the +&i2c9 { > + clock-frequency = <400000>; > + > + /* NFC @28, commercial devices only */ > + > + status = "okay"; Because we'd put the subnodes for devices under the 'status' line (DTC enforces that), please move the comment below as well Or since it's @28, perhaps it's just nxp,nxp-nci-i2c and it could work for you ootb? [...] > +&tlmm { > + gpio-reserved-ranges = <34 2>, /* Unused */ > + <44 4>; /* SPI (TPM) */ Please align the