From: "Nitin Gupta" <nitingupta910@gmail.com>
To: "Andrey Panin" <pazke@donpac.ru>, linux-kernel@vger.kernel.org
Cc: "Richard Purdie" <richard@openedhand.com>
Subject: Re: [RFC] LZO1X de/compression support
Date: Tue, 22 May 2007 14:38:35 +0530 [thread overview]
Message-ID: <4cefeab80705220208w2200b2f1x1d7a8c7e0c01dfb9@mail.gmail.com> (raw)
In-Reply-To: <20070518111107.GA27003@pazke.donpac.ru>
Hi,
On 5/18/07, Andrey Panin <pazke@donpac.ru> wrote:
> On 138, 05 18, 2007 at 03:28:31PM +0530, Nitin Gupta wrote:
> > + register const unsigned char *ip;
>
> register keyword is meaningless for today's compiler.
But can we assume that gcc is being used? What if we use compiler for
which it does matter (can't give example for this...)?
>
> > + unsigned char *op;
> > + const unsigned char * const in_end = in + in_len;
> > + const unsigned char * const ip_end = in + in_len - M2_MAX_LEN - 5;
> > + const unsigned char *ii;
> > + const unsigned char ** const dict = (const unsigned char **)workmem;
> > +
> > + op = out;
>
> Why not write this as `unsigned char *op = out;` ?
>
Done.
> Empty if() body ?
No empty if() now.
> > + m_off -= 0x4000;
>
> What's this magic number 0x4000 repeated everywhere ? M3_MAX_OFFSET perhaps ?
I don't know :)
> > +#if defined(__LITTLE_ENDIAN)
> > + m_pos = op - 1;
> > + m_pos -= (*(const unsigned short *)ip) >> 2;
> > +#else
> > + m_pos = op - 1;
> > + m_pos -= (ip[0] >> 2) + (ip[1] << 6);
> > +#endif
>
> IMHO you could write it this way:
>
> m_pos = op - 1 - (le16_to_cpu(*(const u16 *)ip) >> 2);
>
Shouldn't this be cpu_to_le16() ?
> > +#if defined(__LITTLE_ENDIAN)
> > + m_pos -= (*(const unsigned short *)ip) >> 2;
> > +#else
> > + m_pos -= (ip[0] >> 2) + (ip[1] << 6);
> > +#endif
>
> m_pos -= le16_to_cpu(*(const u16 *)ip) >> 2;
cpu_to_le16() ?
---
Can you please snip-out irrelevant code parts. It is real pain for
eyes to sneek out your comments otherwise :)
Thanks for your comments.
Cheers,
Nitin
next prev parent reply other threads:[~2007-05-22 9:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-18 9:58 Nitin Gupta
2007-05-18 10:14 ` Heikki Orsila
2007-05-18 11:27 ` Nitin Gupta
2007-05-18 11:53 ` Richard Purdie
2007-05-18 10:42 ` Pekka Enberg
2007-05-18 10:53 ` Pekka Enberg
2007-05-22 8:54 ` Nitin Gupta
2007-05-22 8:59 ` Pekka Enberg
2007-05-22 9:10 ` Nitin Gupta
2007-05-22 9:34 ` Pekka Enberg
2007-05-18 11:11 ` Andrey Panin
2007-05-22 9:08 ` Nitin Gupta [this message]
2007-05-22 19:44 ` Jan Engelhardt
2007-05-22 21:24 ` Bernd Petrovitsch
2007-05-23 16:35 ` Jeremy Fitzhardinge
2007-05-18 11:46 ` Richard Purdie
2007-05-22 9:19 ` Nitin Gupta
2007-05-18 20:04 ` Matt Mackall
2007-05-18 21:14 ` Krzysztof Halasa
2007-05-19 18:55 ` Bill Rugolsky Jr.
2007-05-19 21:52 ` Richard Purdie
2007-05-22 19:40 ` Jan Engelhardt
2007-05-19 18:12 devzero
2007-05-20 11:42 Tomasz Chmielewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cefeab80705220208w2200b2f1x1d7a8c7e0c01dfb9@mail.gmail.com \
--to=nitingupta910@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pazke@donpac.ru \
--cc=richard@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®