From: "Nitin Gupta" <nitingupta910@gmail.com>
To: "Daniel Hazelton" <dhazelton@enter.net>
Cc: "Satyam Sharma" <satyam.sharma@gmail.com>,
"Richard Purdie" <richard@openedhand.com>,
linux-kernel@vger.kernel.org, linux-mm-cc@laptop.org,
"Andrew Morton" <akpm@linux-foundation.org>,
"Andrey Panin" <pazke@donpac.ru>, "Bret Towe" <magnade@gmail.com>,
"Michael-Luke Jones" <mlj28@cam.ac.uk>
Subject: Re: [RFC] LZO de/compression support - take 4
Date: Mon, 28 May 2007 14:07:04 +0530 [thread overview]
Message-ID: <4cefeab80705280137v178a449fl391b99b6804a75f2@mail.gmail.com> (raw)
In-Reply-To: <200705280418.07538.dhazelton@enter.net>
On 5/28/07, Daniel Hazelton <dhazelton@enter.net> wrote:
> Test code for this version (take 4) of the minimized LZO1X (from the liblzo
> v2) is complete.
>
>
> I don't see a significant slow-down comparing the complete liblzo2 to this
> minimized code on my system (Pentium M 1.73GHz, 1GB Ram, Kubuntu Feisty
> (stock Kubuntu kernel)). Rather, I see the opposite. This *might* have been
> caused by the dynamic linking (or similar) so rather than rely on simply
> doing "time xxx" I actually put checks around the calls to the
> compress/decompress functions themselves.
>
> ('Tiny LZO' is what I call Nitins extremely small implementation of
> lzo1x_[de]compress)
>
> Output of the provided "test" script:
> 10 run averages:
> 'Tiny LZO':
> Combined: 113.2 usec
> Compression: 77.4 usec
> Decompression: 35.8 usec
> 'liblzo2':
> Combined: 140.7 usec
> Compression: 94 usec
> Decompression: 46.7 usec
>
> (The "Combined" average is the average time taken for a compress+decompress)
>
> TODO:
> -Implement userspace version of likely/unlikely
> -Implement cpu_to_le16 so code functions on BE systems
>
> DRH
>
>
As you mentioned in your mail, you are using lzo1x_1_11_compress()
which is slower than what I ported (which is same as what is exported
by miniLZO). So, can you please test with the version ported - this
is found in lzo/src/lzo1x_1.c (or in minilzo.c).
Also, can you please use 'take 5' for your next testing?
Thanks,
Nitin
next prev parent reply other threads:[~2007-05-28 8:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-25 11:45 Nitin Gupta
2007-05-25 12:00 ` Michael-Luke Jones
2007-05-25 12:10 ` Richard Purdie
2007-05-25 12:37 ` Satyam Sharma
2007-05-25 13:38 ` Richard Purdie
2007-05-25 16:55 ` Daniel Hazelton
2007-05-25 18:45 ` Daniel Hazelton
2007-05-25 19:35 ` Satyam Sharma
2007-05-28 8:18 ` Daniel Hazelton
2007-05-28 8:37 ` Nitin Gupta [this message]
2007-05-28 8:43 ` Daniel Hazelton
2007-05-28 9:08 ` Nitin Gupta
2007-05-28 9:21 ` Daniel Hazelton
2007-05-28 9:46 ` Nitin Gupta
2007-05-28 9:58 ` Daniel Hazelton
2007-05-25 12:57 ` Nitin Gupta
2007-05-25 13:33 ` Richard Purdie
2007-05-26 10:28 ` Richard Purdie
2007-05-26 11:21 ` Nitin Gupta
2007-05-25 12:32 ` Satyam Sharma
2007-05-26 19:17 roland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cefeab80705280137v178a449fl391b99b6804a75f2@mail.gmail.com \
--to=nitingupta910@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dhazelton@enter.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm-cc@laptop.org \
--cc=magnade@gmail.com \
--cc=mlj28@cam.ac.uk \
--cc=pazke@donpac.ru \
--cc=richard@openedhand.com \
--cc=satyam.sharma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome