mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Nitin Gupta" <nitingupta910@gmail.com>
To: "Richard Purdie" <rpurdie@openedhand.com>
Cc: akpm <akpm@linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -mm] Add LZO1X compression support to the kernel
Date: Thu, 7 Jun 2007 14:23:54 +0530	[thread overview]
Message-ID: <4cefeab80706070153p4021883aq14d3be080ba682cd@mail.gmail.com> (raw)
In-Reply-To: <1181204856.6086.13.camel@localhost.localdomain>

On 6/7/07, Richard Purdie <rpurdie@openedhand.com> wrote:
> On Thu, 2007-06-07 at 10:11 +0530, Nitin Gupta wrote:
> > Your code now looks nice and clean. But I don't know what you want. I
> > already spent lot of time on version 7 I posted and contains all those
> > corrections which were suggested for my earlier version. I cannot ask
> > you to look into possible problems (if any) in my code now since  you
> > are not interested in that anyway. So, please continue this
> > duplication.
>
> What I (and others) repeatedly asked for was an explanation of why there
> were the differences between the bytecode from your version and the
> bytecode from mine. This was never explained by you and I was left to do
> this myself. Sadly, doing so meant some duplication.
>

I don't know the reason for bytecode difference. I focused on making
sure that the C code is functionally identical to original code. I
never did a bytecode diff.

> Anyhow, I think I can now explain the differences. Now we have two
> versions, its a question of how to proceed. Basically one needs to be
> merged into the other. I will try and compare the two patches and see
> what differences we have.

Sounds good.

Regards,
Nitin

  reply	other threads:[~2007-06-07  8:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-06 17:26 Richard Purdie
2007-06-07  4:41 ` Nitin Gupta
2007-06-07  8:27   ` Richard Purdie
2007-06-07  8:53     ` Nitin Gupta [this message]
2007-06-07  6:06 ` Paul Mundt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4cefeab80706070153p4021883aq14d3be080ba682cd@mail.gmail.com \
    --to=nitingupta910@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpurdie@openedhand.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®