From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C3B2C11D00 for ; Thu, 20 Feb 2020 08:18:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E09F824654 for ; Thu, 20 Feb 2020 08:18:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726948AbgBTISI convert rfc822-to-8bit (ORCPT ); Thu, 20 Feb 2020 03:18:08 -0500 Received: from szxga02-in.huawei.com ([45.249.212.188]:3018 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726501AbgBTISI (ORCPT ); Thu, 20 Feb 2020 03:18:08 -0500 Received: from DGGEMM404-HUB.china.huawei.com (unknown [172.30.72.56]) by Forcepoint Email with ESMTP id 5EBDE75DE2C3B4178073; Thu, 20 Feb 2020 16:18:04 +0800 (CST) Received: from dggeme701-chm.china.huawei.com (10.1.199.97) by DGGEMM404-HUB.china.huawei.com (10.3.20.212) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 20 Feb 2020 16:18:03 +0800 Received: from dggeme753-chm.china.huawei.com (10.3.19.99) by dggeme701-chm.china.huawei.com (10.1.199.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Thu, 20 Feb 2020 16:18:03 +0800 Received: from dggeme753-chm.china.huawei.com ([10.7.64.70]) by dggeme753-chm.china.huawei.com ([10.7.64.70]) with mapi id 15.01.1713.004; Thu, 20 Feb 2020 16:18:03 +0800 From: linmiaohe To: Li RongQing , "pbonzini@redhat.com" , "vkuznets@redhat.com" CC: Liran Alon , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" Subject: Re: [PATCH][resend] KVM: fix error handling in svm_cpu_init Thread-Topic: [PATCH][resend] KVM: fix error handling in svm_cpu_init Thread-Index: AdXnxCuvQCn2ngYdSyKWLfuyXd13zw== Date: Thu, 20 Feb 2020 08:18:03 +0000 Message-ID: <4cf5d767b570430a9e0b515a9d6d8fbd@huawei.com> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.173.221.158] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Li RongQing writes: > >sd->save_area should be freed in error path > >Fixes: 70cd94e60c733 ("KVM: SVM: VMRUN should use associated ASID when SEV is enabled") >Signed-off-by: Li RongQing >Reviewed-by: Brijesh Singh >Reviewed-by: Vitaly Kuznetsov >--- > arch/x86/kvm/svm.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) Oh, it's strange. This is already fixed in my previous patch : [PATCH v2] KVM: SVM: Fix potential memory leak in svm_cpu_init(). And Vitaly and Liran gave me Reviewed-by tags and Paolo queued it one month ago. But I can't found it in master or queue branch. There might be something wrong. :(