mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Zhou, Yun" <yun.zhou@windriver.com>
To: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: rand.sec96@gmail.com, contact@arnaud-lcm.com,
	kovalev@altlinux.org, zheng.yu@northwestern.edu, eadavis@qq.com,
	jfs-discussion@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] jfs: add dtroot integrity check to prevent index out-of-bounds
Date: Tue, 9 Dec 2025 10:41:12 +0800	[thread overview]
Message-ID: <4cffc24f-69b6-4869-8f1c-81b7c1ba133c@windriver.com> (raw)
In-Reply-To: <bf6d47da-4c2e-40e4-85c0-ae3061d6c39c@oracle.com>

Hi Shaggy,

Thank you for your reply.  I am willing to continue investigating and 
resolving
these issues, and look forward to your suggestions.Yun
On 12/2/25 06:31, Dave Kleikamp wrote:
>
> On 11/20/25 9:43AM, Yun Zhou wrote:
>> Add check_dtroot() to validate dtroot_t integrity, focusing on 
>> preventing
>> index/pointer overflows from on-disk corruption.
>>
>> Key checks:
>>   - freecnt bounded by [0, DTROOTMAXSLOT-1] (slot[0] reserved for 
>> header).
>>   - freelist validity: -1 when freecnt=0; 1~DTROOTMAXSLOT-1 when 
>> non-zero,
>>     with linked list checks (no duplicates, proper termination via 
>> next=-1).
>>   - stbl bounds: nextindex within stbl array size; entries within 
>> 0~8, no
>>     duplicates (excluding idx=0).
>>
>> Invoked in copy_from_dinode() when loading directory inodes, catching
>> corruption early before directory operations trigger out-of-bounds 
>> access.
>
> I really like the idea of these patches. I'm swamped with some other
> work and have been out on vacation a bit, but I do intend to give these
> a good review and hopefully integrate them. Thanks for your patience.
>
> Shaggy

  reply	other threads:[~2025-12-09  2:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20 15:43 Yun Zhou
2025-12-01 22:31 ` Dave Kleikamp
2025-12-09  2:41   ` Zhou, Yun [this message]
2026-03-16 21:08 ` Dave Kleikamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4cffc24f-69b6-4869-8f1c-81b7c1ba133c@windriver.com \
    --to=yun.zhou@windriver.com \
    --cc=contact@arnaud-lcm.com \
    --cc=dave.kleikamp@oracle.com \
    --cc=eadavis@qq.com \
    --cc=jfs-discussion@lists.sourceforge.net \
    --cc=kovalev@altlinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rand.sec96@gmail.com \
    --cc=zheng.yu@northwestern.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®