From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5927630B53E for ; Mon, 8 Sep 2025 13:05:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757336760; cv=none; b=ooMtRLkEvbBtEKD5moKHNX4/GQW+tYK7P9NMv314oMwP5iPFoH31sF6Q0atdgVfJkjhmeTrCTkLYIwWWqty1C4LwLllhyPn2yldhvRmups5bUZlpyxLmfWdCBFpbmVrQgmplWjJBrInZHMLxIf9eBVAjsjOCLhAxwZBrGZNO4e0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757336760; c=relaxed/simple; bh=H9/Oamwtgz/5hKqDhtx7qZNLQZhQzS1ptRATl9D7PSQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OXt44+LZBqNY/YbUuN2tC2oPCF6PQVU96Jtnttv16DSPM6QUJYrnsRYbHZ9Cyua+YUHD9LKD9B2eYYUCXV0y6Ia6j03xbXCjbeFc5O35CWdWMU6z6lpcrI96FEGXJx7JG+J1kXwev8v6GrFBhtsuf+/dqdGCcITQKUTUcpRnmDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ON22o27I; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=J5RPxvOS; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ON22o27I; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=J5RPxvOS; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ON22o27I"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="J5RPxvOS"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ON22o27I"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="J5RPxvOS" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9727425D8A; Mon, 8 Sep 2025 13:05:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1757336755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7J/5jyC4CPYC1mYA5Nbh128F4Qm/h2p5bihZrP5YpZY=; b=ON22o27InxEfGG8q4I0/A8vfq9i30a1ijfTzFxUb3d9cmwOo7XbL+4aV0cmYAWS0zXRHBk A/AAS8N6LXyAGZ5qbi4JwoxXgnnVuvbfy0etbJQ9w6r/+Xk+K94lju+D7KCKYFvCuXClUJ c/cDDkriXa4fSRJNXFB9JOgLJN7Lg3k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1757336755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7J/5jyC4CPYC1mYA5Nbh128F4Qm/h2p5bihZrP5YpZY=; b=J5RPxvOSRKY7Ki3M6Ii6DI0RHS0UD2CYG+Uu0TlslYh3QPU1IHQTR8caeozoaJQrH6bTAH CqiYpVwk5MvDzTCw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1757336755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7J/5jyC4CPYC1mYA5Nbh128F4Qm/h2p5bihZrP5YpZY=; b=ON22o27InxEfGG8q4I0/A8vfq9i30a1ijfTzFxUb3d9cmwOo7XbL+4aV0cmYAWS0zXRHBk A/AAS8N6LXyAGZ5qbi4JwoxXgnnVuvbfy0etbJQ9w6r/+Xk+K94lju+D7KCKYFvCuXClUJ c/cDDkriXa4fSRJNXFB9JOgLJN7Lg3k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1757336755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7J/5jyC4CPYC1mYA5Nbh128F4Qm/h2p5bihZrP5YpZY=; b=J5RPxvOSRKY7Ki3M6Ii6DI0RHS0UD2CYG+Uu0TlslYh3QPU1IHQTR8caeozoaJQrH6bTAH CqiYpVwk5MvDzTCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8030213946; Mon, 8 Sep 2025 13:05:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id QwJkHrPUvmhnMAAAD6G6ig (envelope-from ); Mon, 08 Sep 2025 13:05:55 +0000 Date: Mon, 8 Sep 2025 15:05:54 +0200 From: Daniel Wagner To: linux-nvme@lists.infradead.org Cc: Jens Axboe , Keith Busch , Christoph Hellwig , Sagi Grimberg , "Michael S. Tsirkin" , Aaron Tomlin , "Martin K. Petersen" , Thomas Gleixner , Costa Shulyupin , Juri Lelli , Valentin Schneider , Waiman Long , Ming Lei , Frederic Weisbecker , Mel Gorman , Hannes Reinecke , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, storagedev@microchip.com, virtualization@lists.linux.dev, GR-QLogic-Storage-Upstream@marvell.com Subject: Re: [PATCH v8 10/12] blk-mq: use hk cpus only when isolcpus=io_queue is enabled Message-ID: <4d006f81-cd3f-4aba-89db-fbc2e8c667b1@flourine.local> References: <20250905-isolcpus-io-queues-v8-0-885984c5daca@kernel.org> <20250905-isolcpus-io-queues-v8-10-885984c5daca@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Level: X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[25]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; MISSING_XM_UA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo] X-Spam-Flag: NO X-Spam-Score: -4.30 On Mon, Sep 08, 2025 at 09:36:35AM +0200, Daniel Wagner wrote: > which resulted in a way cleaner code. Though the kernel test robot > complained with > > >> block/blk-mq-cpumap.c:155:16: error: array initializer must be an initializer list > 155 | cpumask_var_t active_hctx __free(free_cpumask_var) = NULL; > > I try to figure out if it's possible to get this somehow working with > some witchcraft (aka pre compiler magic). What about adding something like this here: #ifdef CONFIG_CPUMASK_OFFSTACK #define scoped_cpumask_var(_name) \ cpumask_var_t _name __free(free_cpumask_var) = NULL; #else /* ! CONFIG_CPUMASK_OFFSTACK */ #define scoped_cpumask_var(_name) \ cpumask_var_t _name __free(free_cpumask_var); #endif /* ! CONFIG_CPUMASK_OFFSTACK */ This would make the new code way cleaner.