From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jianing Li <m13940358460@163.com>, Sebastian Reichel <sre@kernel.org>
Cc: Iskren Chernev <me@iskren.info>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Matheus Castello <matheus@castello.eng.br>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] power: supply: max17040: fail probe when requesting the alert IRQ fails
Date: Mon, 2 Nov 2026 08:40:23 +0100 [thread overview]
Message-ID: <4d021a7f-59cc-4077-9d9b-e4d4cb72dd97@kernel.org> (raw)
In-Reply-To: <20261102073148.1233-3-m13940358460@163.com>
On 02/11/2026 08:31, Jianing Li wrote:
> MAX17048 and MAX17049 skip polling work initialization when an IRQ is
> available because SOC alerts replace polling. If requesting that IRQ
> fails, max17040_probe() clears client->irq and returns success anyway.
> The driver then has neither an interrupt handler nor a polling worker.
>
> Clearing client->irq also makes the suspend and resume callbacks take
> the polling path, which operates on an uninitialized delayed work item.
>
> Propagate the IRQ request error instead of registering a device with
> inconsistent interrupt and polling state. The managed resources unwind
> the already registered power supply and, for polling models, cancel any
> queued work.
That's LLM commit msg and you are not suppose to use LLM for that.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-11-02 7:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 7:31 [PATCH 0/2] power: supply: max17040: fix error-path state handling Jianing Li
2026-11-02 7:31 ` [PATCH 1/2] power: supply: max17040: preserve alert threshold on write failure Jianing Li
2026-11-02 7:31 ` [PATCH 2/2] power: supply: max17040: fail probe when requesting the alert IRQ fails Jianing Li
2026-11-02 7:40 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d021a7f-59cc-4077-9d9b-e4d4cb72dd97@kernel.org \
--to=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=m13940358460@163.com \
--cc=matheus@castello.eng.br \
--cc=me@iskren.info \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®