From: Markus Elfring <Markus.Elfring@web.de>
To: Dan Carpenter <error27@gmail.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Cc: "David Airlie" <airlied@gmail.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Tvrtko Ursulin" <tursulin@ursulin.net>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/i915/bios: Move a variable assignment behind a null pointer check in intel_bios_encoder_supports_dp_dual_mode()
Date: Tue, 14 Jul 2026 18:10:08 +0200 [thread overview]
Message-ID: <4d0426b4-e40b-4cc6-841f-ca18b2256db4@web.de> (raw)
In-Reply-To: <alZZviFT2jfABiZq@stanley.mountain>
>>> The address of a data structure member was determined before
>>> a corresponding null pointer check in the implementation of
>>> the function “intel_bios_encoder_supports_dp_dual_mode”.
>>>
>>> Thus avoid the risk for undefined behaviour by reducing the scope for
>>> the variable “child” behind condition checks.
>>>
>>> This issue was detected by using the Coccinelle software.
>>>
>>> Fixes: 044cbc7a74c136f12a80c855cadd1b085084aef1 ("drm/i915/bios: Nuke DEVICE_TYPE_DP_DUAL_MODE_BITS")
>>> Cc: stable@vger.kernel.org
>
> Please stop adding Fixes tags to these and talking about "undefined
> behavior" in the commit message. Pointer math is defined...
What does hinder you to take additional information sources better into account?
> It's just a style preference on your part.
Do you find the guidance appropriate according to the SEI CERT C Coding Standard?
https://cmu-sei.github.io/secure-coding-standards/sei-cert-c-coding-standard/rules/expressions-exp/exp34-c/
Regards,
Markus
prev parent reply other threads:[~2026-07-14 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 14:05 Markus Elfring
2026-07-14 15:28 ` Rodrigo Vivi
2026-07-14 15:46 ` Dan Carpenter
2026-07-14 16:10 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d0426b4-e40b-4cc6-841f-ca18b2256db4@web.de \
--to=markus.elfring@web.de \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=error27@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=tursulin@ursulin.net \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome