From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6EA7CA9EAF for ; Mon, 28 Oct 2019 01:47:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9E567208C0 for ; Mon, 28 Oct 2019 01:47:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729268AbfJ1Brp (ORCPT ); Sun, 27 Oct 2019 21:47:45 -0400 Received: from mga01.intel.com ([192.55.52.88]:5308 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727923AbfJ1Bro (ORCPT ); Sun, 27 Oct 2019 21:47:44 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Oct 2019 18:47:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,238,1569308400"; d="scan'208";a="224494254" Received: from rmullina-mobl.amr.corp.intel.com (HELO [10.255.229.12]) ([10.255.229.12]) by fmsmga004.fm.intel.com with ESMTP; 27 Oct 2019 18:47:42 -0700 Subject: Re: [PATCH] ASoC: SOF: Fix memory leak in sof_dfsentry_write To: Navid Emamdoost Cc: emamd001@umn.edu, kjlu@umn.edu, smccaman@umn.edu, Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Ranjani Sridharan , Greg Kroah-Hartman , Wei Yongjun , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20191027194856.4056-1-navid.emamdoost@gmail.com> From: Pierre-Louis Bossart Message-ID: <4d08ed12-48fa-ed7f-3988-8d040c64acb1@linux.intel.com> Date: Sun, 27 Oct 2019 20:47:42 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20191027194856.4056-1-navid.emamdoost@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/27/19 2:48 PM, Navid Emamdoost wrote: > In the implementation of sof_dfsentry_write() memory allocated for > string is leaked in case of an error. Go to error handling path if the > d_name.name is not valid. > > Fixes: 091c12e1f50c ("ASoC: SOF: debug: add new debugfs entries for IPC flood test") > Signed-off-by: Navid Emamdoost Acked-by: Pierre-Louis Bossart > --- > sound/soc/sof/debug.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/sof/debug.c b/sound/soc/sof/debug.c > index 54cd431faab7..5529e8eeca46 100644 > --- a/sound/soc/sof/debug.c > +++ b/sound/soc/sof/debug.c > @@ -152,8 +152,10 @@ static ssize_t sof_dfsentry_write(struct file *file, const char __user *buffer, > */ > dentry = file->f_path.dentry; > if (strcmp(dentry->d_name.name, "ipc_flood_count") && > - strcmp(dentry->d_name.name, "ipc_flood_duration_ms")) > - return -EINVAL; > + strcmp(dentry->d_name.name, "ipc_flood_duration_ms")) { > + ret = -EINVAL; > + goto out; > + } > > if (!strcmp(dentry->d_name.name, "ipc_flood_duration_ms")) > flood_duration_test = true; >