From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kuba@kernel.org, davem@davemloft.net, pv-drivers@vmware.com,
doshir@vmware.com
Subject: Re: [PATCH] vmxnet3: prevent building with 256K pages
Date: Wed, 16 Jun 2021 07:33:14 +0200 [thread overview]
Message-ID: <4d153452-8d83-248e-886c-bac7aed5a90d@csgroup.eu> (raw)
In-Reply-To: <YMmKPIEk6XQsXq9T@infradead.org>
Le 16/06/2021 à 07:21, Christoph Hellwig a écrit :
> On Tue, Jun 15, 2021 at 02:41:34PM +0200, Christophe Leroy wrote:
>> Maybe we should also exclude hexagon, same as my patch on BTRFS https://patchwork.ozlabs.org/project/linuxppc-dev/patch/a16c31f3caf448dda5d9315e056585b6fafc22c5.1623302442.git.christophe.leroy@csgroup.eu/
>
> Maybe we really need common config symbols for the page size instead of
> all these hacks..
>
I agree.
Today we have:
arch/hexagon/Kconfig:config PAGE_SIZE_4KB
arch/hexagon/Kconfig:config PAGE_SIZE_16KB
arch/hexagon/Kconfig:config PAGE_SIZE_64KB
arch/hexagon/Kconfig:config PAGE_SIZE_256KB
arch/mips/Kconfig:config PAGE_SIZE_4KB
arch/mips/Kconfig:config PAGE_SIZE_8KB
arch/mips/Kconfig:config PAGE_SIZE_16KB
arch/mips/Kconfig:config PAGE_SIZE_32KB
arch/mips/Kconfig:config PAGE_SIZE_64KB
arch/sh/mm/Kconfig:config PAGE_SIZE_4KB
arch/sh/mm/Kconfig:config PAGE_SIZE_8KB
arch/sh/mm/Kconfig:config PAGE_SIZE_16KB
arch/sh/mm/Kconfig:config PAGE_SIZE_64KB
I think we should convert all other architectures to that syntax.
Christophe
prev parent reply other threads:[~2021-06-16 5:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 12:35 Michael Ellerman
2021-06-15 12:41 ` Christophe Leroy
2021-06-16 5:21 ` Christoph Hellwig
2021-06-16 5:33 ` Christophe Leroy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d153452-8d83-248e-886c-bac7aed5a90d@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=doshir@vmware.com \
--cc=hch@infradead.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®