From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753717AbdHWI3h (ORCPT ); Wed, 23 Aug 2017 04:29:37 -0400 Received: from mout.web.de ([212.227.15.3]:63823 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753588AbdHWI3e (ORCPT ); Wed, 23 Aug 2017 04:29:34 -0400 Subject: [PATCH 5/6] ALSA: timer: Adjust a condition check in snd_timer_resolution() From: SF Markus Elfring To: alsa-devel@alsa-project.org, Arnd Bergmann , Arvind Yadav , Dan Carpenter , Ingo Molnar , Jaroslav Kysela , Takashi Iwai , Takashi Sakamoto , Vegard Nossum Cc: kernel-janitors@vger.kernel.org, LKML References: <800d7aa6-d8f2-cbf5-caaa-7e4006976e68@users.sourceforge.net> Message-ID: <4d1a6d05-6574-b1f4-80ee-59cb5238a74e@users.sourceforge.net> Date: Wed, 23 Aug 2017 10:28:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <800d7aa6-d8f2-cbf5-caaa-7e4006976e68@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:yygy6VogSP7WH0Yu4tuExAPywcvP9iopfAem1t3ZrKgY0bWeymT I+v7maNVhWO5Ne5T0s21H+RDdWS1u//SdHIf98Pyp+pT+Tyu2LFiwH2Vrl/5fPpkbeiRFBj aVI6ZVTna0opDlj6fs5zCxtOLKBD5LBiOMNFHvmHJjGBiKADZ5995LRM5Ru4/5Mi/M8GcM7 PL3r5QZMl2yukkxAW7Dpw== X-UI-Out-Filterresults: notjunk:1;V01:K0:5qFQH1PzmvA=:i7y37iBttfXj9rlj4TGiII awwMoypWjP/xPvDZ748/p20Hlm7bUN+/OzcZg7DYgQNbRKpxauLMRUoBC3oCdaA7Ma7RVlh9Y eFZpF0AdwEsmdnz5OPouPJujvTLmoeMmv6A7WUA7CW+6ZxORA7sV0YC8yhfqa3JaMfl3/d4gf X7RE2Sw2qh1Y6ecRjjlbzM+z7qVEPA6RJmx1eV2bjdDa7PuX7tpVizIdNqPQ5RnG8LoSdcl2I YXZBiEI8J++McPj/Gt54HWZZgXDkAnJkaY4JokOqdcyiVPc1EnfblW5NAijKogcaE205+rJIV hAU5ilxH33NxWNYTg69VHTcwhCBPsIKTiKCUjASihrFIaRVCjAQxPIAxZlphBckF6mz7L2gQ/ /p0NxhGv74pyJrb6RIWjgd30T3e7pD3w0IX82LAjUqg5ij78PAmfbu01MFWCGN2VTccurVnNY 8lR2stJKAQ3BO6xwMPt2z9JYQRK/rauus8CpIAOlRyPs1iP8FnPi4Ag5kzrZTpScdk56fxCBr DHkNNKYYk1Vlir9hZOhI9poyGdYRwZ8ag30HKe0dOgHFfOdpdB/D+j3q4IXUvdpvdaq87TUVM fJvtbfYKd5puygjk0jXexE8myesSqJ10WeKssGAcyAZeXYtEpIdF6+NxIlRWtYmtR80OVRZB/ A7gHFaNhukWIIRCVFoZm2RqbwDsiw82FhGtuzhj6jvcH6sgXnqbjKkDSDi72Q1JW7kIwW3LkK awXYZ1S9AyEesVGxeUzS+i3CfOSf5dD8AnV+wt6aUJCGUWexNovwsxX/Iq+5kMafHrEhMCQhF M8dNegJ7FLS5qoua6iPx9XmeBQRg5VEqh6goNwP5Z9FbBwHpjg= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 23 Aug 2017 09:45:06 +0200 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code place. Signed-off-by: Markus Elfring --- sound/core/timer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/core/timer.c b/sound/core/timer.c index 6d73a63f6e2b..6cdd04a45962 100644 --- a/sound/core/timer.c +++ b/sound/core/timer.c @@ -395,5 +395,6 @@ unsigned long snd_timer_resolution(struct snd_timer_instance *timeri) return 0; - if ((timer = timeri->timer) != NULL) { + timer = timeri->timer; + if (timer) { if (timer->hw.c_resolution) return timer->hw.c_resolution(timer); return timer->hw.resolution; -- 2.14.0