From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f180.google.com (mail-il1-f180.google.com [209.85.166.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 361612C2593 for ; Wed, 30 Apr 2025 21:25:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746048353; cv=none; b=dJ2ia8lOYi5LuVDk6JAFQWLtkvKYIjXijE0oheDCDJVqXbJjROIUaxMv2jvGQ81Coj8Z9C94gk0qXgi9RyuTwIIl9UrKH6s8GulyA72dPwlJTFzm05xm/Cq7kvPo5mHaO8cOh3u1WfAgTgWYl/CGqexDvmjNuCa/GynQfR0MPXE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746048353; c=relaxed/simple; bh=m0DL8qKn2HJPRt/zk/ogv7PAipQf0Rr3c/trxICPpew=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TsecBd6VL1boJI5YTFCjXH0dCH4GhEH5Q+Zmhm1r4T+YOPyXCRKlGwnGeNESuqsHfxC4faPmbKsslE+ntBjOlZ4V03Bzqor03FgPDq4tcNgAnn4JwlTYUqUvvMWelJkpH34gSbSf2NAKBv6l47aM99JSKLNAudBmXbrM4JsEowY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=F6f0SRn/; arc=none smtp.client-ip=209.85.166.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="F6f0SRn/" Received: by mail-il1-f180.google.com with SMTP id e9e14a558f8ab-3d8dcc7cd17so5172795ab.1 for ; Wed, 30 Apr 2025 14:25:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1746048350; x=1746653150; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QYRbN+u1XnrHIXA+Wt481EGYDyTsWUWpekmgQbhJw38=; b=F6f0SRn/F5Gnnw9z4U5LCTAmUQ66JNVPtP63Kbb0U4/EtkMbiOBAKdg42MWEvHSePn xwBqZ01auSveBWaYOyCJ56466URw04H0YjGUK1Qaak18Cn47q4cnCCfXnCSOoTbHOu/v m+dXykKkhyHu4pN5MFpCETaUjFOLUoCbHg5fQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746048350; x=1746653150; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QYRbN+u1XnrHIXA+Wt481EGYDyTsWUWpekmgQbhJw38=; b=j85Lkc6miN3ju02J7gpXn+f/FcHNFnfsrcDKgOMfkoc3/EWzkanc4Lwsfga20H3LSX Xwlxjlky/wYftTaMCO+3wR9a7jZoC2DL9eJ4FzI91LNx6wu1EHZzczN1MpGFTeAl6N3l I0eMlDlqiOnGBwofy92TEHmiJ1q958/MIErUU3QmplEHLbGBzW+xP3qoSOJZKK8GgYeW 5YXlFxPmbu7vHHFoP0DSVazZSjHjgnrdHXb4oJpPvfCMqGBcBr/cs3cWvSwcutKo5HG3 oUrHLU7t2481cRxVlvcDKnuhMmnEnsi5zfQNA2lw38DlkQgbrtEOUUevVlXADQuYvZ1V 6MZg== X-Forwarded-Encrypted: i=1; AJvYcCXkMFx/lD0wAFTApiGYIv/DqIxOBQa9py35gRP4bQ2fdALvkvgGIqxNII/9v67T2sIRqTs2f5kVg0xKRT4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw037q/5VQ7xeDA6en2JddVdypDY0gVuGls3YNbuA5P4ySrcNPW akKsHB6Q8EEEzRTmejivreGaCj6EDMZqx5Elr/sXJ1hZ8fYayjqSjiA8PXEUx24= X-Gm-Gg: ASbGncv6RC+iSt7tc09WVFWpk3ZwK15ZUl7dpgJDJx+q9S/kx+BgNTBVq7th/ZQytV3 6G0RN6BCR+oVl5Q1SI+gQJuBKIFK615ehWOu+nGJvXU2P+2FEZFaY0fUj2rHNlwscr/rsPZE5FZ v/uCVk3XNw6Ky0GXdCl6SG505bKPBGbXNJvyiKyv9nlPUPj7pvlqKt2oJ1R1Uacf81lkR+WNqhD IQDNA4ZG00lj2UcX5DF/DOumMB7gFRRxm6OkGDiIdqLum0cneiEhVqn3ldSnbS5eg2O/q6GcIZl 7aKgky59O0BS/ewSii7p39d8M6NU6oi6GSpNkKzCAMNAAwn1RXQ= X-Google-Smtp-Source: AGHT+IEiiHKVJFhUXHUB3t68KuJgUDxukeIkKP8WUSh1zX997FZQjk44Ybevewxli9cGlS3ksir7lw== X-Received: by 2002:a05:6e02:3a08:b0:3d6:cb49:1e5f with SMTP id e9e14a558f8ab-3d970a6e9abmr606365ab.2.1746048350065; Wed, 30 Apr 2025 14:25:50 -0700 (PDT) Received: from [192.168.1.14] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4f862e831a2sm921932173.40.2025.04.30.14.25.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Apr 2025 14:25:49 -0700 (PDT) Message-ID: <4d1acc28-3645-461a-97e3-316563f468e0@linuxfoundation.org> Date: Wed, 30 Apr 2025 15:25:48 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] kunit: add tips to clean source tree to build help message To: David Gow Cc: brendan.higgins@linux.dev, rmoar@google.com, corbet@lwn.net, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/29/25 21:54, David Gow wrote: > On Wed, 30 Apr 2025 at 06:27, Shuah Khan wrote: >> >> Add tips to clean source tree to build help message. When user run >> kunit.py after building another kernel for ARCH=foo, it is necessary >> to run 'make ARCH=foo mrproper' to remove all build artifacts generated >> during the build. In such cases, kunit build could fail. >> >> Signed-off-by: Shuah Khan >> --- > > Thanks for doing this. > > This looks good to me, save for the issue below. > > I do wonder whether there's a more general fix we can do in the > makefiles, but I'm not sure how that'd have to work. Maybe by storing > the architecture used somewhere and amending the error based on that, > or hacking around the specific x86_64/UML incompatibilities. But let's > go ahead with this fix regardless. I agree the right fix is to see if kunit.py can suggest the right arch to clean. I will take a look at that. As you said, it is good to have this documented in this series. > > Cheers, > -- David > >> tools/testing/kunit/kunit.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/kunit/kunit.py b/tools/testing/kunit/kunit.py >> index 7f9ae55fd6d5..db86a396ed33 100755 >> --- a/tools/testing/kunit/kunit.py >> +++ b/tools/testing/kunit/kunit.py >> @@ -583,7 +583,7 @@ def main(argv: Sequence[str]) -> None: >> 'the options in .kunitconfig') >> add_common_opts(config_parser) >> >> - build_parser = subparser.add_parser('build', help='Builds a kernel with KUnit tests') >> + build_parser = subparser.add_parser('build', help='Builds a kernel with KUnit tests. Successful build depends on a clean source tree. Run mrproper to clean generated artifcats for prior ARCH=foo kernel build. Run 'make ARCH=foo mrproper') > > Because this string is enclosed by single quotes, the 'make ARCH=foo > mrproper' is not part of the string (and there's a missing terminating > quote as well). > > Maybe change help= to use double quotes, and add the missing one? Or > use double quotes or backticks for the make example? > > >> add_common_opts(build_parser) >> add_build_opts(build_parser) Thanks for the pointers. I will go look at those to make this help message coded better, thanks, -- Shuah