mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Forest Bond <forest@alittletooquiet.net>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: vt6655: Rename byOrgValue to reg_value in a macro
Date: Wed, 27 Jul 2022 17:54:04 +0200	[thread overview]
Message-ID: <4d1e2294-a3b7-972b-f021-cecee8779f1b@gmail.com> (raw)
In-Reply-To: <YuDfjwHJN6n/CZ4i@kroah.com>

On 7/27/22 08:47, Greg Kroah-Hartman wrote:
> On Wed, Jul 20, 2022 at 06:24:32PM +0200, Philipp Hortmann wrote:
>> Fix name of a variable in a macro that uses CamelCase which is not
>> accepted by checkpatch.pl
> 
> Why rename something you are about to delete in a later patch?
> 
> thanks,
> 
> greg k-h

I need to rename this variable. Does it matter if I do it in first or 
last patch? When doing it first I do not have to review so much 
checkpatch warnings.

Or is it OK to convert the macro to a function and rename the variable 
in one patch?

thanks,

Philipp


  reply	other threads:[~2022-07-27 15:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20 16:24 [PATCH 0/3] staging: vt6655: Convert multiline macro to static function Philipp Hortmann
2022-07-20 16:24 ` [PATCH 1/3] staging: vt6655: Rename byOrgValue to reg_value in a macro Philipp Hortmann
2022-07-27  6:47   ` Greg Kroah-Hartman
2022-07-27 15:54     ` Philipp Hortmann [this message]
2022-07-27 16:06       ` Greg Kroah-Hartman
2022-07-20 16:24 ` [PATCH 2/3] staging: vt6655: Rename MACvClearStckDS Philipp Hortmann
2022-07-27  6:48   ` Greg Kroah-Hartman
2022-07-20 16:24 ` [PATCH 3/3] staging: vt6655: Convert macro vt6655_mac_clear_stck_ds to function Philipp Hortmann
2022-07-27  6:47   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d1e2294-a3b7-972b-f021-cecee8779f1b@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=forest@alittletooquiet.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®