From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71ACA36920D for ; Thu, 2 Apr 2026 12:59:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775134752; cv=none; b=hbs0Pfp40zt2lC3mdSG/n/WzSyqRyuictrOZb8a9inLVSJ8V05ubdFCR/yv4DZqtbB7H3ZIZAQqQBvVDH2OPO26WhnjaSuPWuGqOK+SFmyO2oWohYqcugsOg9rL1vJQx80EMMHAGIWCKMF8u2Bo9CjXWR2RizHpibre5V81rQHw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775134752; c=relaxed/simple; bh=gQ7zm2N8jthO9W0DV52rud0Kv9ZG9/U5bZzlkqRVTrc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZxYZRPOVoo5d4Cwn07CCd3Wo2vFaZkB0elZaFDZoXGiLVJdJjg53rirBH95dxnbEUhOpv7RMlCQVmu7AkAUBAkDfGq9Ob3M9f4t3aRRAde40DtM+u7VPUL2Wzc5zTtlo3lnwxAr20Fxj7opU0wNc/7CpHOgoUL/p+WYakxu2IuM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=AZmesciH; arc=none smtp.client-ip=209.85.160.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="AZmesciH" Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-40438e0cba6so560096fac.1 for ; Thu, 02 Apr 2026 05:59:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1775134745; x=1775739545; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ItWcLERel9KAHwoTJhUOFlhjT7RcxBos0H/0Y7sPm1o=; b=AZmesciHkmU6hq3iwsmM9h6XOFmwe89TZKwxBv2yxon7e+XeibQ34GL5ABbbSwup6K m6EOWDhM6rtfYgC+pXCy1pngS511QKENf06Z0F0ryna1lrz/Q9/XfsuFsu0hBhTMC4tZ r0Cv/o7C6ElmpjMnYyYNGNSj9sMiXsOavhZ6BJFOFwE1XonjzTSMhp9dK7U7AG8rfjH1 mWAbntV9swVpv1uWWHhLZC46J1kHPmkGsJupEErnZQq2Ia8Of24P76SNMPXxv6vj1sYe PwUBjbrJTWE9HGsIcMJiJcBOBi396e9VgwX3uXcoeXhfrtM/YbH87TIAS6EF4PHLJ8jB gpFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775134745; x=1775739545; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ItWcLERel9KAHwoTJhUOFlhjT7RcxBos0H/0Y7sPm1o=; b=JvX43ukZas6j2Qe493eWS8+9+NvmTx2VF80MDvcEJMqUFTWdYr5JEX0abKFr+T18eg pzyiZQznpomVLvt7ktkMU8qvFv2rKfo+3TB57vFtiRB9HgeBrJMqSdda13mdhQjfvrTW ORdXFW1vqc+7/R564fAgg+iYHD6fnRI7zbPV/FbxoRwz6Va8KU7HGBKWXggx5e4Y41uK 0cANUsQ4QbwWFe8IfRB2ZRjfvA/dJxPsWFFPJwVaaBdK+Y+HtsYs44LKUDCASY7W/Kcy 5mrR33xH4HUztZlHvFcuUCvrflSWnBehRpZmGVfgMj645vr40Fmei9hb0XPlKFPQrqcK +nvg== X-Gm-Message-State: AOJu0YzSaXYGys9UvunZOFUefLhkbaSjq9nBHOySK05xUdpSJZspUkfL aHwkOXEBSc9jQ8qzmUkMNaTpFqkIJWlQF/e7qURijzKMyP+ZVIn9+PWz9R86QoiI+2zbZhx0tyT qPbhd X-Gm-Gg: ATEYQzy0zC7BgxuxaU+7NPRpttYKadtIrA6OEFIIJ+DuIlILsqeEu5vlq+p+/i4hDi5 HdnT9Kf/2UJ/cySp3nP5dEY5VNdeDmzjcnw+76Lzn0TvHXdV/XSGSv5Ag04JIiEF1YGA+zirDQv YKw8IPs8iMTm/SDWDaL2Gn6AwdAB90n7x57x0tP5gFq9R8VLR28Qlp5T/mLAy/cSpAzzyaccBO9 7C1fBsDns27/7Uv41p3rlu3C7cBT0DeqlSUEzikw8ptJNiZmPN8eNrRIuirdEJzdNAvcSQxvxr5 MKGsHC/NWAdyF4FhRQEYP3fV3lIie6ne8/WSD9nzNQUfjiHuwGOu07jdmgSkBeJewnYHx4x+0Mz UhCkf753OC+9Lisia0lOev584Df9M8Cdz4YbEZ29t4/8GajLJ7iLuofEGOgt2DX0i0cGERxBqMe L8fjFg18KPmPeFEjEN0o5QpHew2nD1ue9WzHl7zDoRLeMCFQlyT6zvOoQ5mKRMKcfDSTjHuQSaW tDJlluIoa1fBCRxQfy1 X-Received: by 2002:a05:6871:3299:b0:41c:ccd1:78b4 with SMTP id 586e51a60fabf-422cfbeb5e6mr4576093fac.10.1775134745214; Thu, 02 Apr 2026 05:59:05 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-422eb25c447sm2233192fac.9.2026.04.02.05.59.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Apr 2026 05:59:04 -0700 (PDT) Message-ID: <4d20cb99-a529-4cb0-9c80-441944e1aa60@kernel.dk> Date: Thu, 2 Apr 2026 06:59:03 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Fixes tags need work in the block tree To: Mark Brown Cc: linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, Pavel Begunkov References: Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/2/26 5:34 AM, Mark Brown wrote: > In commit > > 7a9ffcf2cbf88 ("io_uring/zcrx: use dma_len for chunk size calculation") > > Fixes tag > > Fixes: 8c0cab0b7bf76 ("always dma map in advance") > > has these problem(s): > > - Subject does not match target commit subject > Just use > git log -1 --format='Fixes: %h ("%s")' Fixed this and the other one. Pavel, JFYI. What I usually say is add: [pretty] fixes = Fixes: %h (\"%s\") [alias] fixes = log -1 --format=fixes to your ~/.gitconfig so you can just run: $ git fixes 8c0cab0b7bf768594e8efc73f7b8f3d5abeb74f1 Fixes: 8c0cab0b7bf7 ("io_uring/zcrx: always dma map in advance") and it does the right thing for you. Nobody remembers that full git log line, and then people try and do it manually, and invariably mess up the formatting. git fixes is the way. -- Jens Axboe