From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Gabor Juhos <j4g8y7@gmail.com>, Mark Brown <broonie@kernel.org>,
Varadarajan Narayanan <quic_varada@quicinc.com>,
Sricharan Ramabadhran <quic_srichara@quicinc.com>,
Md Sadre Alam <quic_mdalam@quicinc.com>
Cc: linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] spi: spi-qpic-snand: fix calculating of ECC OOB regions' properties
Date: Thu, 7 Aug 2025 13:30:34 +0200 [thread overview]
Message-ID: <4d2140ee-f757-425c-8014-3909873e7de3@oss.qualcomm.com> (raw)
In-Reply-To: <20250805-qpic-snand-oob-ecc-fix-v2-1-e6f811c70d6f@gmail.com>
On 8/5/25 6:05 PM, Gabor Juhos wrote:
> The OOB layout used by the driver has two distinct regions which contains
> hardware specific ECC data, yet the qcom_spi_ooblayout_ecc() function sets
> the same offset and length values for both regions which is clearly wrong.
>
> Change the code to calculate the correct values for both regions.
>
> For reference, the following table shows the computed offset and length
> values for various OOB size/ECC strength configurations:
>
> +-----------------+-----------------+
> |before the change| after the change|
> +-------+----------+--------+--------+--------+--------+--------+
> | OOB | ECC | region | region | region | region | region |
> | size | strength | index | offset | length | offset | length |
> +-------+----------+--------+--------+--------+--------+--------+
> | 128 | 8 | 0 | 113 | 15 | 0 | 49 |
> | | | 1 | 113 | 15 | 65 | 63 |
> +-------+----------+--------+--------+--------+--------+--------+
> | 128 | 4 | 0 | 117 | 11 | 0 | 37 |
> | | | 1 | 117 | 11 | 53 | 75 |
> +-------+----------+--------+--------+--------+--------+--------+
> | 64 | 4 | 0 | 53 | 11 | 0 | 37 |
> | | | 1 | 53 | 11 | 53 | 11 |
> +-------+----------+--------+--------+--------+--------+--------+
>
> Fixes: 7304d1909080 ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface")
> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2025-08-07 11:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 16:05 Gabor Juhos
2025-08-07 11:30 ` Konrad Dybcio [this message]
2025-08-07 19:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d2140ee-f757-425c-8014-3909873e7de3@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=j4g8y7@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=quic_mdalam@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®