From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FA5225D213 for ; Wed, 25 Jun 2025 11:51:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750852282; cv=none; b=Uw6ZiFuq7yDWoDXb//EqpsP6mngkIw9aFVoQWv9wNmZdld1KQZBAcKJcni7QuQdHzLer4Drh3gM5OTGurE7WRX4JzDf4vz3bvcE+m8AkRqm+yeJkqwm6fxrOCHCKPLxUkULkfxBoDqzXGBBsYc6VDkIVT+kmc1b1TZqKCYhzepg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750852282; c=relaxed/simple; bh=fs7c8Qyu5BrfvUyh4WP843ByKBeqVCKxGmA3+fES+jE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j0Gte3oewKolRnnC687wp+/URJXU3SjoIRQ2sW17nTAnIwaBsxSWUXxYziM8KFmMXmnnibFEDRk/LYIAMMcsPBPz0S6QogHa6u2lhBMLNUsSncYRIVmzrHVPypyoUO/ELlRdXAVy3FcEDOlzQxTPwQB6TbZJGg5efRr6EaEu8m0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ej0LtvTJ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ej0LtvTJ" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55P5tNKl021903 for ; Wed, 25 Jun 2025 11:51:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uRfQCMJPJ6I6xt/lsb5RiX86zBh0KuNZA9Flm5VJRyQ=; b=Ej0LtvTJLh+M6FeV IpxDKqLh59EosLSa0ArOiC/IdoB5oFywQQSaMN9UOAu+528/6cOO+3HkHRWcx+eZ 0jT0JNFfqT3nwlmkII6vBB25GITh5GOGzuM/WCmOwHtibkfQ2fVELQC/mlsWdLN9 wkBi8SHN6I7tMUPFT/FScHUJp0NCJqQ7qTiekP6jqlq63IzQjIV9kP6letvWDmdR 03MPl4ft6GCNb+F+ofB1DWHx9fJ2fyE9zKg5OHpljk7vS5DqcgRGwaT+DEQJIW8x iFwpIiDYVIlIugDWxa5VqsufcYATT7Df8Wp/sDHjUzJEk8M0JQcmvwvVk5ls0vhZ qOVP4g== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47f3bgfruy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 25 Jun 2025 11:51:20 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7d0976a24ceso203646385a.2 for ; Wed, 25 Jun 2025 04:51:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750852279; x=1751457079; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uRfQCMJPJ6I6xt/lsb5RiX86zBh0KuNZA9Flm5VJRyQ=; b=MZgqr455GKz11eH8U+j7UZsfd8/uGQY5zO/JAI/cBocVGA3pzwFmaN4xsp/YjeT+1m adpIH7nfPM5As9iju+USeZiwJ/ksmLIr2bcapu1DCZ9bQxTnKxTSFhPjOSNzC9ZSYW1+ ePvuo1g0KWwnrMJbA/ECS7foB1jQITvRZOId2HTMLqJpMB9grS6iTf6lJKefsQoWdZaF Z/oCSiD2pp/aXxxhd4UJHVHf1TidxqMVUkg89ORzMnJHPStZJSS2cLTsfCvc6WqDXziQ 5HzmkCScgVFawxNF+3zE5rRmRgjOLaMRN0QBnDKd2bKI3sFkDMIugBqtv8ZQJ5c24V+v KAxQ== X-Forwarded-Encrypted: i=1; AJvYcCXLkeDGf13vKxSHsmPzdPEAkmVPg9NIE6FDSAo2vPl5fa/YalPiIMRnPIEdVglV8Z6hUFE3Fm6c6/47KhE=@vger.kernel.org X-Gm-Message-State: AOJu0YxB2rn59dyfDyfIbwZc6htmIsTj9HM+plEiak6yaxtAaR8UpwN+ vKkTPddMz2lV9WUfTATkO63Kd3fA9SWTMDmRoFKu34Nrd5IDtGcnHIWNj29iz5GM6SltJLfZP1O L6xQmIO4R9vCleLrDPpk7obH4+/J2yBooohKXGgXxu6IDR1V8a7Qc5lv6z796Dw6a91M= X-Gm-Gg: ASbGncujrmTmF5BLI1rQ7OG/KJDzh4CqgAPWKmUzTPVV9Si2bppLf4HzOg8eMtRagK4 btxq+QszBhdKH9g1mjXYguUzp8OTxSkMwJ65yge1ONoUXQxUE5j/xzQYkxhEiKwzIcApASF98WC seEDEgEY+AXO1hXQ+KsOF096C6ytGZqp9UB6rd5iEQ5Fe7onlv9wo0oBs7APu+99bATDUrwLNr0 Fg38wSflIRQLMStrOXrM+cqPY8tBZMUSPUZdeTYBJqoXbh3w18No1RPuJsVjEXnI85QJxw/hwwq JyCy62gQRUb1XLb9G3qrEDSaMdTKyIjYmtiuiwCQP+TzmBJhgX2YVpNG1kOc7N3f80XQork+LbB XUaU= X-Received: by 2002:a05:620a:4802:b0:7c5:8f36:fbeb with SMTP id af79cd13be357-7d42973e679mr128604185a.12.1750852279224; Wed, 25 Jun 2025 04:51:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHccfvELeUXoP8b1jBpiU9AZeQNg48frmRiDDZy9qYIkV5bzxU9h6vBSLu6n9Ur83kyw9tsMQ== X-Received: by 2002:a05:620a:4802:b0:7c5:8f36:fbeb with SMTP id af79cd13be357-7d42973e679mr128601585a.12.1750852278731; Wed, 25 Jun 2025 04:51:18 -0700 (PDT) Received: from [192.168.143.225] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-60c2f485d0asm2360299a12.64.2025.06.25.04.51.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jun 2025 04:51:18 -0700 (PDT) Message-ID: <4d215791-35da-4139-9cc8-33da5d46469e@oss.qualcomm.com> Date: Wed, 25 Jun 2025 13:51:15 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] phy: qcom: phy-qcom-snps-eusb2: Add missing write from init sequence To: Luca Weiss , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Vinod Koul , Kishon Vijay Abraham I , Abel Vesa Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org References: <20250625-sm7635-eusb-phy-v1-0-94d76e0667c1@fairphone.com> <20250625-sm7635-eusb-phy-v1-3-94d76e0667c1@fairphone.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250625-sm7635-eusb-phy-v1-3-94d76e0667c1@fairphone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: jPWVF7XpSxaQDD9HzL-FzRplBEgS2lJM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI1MDA4OCBTYWx0ZWRfX2R5lwfxDI8BY REqSv4IjAbc4WBIImvICzIpEY5F/dChd+GWp1D3B/AP0viBOOOThYacBMGiUli41T0zQBvdwOJs Ci71zXsTrq0xnmcQ6895XDh4If4QpKj9O/psvn75pAwYgFLPLDDr6m76+bljU9G9hOQe6JhFmoY 4itquA578KlOUGNbRLikhtz1ZzKlLSFRqIYWzGrv96TL+GoWTGA6beZrqQOaDbk0tEwT2c3AwgX gsA3psyj5Aw+HDJDDvjQ6kvEtrXjuMuRTJYfEe2y7wcXugkIQxmpU2po0xRsV/c/oe7g/9nI1cB TqcBM1IuRMEVyLZMUU6JC1nd07tZGvQeK1+lnhqsjNRk8VOjyjmi2FqUubygN6iRsEzk6v+wQG2 SSYpPhZm5DDHmqFXvJHRzd7l2ml4lMtD8SwwYMSIzRHJ+wrfD2VyVA6v0WhqtlyYAy3fWirK X-Authority-Analysis: v=2.4 cv=L4kdQ/T8 c=1 sm=1 tr=0 ts=685be2b8 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=qC_FGOx9AAAA:8 a=6H0WHjuAAAAA:8 a=EUspDBNiAAAA:8 a=SHKt8ETI8ElOVTnc0VsA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=fsdK_YakeE02zTmptMdW:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-GUID: jPWVF7XpSxaQDD9HzL-FzRplBEgS2lJM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-25_03,2025-06-25_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 bulkscore=0 clxscore=1015 suspectscore=0 adultscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506250088 On 6/25/25 11:14 AM, Luca Weiss wrote: > As per a commit from Qualcomm's downstream 6.1 kernel[0], the init > sequence is missing writing 0x00 to USB_PHY_CFG0 at the end, as per the > 'latest' HPG revision (as of November 2023). > > [0] https://git.codelinaro.org/clo/la/kernel/qcom/-/commit/b77774a89e3fda3246e09dd39e16e2ab43cd1329 > > Signed-off-by: Luca Weiss > --- Both the original and your commit messages are slightly misleading, the HPG (and the code which is indeed in sync with it after the change is made) only sets the value of 0 to BIT(1), a.k.a. CMN_CTRL_OVERRIDE_EN. You most definitely don't want to set the entire register to 0. With that fixed: Fixes: 80090810f5d3 ("phy: qcom: Add QCOM SNPS eUSB2 driver") Reviewed-by: Konrad Dybcio Konrad