From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B2731BD9DB; Wed, 30 Oct 2024 19:04:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730315070; cv=none; b=GjIfkax/nYXcRdNti9YzIw9Av8YfJbKArn54U134cyQtz2FJzxDJJM0qGTlgdNNoveNOZDjGwhqp3h6oMSxM+YWEMgmGjxZ/MjjWyRioGWYzPFwfhXDI37ZYJ9nbWJH8n8gBl9Ymd4to2aRcVQhatWbs/WKhYLHL5qlCFd0lS5Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730315070; c=relaxed/simple; bh=nPW3eOpnP2bgPLLpIpBZgsEARxTtQVQLzV+Dtvq6kjo=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=Yh+5wlztgjRhR5rB0VFsRtGJZ8PM5ubGDShAfKrcdKBmMpkHTZDN6FgWdQL98PpkzePnxjHuZk2TtALYTE4bwQ6zo9VjGBwPiyfWwIeIsp/8DOUWeTQ5ZOugpq2NWqWJcUKVJ4iYKhSvY9O0niiTpQS1m4Q9+LuxNZXhdHBTnec= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=A+qe6+Xu; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="A+qe6+Xu" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49UE2BLT027381; Wed, 30 Oct 2024 19:04:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CiP61866JdksHemSG4W1R2zZYCtRBxqCUfJzk9a3aXs=; b=A+qe6+XuAovINi+s Vpcafo0r7BREZMsBjsqaelFBMheRtV83fRSueEgFpbpIrE2vF5AtoYTphM0CZZQb ZsSXxlr0MRoLSYN/6Uoz8ew4wAIdc8DX+B+ZxWfvP+1c4vLLsHi/bNkU0Lp1+LF5 3ywvUw8/1lk2ZfYThWl/Omv32YAZoomwJUpv+3BiDtkjgFJ81mYyqRMasW0EmN52 1jrotsspHT9ANAEzx2/hMlEs5Fbae7dIl4iYKGQz0u0wExm9Xp1WQTe5L6TXKAjQ FvYgM9HUfVXiOBtLCMppG6fdjl4RjZObs8JqCS6QFjSIgzFIAFce1MJ4qAiVKdTC 8Q844Q== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42k1p34cs1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Oct 2024 19:04:20 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 49UJ4Jvc003289 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Oct 2024 19:04:19 GMT Received: from [10.48.242.156] (10.49.16.6) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 30 Oct 2024 12:04:18 -0700 Message-ID: <4d273cac-8955-4850-bd8a-0bad318c1e4f@quicinc.com> Date: Wed, 30 Oct 2024 12:04:17 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 1/5] dt-bindings: net: wireless: ath12k: describe WSI properties for QCN9274 To: Raj Kumar Bhagat , CC: , Kalle Valo , "Rob Herring" , Krzysztof Kozlowski , "Conor Dooley" , Jeff Johnson , "Bjorn Andersson" , Konrad Dybcio , , , References: <20241029173050.2188150-1-quic_rajkbhag@quicinc.com> <20241029173050.2188150-2-quic_rajkbhag@quicinc.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20241029173050.2188150-2-quic_rajkbhag@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: rYxZO48zMyEqS7vgGKVI_E1F5oTWUVcd X-Proofpoint-ORIG-GUID: rYxZO48zMyEqS7vgGKVI_E1F5oTWUVcd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 spamscore=0 lowpriorityscore=0 mlxscore=0 malwarescore=0 phishscore=0 clxscore=1015 impostorscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410300150 On 10/29/2024 10:30 AM, Raj Kumar Bhagat wrote: > QCN9274 device has WSI support. WSI stands for WLAN Serial Interface. > It is used for the exchange of specific control information across > radios based on the doorbell mechanism. This WSI connection is > essential to exchange control information among these devices > > Hence, describe WSI interface supported in QCN9274 with the following > properties: > > - qcom,wsi-group-id: It represents the identifier assigned to the WSI > connection. All the ath12k devices connected to same WSI connection > have the same wsi-group-id. > > - qcom,wsi-master: Indicates if this device is the WSI master. > > - ports: This is a graph ports schema that has two ports: TX (port@0) > and RX (port@1). This represents the actual WSI connection among > multiple devices. > > Also, describe the ath12k device property > "qcom,ath12k-calibration-variant". This is a common property among > ath12k devices. > > Signed-off-by: Raj Kumar Bhagat > --- > .../bindings/net/wireless/qcom,ath12k.yaml | 241 +++++++++++++++++- > 1 file changed, 232 insertions(+), 9 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml > index 1b5884015b15..42bcd73dd159 100644 > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > # Copyright (c) 2024 Linaro Limited > +# Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved. > %YAML 1.2 > --- > $id: http://devicetree.org/schemas/net/wireless/qcom,ath12k.yaml# > @@ -18,10 +19,17 @@ properties: > compatible: > enum: > - pci17cb,1107 # WCN7850 > + - pci17cb,1109 # QCN9274 > > reg: > maxItems: 1 > > + qcom,ath12k-calibration-variant: > + $ref: /schemas/types.yaml#/definitions/string > + description: | > + string to uniquely identify variant of the calibration data for designs > + with colliding bus and device ids > + > vddaon-supply: > description: VDD_AON supply regulator handle > > @@ -49,21 +57,100 @@ properties: > vddpcie1p8-supply: > description: VDD_PCIE_1P8 supply regulator handle > > + wsi: > + type: object > + description: | > + The ath12k devices (QCN9274) feature WSI support. WSI stands for > + WLAN Serial Interface. It is used for the exchange of specific > + control information across radios based on the doorbell mechanism. > + This WSI connection is essential to exchange control information > + among these devices. > + > + Diagram to represent one WSI connection (one WSI group) among > + three devices. > + > + +-------+ +-------+ +-------+ > + | pcie2 | | pcie3 | | pcie1 | is there a reason to not have these in some order? > + | | | | | | > + +----->| wsi |------->| wsi |------->| wsi |-----+ > + | | grp 0 | | grp 0 | | grp 2 | | s/grp 2/grp 0/??? ^ typo? > + | +-------+ +-------+ +-------+ | > + +------------------------------------------------------+ > + > + Diagram to represent two WSI connections (two separate WSI groups) > + among four devices. > + > + +-------+ +-------+ +-------+ +-------+ > + | pcie2 | | pcie3 | | pcie1 | | pcie0 | again seems strange to not have any logical (to me) order > + | | | | | | | | > + +-->| wsi |--->| wsi |--+ +-->| wsi |--->| wsi |--+ > + | | grp 0 | | grp 0 | | | | grp 1 | | grp 1 | | > + | +-------+ +-------+ | | +-------+ +-------+ | > + +---------------------------+ +---------------------------+ > + > + properties: > + qcom,wsi-group-id: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + It represents the identifier assigned to the WSI connection. All > + the ath12k devices connected to same WSI connection have the > + same wsi-group-id. > + > + qcom,wsi-master: > + type: boolean > + description: > + Indicates if this device is the WSI master. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + description: > + These ports are used to connect multiple WSI supported devices to > + form the WSI group. > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + This is the TX port of WSI interface. It is attached to the RX > + port of the next device in the WSI connection. > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + This is the RX port of WSI interface. It is attached to the TX > + port of the previous device in the WSI connection. > + > + required: > + - qcom,wsi-group-id > + - ports > + > + additionalProperties: false > + > required: > - compatible > - reg > - - vddaon-supply > - - vddwlcx-supply > - - vddwlmx-supply > - - vddrfacmn-supply > - - vddrfa0p8-supply > - - vddrfa1p2-supply > - - vddrfa1p8-supply > - - vddpcie0p9-supply > - - vddpcie1p8-supply > > additionalProperties: false > > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - pci17cb,1107 > + then: > + required: > + - vddaon-supply > + - vddwlcx-supply > + - vddwlmx-supply > + - vddrfacmn-supply > + - vddrfa0p8-supply > + - vddrfa1p2-supply > + - vddrfa1p8-supply > + - vddpcie0p9-supply > + - vddpcie1p8-supply > + > examples: > - | > #include > @@ -97,3 +184,139 @@ examples: > }; > }; > }; > + > + - | in the description above you have two different diagrams: - one that shows 3 pcie* devices in a single group with apparently one port per device - one that shows 4 pcie* devices split into two groups of two, again with apparently one port per device but in the representation that follows you describe three pcie* devices, each with two distinct ports, all 6 of which are part of group 0. can we have diagrams that match the actual bindings. does the real product actually have 6 ports in one group? > + pcie1 { > + #address-cells = <3>; > + #size-cells = <2>; > + > + pcie@0 { > + device_type = "pci"; > + reg = <0x0 0x0 0x0 0x0 0x0>; > + #address-cells = <3>; > + #size-cells = <2>; > + ranges; > + > + wifi1@0 { > + compatible = "pci17cb,1109"; > + reg = <0x0 0x0 0x0 0x0 0x0>; > + > + qcom,ath12k-calibration-variant = "RDP433_1"; > + > + wsi { > + qcom,wsi-group-id = <0>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + wifi1_wsi_tx: endpoint { > + remote-endpoint = <&wifi2_wsi_rx>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + wifi1_wsi_rx: endpoint { > + remote-endpoint = <&wifi3_wsi_tx>; > + }; > + }; > + }; > + }; > + }; > + }; > + }; > + > + pcie2 { > + #address-cells = <3>; > + #size-cells = <2>; > + > + pcie@0 { > + device_type = "pci"; > + reg = <0x0 0x0 0x0 0x0 0x0>; > + #address-cells = <3>; > + #size-cells = <2>; > + ranges; > + > + wifi2@0 { > + compatible = "pci17cb,1109"; > + reg = <0x0 0x0 0x0 0x0 0x0>; > + > + qcom,ath12k-calibration-variant = "RDP433_2"; > + > + wsi { > + qcom,wsi-group-id = <0>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + wifi2_wsi_tx: endpoint { > + remote-endpoint = <&wifi3_wsi_rx>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + wifi2_wsi_rx: endpoint { > + remote-endpoint = <&wifi1_wsi_tx>; > + }; > + }; > + }; > + }; > + }; > + }; > + }; > + > + pcie3 { > + #address-cells = <3>; > + #size-cells = <2>; > + > + pcie@0 { > + device_type = "pci"; > + reg = <0x0 0x0 0x0 0x0 0x0>; > + #address-cells = <3>; > + #size-cells = <2>; > + ranges; > + > + wifi3@0 { > + compatible = "pci17cb,1109"; > + reg = <0x0 0x0 0x0 0x0 0x0>; > + > + qcom,ath12k-calibration-variant = "RDP433_3"; > + > + wsi { > + qcom,wsi-group-id = <0>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + wifi3_wsi_tx: endpoint { > + remote-endpoint = <&wifi1_wsi_rx>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + wifi3_wsi_rx: endpoint { > + remote-endpoint = <&wifi2_wsi_tx>; > + }; > + }; > + }; > + }; > + }; > + }; > + };