From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB48EC48BE8 for ; Fri, 18 Jun 2021 12:43:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A2494613EC for ; Fri, 18 Jun 2021 12:43:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232253AbhFRMpj (ORCPT ); Fri, 18 Jun 2021 08:45:39 -0400 Received: from foss.arm.com ([217.140.110.172]:40156 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230217AbhFRMph (ORCPT ); Fri, 18 Jun 2021 08:45:37 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 115EB1476; Fri, 18 Jun 2021 05:43:28 -0700 (PDT) Received: from [192.168.1.179] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B4E5C3F85F; Fri, 18 Jun 2021 05:43:26 -0700 (PDT) Subject: Re: [PATCH] drm/panfrost:modify 'break' to 'continue' to traverse the circulation To: ChunyouTang , robh@kernel.org, tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com, airlied@linux.ie, daniel@ffwll.ch Cc: ChunyouTang , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20210617080414.1940-1-tangchunyou@163.com> From: Steven Price Message-ID: <4d289eed-59f2-161a-40d1-2a434a1955c2@arm.com> Date: Fri, 18 Jun 2021 13:43:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210617080414.1940-1-tangchunyou@163.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/06/2021 09:04, ChunyouTang wrote: > From: ChunyouTang > > The 'break' can cause 'Memory manager not clean during takedown' > > It cannot use break to finish the circulation,it should use > > continue to traverse the circulation.it should put every mapping > > which is not NULL. You don't appear to have answered my question about whether you've actually seen this happen (and ideally what circumstances). In my previous email[1] I explained why I don't think this is needed. You need to convince me that I've overlooked something. Thanks, Steve [1] https://lore.kernel.org/r/31644881-134a-2d6e-dddf-e658a3a8176b%40arm.com > Signed-off-by: ChunyouTang > --- > drivers/gpu/drm/panfrost/panfrost_job.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c > index 6003cfeb1322..52bccc1d2d42 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_job.c > +++ b/drivers/gpu/drm/panfrost/panfrost_job.c > @@ -281,7 +281,7 @@ static void panfrost_job_cleanup(struct kref *ref) > if (job->mappings) { > for (i = 0; i < job->bo_count; i++) { > if (!job->mappings[i]) > - break; > + continue; > > atomic_dec(&job->mappings[i]->obj->gpu_usecount); > panfrost_gem_mapping_put(job->mappings[i]); >