From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32171C43334 for ; Mon, 18 Jul 2022 15:29:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235550AbiGRP3R (ORCPT ); Mon, 18 Jul 2022 11:29:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235630AbiGRP3O (ORCPT ); Mon, 18 Jul 2022 11:29:14 -0400 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04E17BA9; Mon, 18 Jul 2022 08:29:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658158155; x=1689694155; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=yH2iAt7Nak/S2cxw66iqqC0mytMna35OO1GjNSnHyFo=; b=Iq0O5rreNmIynoPU/qpnN2x9ipQ1aOY7v+5yFu3a2so0hpMXU4KzAN4X iCfMBOo1/V+XESlU6XHZ2Ji6pnQgfbllir5sbL89m7dlRgFlfMunko8kT JU7v1ME++muFOw0lIsKEaPX2A2bwozkExYcOIrokrA8NV01Vrvv+zJxOW 25IWSNTsnn8BHPADDVFzCraLIbGf359c+hLc7tnZtivvA87OZpj0m0mvr aaQBw59TSkcWAKeXCnuukiJD39czSD20mU7HjJdXicauGKIItWFD32hM6 7hvDe+dQMv/S4tt49UCs4RLJz0zrrsAYlWPLyeU2GTmLWStbgjX4lUDcL g==; X-IronPort-AV: E=McAfee;i="6400,9594,10412"; a="347938874" X-IronPort-AV: E=Sophos;i="5.92,281,1650956400"; d="scan'208";a="347938874" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 08:29:15 -0700 X-IronPort-AV: E=Sophos;i="5.92,281,1650956400"; d="scan'208";a="572449344" Received: from jwconnol-mobl1.amr.corp.intel.com (HELO spandruv-desk1.amr.corp.intel.com) ([10.209.102.92]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 08:29:13 -0700 Message-ID: <4d30ed8d43d0db93c5f550bb69931f288285aa2b.camel@linux.intel.com> Subject: Re: [PATCH] tools/power/x86/intel-speed-select: Fix off by one check From: srinivas pandruvada To: Dan Carpenter Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Mon, 18 Jul 2022 08:29:13 -0700 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2022-07-18 at 16:17 +0300, Dan Carpenter wrote: > Change > MAX_DIE_PER_PACKAGE to >= MAX_DIE_PER_PACKAGE to prevent > accessing one element beyond the end of the array. > > Fixes: 7fd786dfbd2c ("tools/power/x86/intel-speed-select: OOB daemon > mode") > Signed-off-by: Dan Carpenter Thanks. I will add to PULL request. > --- >  tools/power/x86/intel-speed-select/isst-daemon.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/power/x86/intel-speed-select/isst-daemon.c > b/tools/power/x86/intel-speed-select/isst-daemon.c > index dd372924bc82..d0400c6684ba 100644 > --- a/tools/power/x86/intel-speed-select/isst-daemon.c > +++ b/tools/power/x86/intel-speed-select/isst-daemon.c > @@ -41,7 +41,7 @@ void process_level_change(int cpu) >         time_t tm; >         int ret; >   > -       if (pkg_id >= MAX_PACKAGE_COUNT || die_id > > MAX_DIE_PER_PACKAGE) { > +       if (pkg_id >= MAX_PACKAGE_COUNT || die_id >= > MAX_DIE_PER_PACKAGE) { >                 debug_printf("Invalid package/die info for cpu:%d\n", > cpu); >                 return; >         }