From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Jiri Olsa <jolsa@kernel.org>, Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Michael Petlan <mpetlan@redhat.com>,
Ian Rogers <irogers@google.com>,
Stephane Eranian <eranian@google.com>,
Andi Kleen <ak@linux.intel.com>,
Thomas Richter <tmricht@linux.ibm.com>
Subject: Re: [PATCHv2 2/2] perf tools: Fix term parsing for raw syntax
Date: Mon, 27 Jul 2020 08:21:07 +0800 [thread overview]
Message-ID: <4d30edad-8df1-ac9d-c70d-9019935c4d4c@linux.intel.com> (raw)
In-Reply-To: <20200726075244.1191481-2-jolsa@kernel.org>
On 7/26/2020 3:52 PM, Jiri Olsa wrote:
> Jin Yao reported issue with possible conflict between raw
> events and term values in pmu event syntax.
>
> Currently following syntax is resolved as raw event with
> 0xead value:
> uncore_imc_free_running/read/
>
> instead of using 'read' term from uncore_imc_free_running pmu,
> because 'read' is correct raw event syntax with 0xead value.
>
> To solve this issue we do following:
> - check existing terms during rXXXX syntax processing
> and make them priority in case of conflict
> - allow pmu/r0x1234/ syntax to be able to specify conflicting
> raw event (implemented in previous patch)
>
> Also adding automated tests for this and perf_pmu__parse_cleanup
> call to parse_events_terms, so the test gets properly cleaned up.
>
> Reported-by: Jin Yao<yao.jin@linux.intel.com>
> Signed-off-by: Jiri Olsa<jolsa@kernel.org>
> ---
> v2 changes:
> - added comment to perf_pmu__test_parse_init
Acked-by: Jin Yao <yao.jin@linux.intel.com>
Thanks
Jin Yao
next prev parent reply other threads:[~2020-07-27 0:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-26 7:52 [PATCHv2 1/2] perf tools: Allow r0x<HEX> event syntax Jiri Olsa
2020-07-26 7:52 ` [PATCHv2 2/2] perf tools: Fix term parsing for raw syntax Jiri Olsa
2020-07-26 22:00 ` Ian Rogers
2020-07-27 0:21 ` Jin, Yao [this message]
2020-07-27 0:26 ` Jin, Yao
2020-07-28 12:17 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d30edad-8df1-ac9d-c70d-9019935c4d4c@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome