mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Nuno Sá" <noname.nuno@gmail.com>
To: Denis Arefev <arefev@swemel.ru>
Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
	 linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org,
	 michael.hennerich@analog.com
Subject: Re: [PATCH 0/2] Input: adp5588-keys Please correct and add
Date: Tue, 20 May 2025 12:15:12 +0100	[thread overview]
Message-ID: <4d3e9a97e0c1f4d5a5eeaee133b5980a0a065aac.camel@gmail.com> (raw)
In-Reply-To: <20250520111301.1346035-1-arefev@swemel.ru>

On Tue, 2025-05-20 at 14:12 +0300, Denis Arefev wrote:
> > On Fri, 2025-05-16 at 16:43 +0300, Denis Arefev wrote:
> > > 1. Add check on return code
> > > 2. Prevent buffer overflow
> > > 
> > > Denis Arefev (2):
> > >   Input: adp5588-keys Add check on return code
> > >   Input: adp5588-keys Prevent buffer overflow
> > > 
> > >  drivers/input/keyboard/adp5588-keys.c | 18 ++++++++++++++----
> > >  1 file changed, 14 insertions(+), 4 deletions(-)
> > 
> > Hi,
> > 
> > Thanks for the patch. However, not sure if this is really worth it... This
> > is
> > driver is in the process of being removed:
> > 
> > https://lore.kernel.org/linux-input/04b8a6d68fdc0c0eadf69fbbc6a130ecc6c49360.camel@gmail.com/T/#mad1980e9652161a6a2e36c2aeeb97f900c6e9fc2
> > 
> > Unless we want somehow to backport these patches?
> > 
> > - Nuno Sá
> 
> Hi Nuno.
> 
> It'd be great if the fix patches are applied and then directed
> to stable kernels before the code is dropped from upstream.
> I've sent v3 with relevant stable tags included. Thanks.

Not up to me to decide that :)

- Nuno Sá

      reply	other threads:[~2025-05-20 11:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-16 13:43 Denis Arefev
2025-05-16 13:43 ` [PATCH 1/2] Input: adp5588-keys Add check on return code Denis Arefev
2025-05-16 13:43 ` [PATCH 2/2] Input: adp5588-keys Prevent buffer overflow Denis Arefev
2025-05-16 13:47 ` [PATCH 0/2] Input: adp5588-keys Please correct and add Nuno Sá
2025-05-20 11:12   ` Denis Arefev
2025-05-20 11:15     ` Nuno Sá [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d3e9a97e0c1f4d5a5eeaee133b5980a0a065aac.camel@gmail.com \
    --to=noname.nuno@gmail.com \
    --cc=arefev@swemel.ru \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=michael.hennerich@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®