From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00EE53ECBE5
	for <linux-kernel@vger.kernel.org>; Mon, 24 Aug 2026 07:13:48 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1787555630; cv=none; b=Y5HATv2+VMiKWb11KNQH99bnu/R8sKQ4NKfxN1f3BCTEoyANLG/qsooviQUzcoGT2p6elVD2CsnRxxnyXTVNoe67SUzO0hq8GcOvUNpYxrvLHkbLiXR7unNqIPRjLrHFKm9eT+Wj49XI/OwlTXo4VTfJXrVBrNV/hE3sQtO3fLw=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1787555630; c=relaxed/simple;
	bh=SrBU0v2DW4VvnNX2vB0qxhugOeJHB1sxLYL+UWGTWAI=;
	h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From:
	 In-Reply-To:Content-Type; b=FDXLr0y9KqA1e8CFqHWBxEzs0bb9XBhsNSpbcomvsGeiR43WxrjnRWRTvizD6B4eKMMA2Or1rG0mKgHVp6uivBiYBQ5qJm00T3E05/0P1g3QCZZruBSeyMGKiFBzKGC1vIzBlwy2JbT3AH6pIr9VbLREvbIhyuovqiWex3FrUbs=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=h/r0gfi0; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="h/r0gfi0"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 490031F000E9;
	Mon, 24 Aug 2026 07:13:47 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1787555628;
	bh=RNGMH3yPdmGlBz3tDmrQhbQWLMyk/Wd7O6SlC0s4+Uw=;
	h=Date:Cc:Subject:To:References:From:In-Reply-To;
	b=h/r0gfi0y5/9JLPC5u/9tvM1q0OUpwhsBnCmt10leUG62fMP1EYrBe6HFvoy8Wg0l
	 7twJFvzy5awVdUdyOdsVacbrYNZvEmDynqXbKxhhx0j/38o9UJ0xOERfbCUvQkTxFm
	 EmjGVTK5z06zl4X88NKz4rMHm4huLF6nbbwa3PC6ooxrj5MJS1z8JOPpZxbXH48FKi
	 bs3eYGoOer/z74G9wOTdOtJwqt1sFKdziMfvYzhVg9jPrIyOM466S0/BAim+DmV19n
	 xuZ6iKw0bXybKbFlm1dTeWVMUy+BWbX6RJxbJ45IKrjn3Kc6mx2ABiKP6TuQEF8v5O
	 XIDrWxAb1A+sA==
Message-ID: <4d408110-0579-4916-9e28-e3e831486980@kernel.org>
Date: Mon, 24 Aug 2026 15:13:45 +0800
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Cc: chao@kernel.org, Wenjie Qi <qiwenjie@xiaomi.com>,
 Jaegeuk Kim <jaegeuk@kernel.org>, linux-kernel@vger.kernel.org,
 linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH v1 07/12] f2fs: cache: use node cache
To: Wenjie Qi <qwjhust@gmail.com>
References: <20260820031721.12218-1-chao@kernel.org>
 <20260820031721.12218-8-chao@kernel.org>
 <20260823125908.3231362-1-qiwenjie@xiaomi.com>
Content-Language: en-US
From: Chao Yu <chao@kernel.org>
In-Reply-To: <20260823125908.3231362-1-qiwenjie@xiaomi.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 8/23/26 20:59, Wenjie Qi wrote:
> Hi Chao,
> 
>> out_err:
>> 	f2fs_clear_cache_dirty(entry);
> 
> Both the inode-checksum and footer-validation failure paths reach this label.
> `f2fs_clear_cache_dirty()` clears the DIRTY state bit, but it does not clear
> UPTODATE or synchronize the DIRTY radix tag and dirty-node counter.
> 
> What invariant keeps these states consistent after node validation fails?

Will fix.

Thanks,