From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50F71304BB6 for ; Mon, 29 Sep 2025 12:06:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759147595; cv=none; b=WbnqUHkZIh0AMxDGmZoI+un/Uus3n8HQwlOxMw1lgYcx8k6LVcEubhekw0Uz0KR/M3+tyN1mffF70BPq4k3cIA2QNPtFKuMDWIJETC+Q9vFqJ9rRDECOsF2PJtZjPdzn/A5iWyu7c4D9iGbMqkJBbFhMFX+VPCsL8+VkjRvX3fU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759147595; c=relaxed/simple; bh=XXB3FMfJmItK5mRXCGgMU9Q63R3kx61AV2pS25dHPqE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tPLTYJNfxZskE5rdpCLJDyAKCiqqIUmVRx+tbgkHi5/PQhZX/Bd7FhzlXH7bzj8TACb9PYuyVFXbIrP4ymnJKiS9RBRLMar+TFxVpoO/6XXw7uUKNpjQH/4M0Ctu7ezCOGpIlpwPbGPJ2UcxJ8tEibQ6EDeqwhFqYf/LRxt0k1o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=Pj/0eqJ/; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="Pj/0eqJ/" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Kc1aln7O6Klwy7V6249j4vaMIKKG3rs2LpAcPtA4y6Q=; b=Pj/0eqJ/2S7dT2RilNqu2UU2en gSL409zLBZqK5ReMvaYAR8ySZwvmWR5VWZ/8/DSgj1NtkZPn6thrmribxiZ08P/18vxRWoaIZ/q77 Ha4ExYs0ILQ6p6o0BKVON0PuyoNmjeD4hfL5QDEt7eZYWuAcTiANzICAcFyie6eDItCqhHPgK3fGw BgYuh+jOZcuQwpON+xR/U4bZI6UdxngBza/DHl6wahXCRtEtT0GD1BUu78fXIQdYH+q1Jbzotbs/g vdBf/aaHnONir3HjZT0adIHiQXgKfis+MMmwAtjs3cfuYQZynA7r/Kw0xwo0sxQnng7bfhjWRCqR9 1Rr59igQ==; Received: from [189.6.12.111] (helo=[192.168.0.55]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1v3CdD-001j7G-Va; Mon, 29 Sep 2025 14:05:28 +0200 Message-ID: <4d4170fc-f91a-4e15-b8a0-317b1af8324e@igalia.com> Date: Mon, 29 Sep 2025 09:05:08 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v2 00/20] Introduce support for post-blend color pipeline To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Haneen Mohammed , Melissa Wen Cc: Alex Hung , wayland-devel@lists.freedesktop.org, harry.wentland@amd.com, leo.liu@amd.com, ville.syrjala@linux.intel.com, pekka.paalanen@collabora.com, contact@emersion.fr, jadahl@redhat.com, sebastian.wick@redhat.com, shashank.sharma@amd.com, agoins@nvidia.com, joshua@froggi.es, mdaenzer@redhat.com, aleixpol@kde.org, xaver.hugl@gmail.com, victoria@system76.com, uma.shankar@intel.com, quic_naseer@quicinc.com, quic_cbraga@quicinc.com, quic_abhinavk@quicinc.com, marcan@marcan.st, Liviu.Dudau@arm.com, sashamcintosh@google.com, chaitanya.kumar.borah@intel.com, louis.chauvet@bootlin.com, mcanal@igalia.com, kernel@collabora.com, daniels@collabora.com, leandro.ribeiro@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Simona Vetter References: <20250917-mtk-post-blend-color-pipeline-v2-0-ac4471b44758@collabora.com> Content-Language: en-US From: Melissa Wen In-Reply-To: <20250917-mtk-post-blend-color-pipeline-v2-0-ac4471b44758@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 17/09/2025 21:43, Nícolas F. R. A. Prado wrote: > This series is based on "Color Pipeline API w/ VKMS" [1]. It reuses the > same concept of a color pipeline API but for the post-blend stage > instead of pre-blend, by attaching the COLOR_PIPELINE property to the > CRTC rather than a plane. Hi all, I'm confused about the timing of this series being reviewed. Hadn't we agreed in past hackfest on discussing post-blending color API only after we have sorted out pre-blending color properties? There are still open questions around color_encoding and color_range, for example... How assertive can we be evaluating the post-blending API now? Best Regards, Melissa > > The patches in the series first implement the necessary changes in the > DRM core to allow for post-blend color pipelines and expose it through > the uAPI, and then implement support in both the MediaTek KMS driver and > in VKMS. > > This series has been tested with IGT, with the "Support post-blend color > pipeline API" series [2] applied, on top of VKMS, as well as with > Weston, with a WIP branch [3], on a MT8195-Tomato Chromebook, where both > gamma LUT and CTM color transformations have been simultaneously > configured in hardware through the API and validated (test commits for > weston at [4] and for kernel at [5]). > > [1] https://lore.kernel.org/all/20250815035047.3319284-1-alex.hung@amd.com/ > [2] https://lore.kernel.org/igt-dev/20250912-post-blend-colorops-v1-0-83fc62420cba@collabora.com/T/#t > [3] https://gitlab.collabora.com/nfraprado/weston/-/tree/post-blend-colorops?ref_type=heads > [4] https://gitlab.collabora.com/nfraprado/weston/-/tree/post-blend-color-pipeline-lut-ctm-test?ref_type=tags > [5] https://gitlab.collabora.com/nfraprado/linux/-/tree/debug-ctm-lut-data-post-blend-colorop?ref_type=tags > > Signed-off-by: Nícolas F. R. A. Prado > --- > Changes in v2: > - Split core DRM changes for post-blend color pipelines from single > commit into smaller changes > - Added post-blend color pipeline support in VKMS > - Introduced driver cap, and made client cap depend on it (daniels) > - Made deprecated color props (GAMMA_LUT, DEGAMMA_LUT, CTM) available as > read-only when post-blend color pipelines are enabled (daniels) > - Created colorop_modeset_lock/unlock to commonize locking pattern for > colorops (louis.chauvet) > - Added helper for post-blend 1D curve colorop creation > - Link to v1: https://lore.kernel.org/r/20250822-mtk-post-blend-color-pipeline-v1-0-a9446d4aca82@collabora.com > > --- > Nícolas F. R. A. Prado (20): > drm/crtc: Add color pipeline to CRTC state > drm/colorop: Allow parenting colorop to CRTC > drm: Factor out common color_pipeline property initialization code > drm/crtc: Add COLOR_PIPELINE property > drm: Introduce DRM_CAP_POST_BLEND_COLOR_PIPELINE > drm: Introduce DRM_CLIENT_CAP_POST_BLEND_COLOR_PIPELINE > drm/atomic: Pass post_blend_color_pipeline client cap to atomic check > drm/atomic: Print the color pipeline as part of the CRTC state print > drm/colorop: Factor out common paths from colorops helpers > drm/colorop: Introduce colorop helpers for crtc > drm/colorop: Export drm_colorop_cleanup() so drivers can extend it > drm/crtc: Track post-blend color pipeline client cap in drm_crtc_state > drm/mediatek: Support post-blend colorops for gamma and ctm > drm/mediatek: ccorr: Support post-blend color pipeline API > drm/mediatek: gamma: Support post-blend color pipeline API > drm/mediatek: Set post-blend color pipeline driver cap > drm/vkms: Rename existing color pipeline helpers to contain "pre_blend" > drm/vkms: Prepare pre_blend_color_transform() for post-blend pipelines > drm/vkms: Introduce support for post-blend color pipeline > drm/vkms: Set post-blend color pipeline driver cap > > drivers/gpu/drm/drm_atomic.c | 9 +- > drivers/gpu/drm/drm_atomic_uapi.c | 65 +++++++- > drivers/gpu/drm/drm_colorop.c | 245 ++++++++++++++++++++++++------ > drivers/gpu/drm/drm_connector.c | 1 + > drivers/gpu/drm/drm_crtc.c | 77 ++++++++++ > drivers/gpu/drm/drm_crtc_internal.h | 6 + > drivers/gpu/drm/drm_ioctl.c | 12 ++ > drivers/gpu/drm/drm_mode_object.c | 9 ++ > drivers/gpu/drm/drm_plane.c | 36 +---- > drivers/gpu/drm/mediatek/mtk_crtc.c | 208 ++++++++++++++++++++++++- > drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 6 +- > drivers/gpu/drm/mediatek/mtk_ddp_comp.h | 2 + > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 100 ++++++++++-- > drivers/gpu/drm/mediatek/mtk_disp_drv.h | 6 +- > drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 107 ++++++++++--- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 3 +- > drivers/gpu/drm/vkms/vkms_colorop.c | 106 ++++++++++++- > drivers/gpu/drm/vkms/vkms_composer.c | 13 +- > drivers/gpu/drm/vkms/vkms_crtc.c | 1 + > drivers/gpu/drm/vkms/vkms_drv.c | 3 +- > drivers/gpu/drm/vkms/vkms_drv.h | 3 +- > drivers/gpu/drm/vkms/vkms_plane.c | 2 +- > include/drm/drm_atomic.h | 20 +++ > include/drm/drm_atomic_uapi.h | 2 + > include/drm/drm_colorop.h | 22 ++- > include/drm/drm_crtc.h | 27 ++++ > include/drm/drm_drv.h | 6 + > include/drm/drm_file.h | 7 + > include/uapi/drm/drm.h | 25 +++ > 29 files changed, 994 insertions(+), 135 deletions(-) > --- > base-commit: 342e5ee08797cde0e8af30e6110a5dc1cba61e9c > change-id: 20250730-mtk-post-blend-color-pipeline-498e1a9cc53e > > Best regards,