From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f227.google.com (mail-pl1-f227.google.com [209.85.214.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CE943F2106 for ; Thu, 19 Mar 2026 18:13:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.227 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773943988; cv=none; b=pwZrH0icbmjZSYz2zV5wSpYhVGRiqQEwiF3eviZrT2llLActTLINz6graSYYNj62Riyy4Z3MaCSU9VDCe6JJJ14VGDFJBSgTeIjxxAfYyOPheyqrMzU3tLpEeCPamPGWW772adgq+hP5r1FYBEnwvPxF/kN4T2hh/MJR7ZMJytE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773943988; c=relaxed/simple; bh=TNd8KsiBfNAW4PY5mSr5UDbgWlxUXbASdNC041mAE7U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N0d1SAzlXsA+rbuWlmQyRRLX9SWd7idHqlOjqznz57pExoXrMwCaTE77xbdkw0+BP2eLoI7oQHT9HIiQQBSxW6VDnK1XcvfcS65qs7QO/AvLASdQEszPW8jve2gjvUJlkRAXXckriWWC/tAHwt3DA0O0bFk4qhmoSHZR8Rq4+PM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=eCqQ7EIS; arc=none smtp.client-ip=209.85.214.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="eCqQ7EIS" Received: by mail-pl1-f227.google.com with SMTP id d9443c01a7336-2ab077e3f32so5668395ad.3 for ; Thu, 19 Mar 2026 11:13:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773943987; x=1774548787; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=dgB/oAPv2Ng5VSm6Q6qVgOpNaKbrs+RRk8Mf2PFJJLc=; b=aFQ31TRAOYDyV3EVWkhZWyASqYHkEH+CUtEo/1enNLiIWdvczaLpT8IUeHPj0PDjRx oEOGKFO5+tb5YvrRnBYOi1A1IRY4JOhNgaAwAXs/i/URaHLQSIx6/IMnL4rMWANe4ry/ LIbuaPRbUtIITZ+XMC9b/kFf86scMmk6tUR2OvRr+Q+tjenfDsY56BB4xpilNllbZgXG i4qtFgavxEX3RPStgdmredJgdoaaTjAxFUH1E/yoQRJJd1WSWqkaa5YFGKdQis2TiWJ4 PyC4JIXsCPp5zUu3mADR4BFAUUCzF5VS33J3+o0Ul4SJUfF6Zb5hMjjs32MNwrSmxn09 01Yg== X-Forwarded-Encrypted: i=1; AJvYcCV6pHeL4ox+Y/u6FlOfP8AA/C1T2MeauITuMlmUAD5mmIc61QQAVzgiP8DfgC14nhczh+tKszkIfqInODM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywhhu13Wi33pr4zFImVmm8SPTpHdxTjk1XxtZ9WJBKzppQNDa2/ kvpbTeZUozdkyar6LNcXEriSJzXdizdaKqR73o5OzEiKv+CV5xOX1qUCZqzi9py+8aA+TdPDeLp O2AjJKgnHm+OT1ahpf0QLeqTeCA5dZSTVU4xKjdAWsBT/Yj3v1Fk3srg/hLJKHbLT7nggrtGtXA Uj58+LD/mS/LKPZS0XxN1ROCmMJSnL+xWDLrrMlkPeWlrk7JxX+NyXHZ/k4Aeam2/EuyCs38NUZ IRGXN/l0KSqw+Iw/Rde5+dp X-Gm-Gg: ATEYQzxt4ToWQKOTjasYv7d0XVIoXB1q2WmwjM1+UCQP0zZGB/F0MOvVx0NqeQ66U3B t40axZtYBHvAkRBcCch9P7EslOhR4V+hd3iTiWKhbOlaKraLrr7RltP0u9c6hgFyBqMRw0e+f3R Co9azUXtc1k52W1fyo3TXmF5qJmD4/yWu4Z0Lxyme2y3qExuoGoFBT+2f+Yltk4CMpRwyOHvEn6 mXpfN8Q1xFe99zq8oNkTdp1uKinKfh6C078QjT6se+qVNOrUl6NLHZDu0gwyJaOZlZwd171dDEi 7Hrm4bUOuJHMPAtpFfcgQNWXUc2HHxpGIsWG8g8D/u64iZz5mSBAjuFmavfTo12ZqjWBhA38HOI PtSOa8iTsRqSp3CCCRz/gA8ChsdLWtoaRqklnAb1QaKfgl/ks8O08MU5uON9IlXCL+QIgbmRvmm j5R84Re7lB+p/2pUjNLqfRF74mUbY20JwfaVddX8e95+pODcStCgoMZ65y0QwM/Go+ X-Received: by 2002:a17:902:d4d2:b0:2b0:7a27:bb2b with SMTP id d9443c01a7336-2b0827a9076mr2385735ad.34.1773943986730; Thu, 19 Mar 2026 11:13:06 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-118.dlp.protect.broadcom.com. [144.49.247.118]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2b06e60c6a6sm7046605ad.43.2026.03.19.11.13.06 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Mar 2026 11:13:06 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-2c0ba59a830so1188822eec.0 for ; Thu, 19 Mar 2026 11:13:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1773943984; x=1774548784; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=dgB/oAPv2Ng5VSm6Q6qVgOpNaKbrs+RRk8Mf2PFJJLc=; b=eCqQ7EISNzar+9h508+TEExQ7r5NF/WHL6jxfOfwW7vswN6Bi2m/EtzdPUaIf4fuAx nFDnWB+KZkAY8Q8wgryuiYq5IYBQ+Pcvv1CeaESJ2pJv2NyZ7dtL6gwQMKwQabuCj5iI 2qfL2fGyenRdgA3EhLt72B7rx1xj8qmOX4MXA= X-Forwarded-Encrypted: i=1; AJvYcCXghi4jEnDLzx0VlYFdrLaHkFVNM5p4UvUuLp0N7QgnT/D7xKB5EzSzRnuyhzyUjk3CzCh1csSCIWbo6rM=@vger.kernel.org X-Received: by 2002:a05:7300:f68c:b0:2c0:d233:d7c0 with SMTP id 5a478bee46e88-2c1096d532dmr198787eec.21.1773943984504; Thu, 19 Mar 2026 11:13:04 -0700 (PDT) X-Received: by 2002:a05:7300:f68c:b0:2c0:d233:d7c0 with SMTP id 5a478bee46e88-2c1096d532dmr198770eec.21.1773943983785; Thu, 19 Mar 2026 11:13:03 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c0e536894bsm9978899eec.5.2026.03.19.11.13.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Mar 2026 11:13:03 -0700 (PDT) Message-ID: <4d4a244d-f179-4e24-b8ff-b3f77bc83f8d@broadcom.com> Date: Thu, 19 Mar 2026 11:13:01 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] ARM: dts: broadcom: bcm2835-rpi: Move the firmware node down 1 level To: Marek Szyprowski , "Rob Herring (Arm)" , Krzysztof Kozlowski , Conor Dooley , Broadcom internal kernel review list , Ray Jui , Scott Branden Cc: devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260114015810.701076-2-robh@kernel.org> <86bce6c0-dbaf-4508-9f40-ff209c85a76d@samsung.com> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <86bce6c0-dbaf-4508-9f40-ff209c85a76d@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 3/19/26 04:19, Marek Szyprowski wrote: > On 14.01.2026 19:22, Florian Fainelli wrote: >> On 1/13/2026 5:58 PM, Rob Herring (Arm) wrote: >>> Commit 32eea985999b ("ARM: dts: broadcom: bcm2835-rpi: Move non >>> simple-bus nodes to root level") moved the firmware nodes into the >>> standard /firmware. However, /firmware is intended to be just a >>> container for firmware nodes as it is possible to have multiple types of >>> firmware (e.g. SCMI, OP-TEE, etc.). Move the RPi firmware down a level. >>> >>> Fixes: 32eea985999b ("ARM: dts: broadcom: bcm2835-rpi: Move non >>> simple-bus nodes to root level") >>> Reported-by: Marek Szyprowski >>> Signed-off-by: Rob Herring (Arm) >>> --- >>> This is only half the fix. Unfortunately, a kernel change[1] is also >>> needed to make this all work. I do plan for that to go to stable. I'll >>> leave it up to the Broadcom maintainers whether it's preferred to revert >>> the fixed patches or apply these fixes. A 3rd option is revert for now >>> and apply these DT changes some time later to give some time for stable >>> updates. >> >> Let's wait until your fix for the /firmware match table gets applied >> and then I will pick up your two changes. > > > Florian: I've noticed that the $subject patch has been applied to > yesterday's linux-next as commit 0603d8af97ff, but the code applied in > Your tree differs from what has been posted in this thread. See: > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/arch/arm/boot/dts/broadcom/bcm2835-rpi.dtsi?h=next-20260318&id=0603d8af97fff097daa118faf04d9f439b2227ec > > https://lore.kernel.org/all/20260114015810.701076-2-robh@kernel.org/ > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm/boot/dts/broadcom/bcm2835-rpi.dtsi?h=next-20260318 > > > The "firmware" node in Your tree is under "soc" node, but without adding > a "compatible = simple-mfd;" property there it won't be populated, what > breaks operation of all drivers requiring the firmware driver(s). Yes I see what happened here, Rob's patch is dependent upon 32eea985999b which I had initially applied then dropped, and then I did not (re)apply it again as a prerequisite for that one we are replying to and I incorrectly resolved the conflict as a result. It should have been clear that no conflict resolution should have been necessary, *sigh*. This is now fixed and pushed out, sorry about that, definitively a sloppy move here. Will let that simmer in linux-next for a day and then sent out the pull requests. Thanks again Marek for catching this, my test rack does not currently have a working RPi system, something to address. -- Florian