From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f48.google.com (mail-dl1-f48.google.com [74.125.82.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCEE932B9A8 for ; Wed, 10 Dec 2025 21:56:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765403792; cv=none; b=JJM4oCqP9fm8UuUDP/uSaF5iVQ8Xe9PZZqmbX13UgRxCUHPDii0pygUb+DxSOjn3J3d87mZLt7Cdivpw3q08ITaKca8j+etwttB5sxGNuQWWPXl5+UIMy22lkatie6Mq8QpUD8abAkawGOxPCmv57Hbf+PUJZPzJTjxLGU5rgUQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765403792; c=relaxed/simple; bh=YYgX0e1gybRiTu68tQB5B3oJIXXzn/Oz2RLQkXM8Dvg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BZ+/BXsxOqQMKcETUdDTwTZdAys4NzlwCUZSbJ5/6EiGh2z//tdSmO5LSHeocP7YS+SnBANhEXZ8YRHGDTLuPAU3fuftiMXZHIzDJNP0K5mf5DCcASsNK+tPlSWlZAUlMEDYPO045K1ZLZpbtsOVfzU3T42TcwxULPUxEQqa02Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=naVC3cSM; arc=none smtp.client-ip=74.125.82.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="naVC3cSM" Received: by mail-dl1-f48.google.com with SMTP id a92af1059eb24-11beb0a7bd6so1710182c88.1 for ; Wed, 10 Dec 2025 13:56:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765403790; x=1766008590; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=cXDH6lhQTiBiSLdm58a6wWlqT3rBijDGmMi1XfIS/WE=; b=naVC3cSMeyH0tju5m8/vpoTB6ri2vt4P6kFLbJH3f3lywrX9g+niL3xa4bQ8UU16fS TyVrtBPbcy+GZ0684mamZyYIU0xNfxTuv2OyB9vcjUyRb4OnUjbg6FEHf2gy+Cs6PMQp 0RPEc6ug2SZwBpqEooQjTKHAFDuZ/j6P+R5CAwrTaN1rWajch68CKPBXrL4X6zTZs0sY 2jV3ZJz7suik7cMQNBpPZCDwPt3aQu6sI3ySg2WmHljyAw2lDnrxOQbP01WIhdKtP3cX kw2PagMXwclbAVJkSuW2w3RNdPfgq3UOh7AcZ5L7OUw2P7l7kkv5QYK4c7mHcJ7eFPM8 9n3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765403790; x=1766008590; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cXDH6lhQTiBiSLdm58a6wWlqT3rBijDGmMi1XfIS/WE=; b=ePREq58ANdYRnGf+a8Zrzb36vvX/igjoYfkxGR9NOsIiPyEib5L4EhMv+XnhwTGdFd V18aEfPHzr3fef+++ntuoR3YEiUgYaFBVUylNlSUMIqS+bzy0HR9IAr6TvKfOZaBJYm1 TaJwhNxpP+zXg/7Tn+9D0rKlbgP6TAxSgwwdwt2G8zvJ+e41b9KR1LwTl1sAvCeBfFEw +mo1Odt3JoJmouoseGsS7OP5sx6CCpQEIiUIgUwMFOPtC35QPSfBiR6Z7GCgILKoW1Of oEf8GNvsHWCHmfwBVXpwbSgMQ/sDZaXpT9uEXqlrlnzvZyvwGe12fLCofx6AaLBPXqtj aQLw== X-Forwarded-Encrypted: i=1; AJvYcCV4wp+puiAbdEFaaRbOKg7stm8jateXen7OqidySyqHmTRGoB1DaMynQLEEcj+rf6n9a9+W//PBZDyhlKc=@vger.kernel.org X-Gm-Message-State: AOJu0YzlHXrfSGvP+k2xFMmyGLXTjIkXIrtADFJYVv3YDamhRhpy5IQQ /JWijMirLB2eiV3NXhLIIGauc/oPiVZs0wUZGaq6Cf87SyduAWmf75jQYa8Yeg== X-Gm-Gg: ASbGncun4/eV/0vOM0ElzKm+fTHbt3P+77+GnuUE8FWCnYUcEXb4wuYelNA03D/bp+c 3Ir0dfH+pClimwke47EAY/CAaGFLVAMh0mHsjPKwZCXFKU7swUVIx9yrXEshjF9HzOalUIgf325 4gfQyQuo63/v7k8N4xeUcgSqruAN08uB5nzckluUHTbHKohJTShi43AcVrazunmhXfCI0IkC60H 1aIAJK/eSOHCw07avp6glCqD7kqZue2VIjmUVA0kyyBX25LtP49xyhGBG9rCTvxgFtN2z+OHcEH lJjB5HrvWpxYV4TMKbhrLi8R7rhveV7Mq6qDDlIpI0C/azBa9FDru4B1Ttk2OUCdRd+U05EcUkF Yze6jVsYXmZCo1iuRjHlTZNp8I+1jMCjOqYAJDh7rqLFa8Bep1+0gswCSr3uKUrTKh4Ewva17U+ 5iXZkvVoVD7VLGqGoXgjkQLDxoscJ9/aT8N3jX2GZwJQ1EE93X9Z4xpM1aH90= X-Google-Smtp-Source: AGHT+IFh2YDRWVKv8ppwm5EiLIYikJ3C5kHwmG8NEf5Wi2an9tk9XW9uMU/5ZRhqXIhrT8o8WCwAEg== X-Received: by 2002:a05:7022:ec6:b0:11b:c86b:3870 with SMTP id a92af1059eb24-11f2e0a7b1dmr629353c88.4.1765403789763; Wed, 10 Dec 2025 13:56:29 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11f2e2ffac2sm1887767c88.11.2025.12.10.13.56.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Dec 2025 13:56:29 -0800 (PST) Sender: Guenter Roeck Message-ID: <4d4ab58f-fa71-4c03-a239-1e2603d03e5a@roeck-us.net> Date: Wed, 10 Dec 2025 13:56:28 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] hwmon: (sht3x) add support for SHT85 To: Antoni Pokusinski Cc: linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251209175848.5739-1-apokusinski01@gmail.com> <2683b84f-d7d1-4445-b5d3-bed393de34a0@roeck-us.net> <20251210214413.pyzke7etf7xfjf5t@antoni-VivoBook-ASUSLaptop-X512FAY-K512FA> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20251210214413.pyzke7etf7xfjf5t@antoni-VivoBook-ASUSLaptop-X512FAY-K512FA> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/10/25 13:44, Antoni Pokusinski wrote: > > Hello Guenter, > Thanks for the quick review > > On Tue, Dec 09, 2025 at 07:09:55PM -0800, Guenter Roeck wrote: >> On 12/9/25 13:19, Guenter Roeck wrote: >>> On 12/9/25 09:58, Antoni Pokusinski wrote: >>>> SHT85 is a temperature and humidity sensor with an interface very >>>> similar to SHT3x. However, it does not feature alerts (and therefore >>>> limits). >>>> >>> >>> The datasheet does suggest that the chip supports both temperature and >>> humidity tracking alert status, which only makes sense if the chip >>> supports alert limits. It does not support an alert _pin_, but that >>> doesn't mean that it does not support limits. I'll want to see definite >>> confirmation that the chip does not support the limit commands. >>> >> >> Looking closer into the SHT85 datasheet, the sensor chip is actually a SHT35. >> Given that, disabling limit attributes and alarms is neither necessary >> nor acceptable. It isn't even necessary to add "sht85" to the device ID >> table; sht3x works just fine. I don't mind if it is added, but it does >> not need a new chip ID (at least until/unless interrupt support is added >> to the driver). >> >> Thanks, >> Guenter >> > I've just tested the SHT85 sensor with the non-modified sht3x driver and > the limits and alerts work fine indeed. I was a bit confused by the SHT85 > datasheet which does not explicitly mention the limit commands, that's > why I excluded them in the patch, sorry for the confusion. > No problem. > I guess I could simply add {"sht85", sht3x} entry to the i2c_device_id[], > this would also indicate clearly that sht85 is supported by this driver. > Yes, please do that, and add a note to the documentation and Kconfig. Thanks, Guenter