From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Brent Lu <brent.lu@intel.com>, alsa-devel@alsa-project.org
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Ben Zhang <benzh@chromium.org>,
Mac Chiang <mac.chiang@intel.com>,
Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] add channel constraint for BDW machine drivers
Date: Mon, 27 Apr 2020 22:00:40 +0200 [thread overview]
Message-ID: <4d4b8978-88b3-9d54-8812-85fe35456ead@intel.com> (raw)
In-Reply-To: <1588007614-25061-1-git-send-email-brent.lu@intel.com>
On 2020-04-27 19:13, Brent Lu wrote:
> The machine driver bdw-rt5650 (for Google buddy) supports 2 or 4-channel
> recording while other two drivers support only 2-channel recording. HW
> constraints are implemented to reflect the hardware limitation on BDW
> platform.
>
> Changes since v1:
> - Change the patch title.
> - Remove the DUAL_CHANNEL and QUAD_CHANNEL macros which are too obvious.
> - Follow the naming convertion, using 'bdw_rt5650_' and 'bdw_rt5677_' to
> name startup functions.
> - Refine the comments in startup functions.
> - Redesign the bdw_rt5650_fe_startup() function for readability.
> - Add an assignment to initialize runtime->hw.channels_max variable.
>
Thank you for addressing all listed issues.
I'll recheck hw constraints on my end just to be sure but this series
looks good already, so:
Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>
next prev parent reply other threads:[~2020-04-27 20:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 17:13 Brent Lu
2020-04-27 17:13 ` [PATCH v2 1/3] ASoC: bdw-rt5677: add channel constraint Brent Lu
2020-04-27 17:13 ` [PATCH v2 2/3] ASoC: bdw-rt5650: " Brent Lu
2020-04-27 17:13 ` [PATCH v2 3/3] ASoC: broadwell: " Brent Lu
2020-04-27 17:59 ` [PATCH v2 0/3] add channel constraint for BDW machine drivers Pierre-Louis Bossart
2020-04-27 20:00 ` Cezary Rojewski [this message]
2020-04-28 15:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d4b8978-88b3-9d54-8812-85fe35456ead@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=benzh@chromium.org \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mac.chiang@intel.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®