mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Johannes Thumshirn <jthumshirn@suse.de>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Jason L Tibbitts III <tibbs@math.uh.edu>,
	Doug Gilbert <dgilbert@interlog.com>,
	Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
	Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH] scsi: sg: only check for dxfer_len greater than 256M
Date: Thu, 27 Jul 2017 10:43:09 +0200	[thread overview]
Message-ID: <4d4d2fa1-a603-a097-95ac-59e98cba795a@suse.de> (raw)
In-Reply-To: <20170727071126.4717-1-jthumshirn@suse.de>

On 07/27/2017 09:11 AM, Johannes Thumshirn wrote:
> Don't make any assumptions on the sg_io_hdr_t::dxfer_direction or the
> sg_io_hdr_t::dxferp in order to determine if it is a valid request. The
> only way we can check for bad requests is by checking if the length exceeds
> 256M.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> Fixes: 28676d869bbb (scsi: sg: check for valid direction before starting the
> request)
> Reported-by: Jason L Tibbitts III <tibbs@math.uh.edu>
> Tested-by: Jason L Tibbitts III <tibbs@math.uh.edu>
> Suggested-by: Doug Gilbert <dgilbert@interlog.com>
> Cc: Doug Gilbert <dgilbert@interlog.com>
> Cc: <stable@vger.kernel.org>
> ---
>  drivers/scsi/sg.c | 31 +------------------------------
>  1 file changed, 1 insertion(+), 30 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

  reply	other threads:[~2017-07-27  8:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-27  7:11 Johannes Thumshirn
2017-07-27  8:43 ` Hannes Reinecke [this message]
2017-07-27 12:51 ` Martin K. Petersen
2017-07-27 13:05   ` Jason L Tibbitts III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d4d2fa1-a603-a097-95ac-59e98cba795a@suse.de \
    --to=hare@suse.de \
    --cc=dgilbert@interlog.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=stable@vger.kernel.org \
    --cc=tibbs@math.uh.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®