From: "Kevin Coffman" <kwc@citi.umich.edu>
To: "Nick Piggin" <npiggin@suse.de>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
stable@kernel.org, "Alexey Dobriyan" <adobriyan@gmail.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Kevin Coffman" <kwc@citi.umich.edu>
Subject: Re: [patch] iov_iter_advance fix
Date: Thu, 6 Mar 2008 10:15:43 -0500 [thread overview]
Message-ID: <4d569c330803060715s53de08d1w7131b8ae930abd4f@mail.gmail.com> (raw)
In-Reply-To: <20080306053950.GA28803@wotan.suse.de>
Thanks Nick,
I've verified this fixes the problem I was seeing.
On Thu, Mar 6, 2008 at 12:39 AM, Nick Piggin <npiggin@suse.de> wrote:
>
> iov_iter_advance skips over zero-length iovecs, however it does not properly
> terminate at the end of the iovec array. Fix this by checking against
> i->count before we skip a zero-length iov.
>
> The bug was reproduced with a test program that continually randomly creates
> iovs to writev. The fix was also verified with the same program and also it
> could verify that the correct data was contained in the file after each
> writev.
>
> 2.6.25 and 2.6.24.stable requires this fix.
>
> Signed-off-by: Nick Piggin <npiggin@suse.de>
> Cc: stable@kernel.org
Tested-by: Kevin Coffman <kwc@citi.umich.edu>
prev parent reply other threads:[~2008-03-06 15:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 5:39 Nick Piggin
2008-03-06 15:15 ` Kevin Coffman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d569c330803060715s53de08d1w7131b8ae930abd4f@mail.gmail.com \
--to=kwc@citi.umich.edu \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®