From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Huang, Ying" <ying.huang@intel.com>
Subject: Re: [PATCH] sched/fair: Fix ftq noise bench regression
Date: Wed, 22 Mar 2017 17:22:45 +0000 [thread overview]
Message-ID: <4d5ec252-9d83-93ef-0d56-27895e8d388d@arm.com> (raw)
In-Reply-To: <CAKfTPtBjLNyQ3b2qUvOBDvP3VWhMYVCvZ-ndDt65S-WHOwz8UQ@mail.gmail.com>
On 22/03/17 16:55, Vincent Guittot wrote:
> On 22 March 2017 at 17:22, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
>> On 22/03/17 09:22, Vincent Guittot wrote:
>>> On 21 March 2017 at 18:46, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
>>>> Hi Vincent,
>>>>
>>>> On 17/03/17 13:47, Vincent Guittot wrote:
[...]
>> +static inline bool blocked_update_needed(struct sched_entity *se)
>> +{
>> + struct cfs_rq *gcfs_rq = group_cfs_rq(se);
>
> gcfs_rq can't be set before testing that se is not null
Ah correct, but you could set it after the !se check.
next prev parent reply other threads:[~2017-03-22 17:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 13:47 Vincent Guittot
2017-03-21 17:46 ` Dietmar Eggemann
2017-03-22 9:22 ` Vincent Guittot
2017-03-22 16:22 ` Dietmar Eggemann
2017-03-22 16:55 ` Vincent Guittot
2017-03-22 17:22 ` Dietmar Eggemann [this message]
2017-03-23 9:12 ` [tip:sched/core] sched/fair: Fix FTQ " tip-bot for Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d5ec252-9d83-93ef-0d56-27895e8d388d@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®