From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBB2C84039 for ; Fri, 2 Jan 2026 13:19:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767359977; cv=none; b=lNelExCKNfYniaMl+18Vo6rlLPzJECvCy1p2LyI0FA5//c3stNBYVprbPge3YVBcd7TORiLvUqN6dONoUqNq4ANcIfnHzYWt+culKMbWo7IL1V/9VDADJ5D8663KFD8YsrMm9L89d4Z567StVSVfV9mqGzK8Pzx8tJNY1psCfwo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767359977; c=relaxed/simple; bh=LSAf/Rk3TdAEWsr3WqS6XJD+Y+HBBtBELhHh+tH2vUw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=b3IGoPdxu7NR8L9RpekdmZlLT71COl4EAgqBh6QNh6V54LEAZ7FKfTh+bfBz+VtuLMj4AC8uJVH9LIMT+f7Ta1brtVhP4kpBnIMkRxIGerEjQSsrpA3e92XZZlpcszhk0VI4tvDBu0B22pDnSbWr00u9n0rzHfXexVni9OQcjTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Nq3daW5D; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DAJWKdya; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Nq3daW5D"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DAJWKdya" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6029WFYa207493 for ; Fri, 2 Jan 2026 13:19:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IZw/JJiAn3POXEdzsiw5cZbc4vxiyR7ZYVaBih2uKcc=; b=Nq3daW5Dr+ltfedU ClwLEDz1gERd71jL3x3HMIya9oQUymeAtf/WMOUFWX+oGODH+dQ7YqDeGP3z+2jb LBqPVJ84Ti63+zMDI30CmDvVjT0E3RsnyroK54ijTUB4ro+43aGBFif5dRNUQ2Mj 1SPvtXCQ8zJYTZNgEEZf5/524ltCZslP55uiuEfgFhpfUapBgimBodgVAdvVX4S7 a+mW46+rAlu9RlZos+ssYtYO57P2J8Z0UIARAEkFTYBYizGNMIcNdkGFTFVEm0Zz GJbQhskDQ4QE5ddBymvJE9lhrXLRApu7/SjBxVzrRPo46fBzdcQhS7g6pFJ3FpSf jjeHlw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bcx74cjbn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 02 Jan 2026 13:19:34 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2a0a4b748a0so280877505ad.1 for ; Fri, 02 Jan 2026 05:19:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767359973; x=1767964773; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IZw/JJiAn3POXEdzsiw5cZbc4vxiyR7ZYVaBih2uKcc=; b=DAJWKdyahrkd4vsy2lyQLL6plz6cvggdSRybMIwqySYeNhurj2+zGqs27SDSbcgDcR 1z8D+MO2QrIzlrAacOH9kXFDJA1cmIgM4p0atn2lkYnMG55+QGyOQwOO3PtZdzgGLpuW ZYPNQfdpxziXTAfI0Fl55oI2iDXYHWgLqJAoFAzOqwjU9xA+ZcT8y/RTo53Q9ig6G2e4 PySw6kofCH0NVnSuJEVa8mLB14O4SO/55ryY9JpQz5KVg7PLteDHHY+UZ/7dRm6gdhYe 0gRPU8jOo6YMox9cxn5rXfMOgUP9eW8RcbBslCceUe2TGyfAUXzggLLZXEz0hnoT698e 1dmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767359973; x=1767964773; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IZw/JJiAn3POXEdzsiw5cZbc4vxiyR7ZYVaBih2uKcc=; b=t48OY4IVj8DdeiyVE9C8cVQZUbFDxB8Fa5UsfglH7FTAzdOUhuPgVjbXnmPUjLCUd8 7qZT+mhqgj7Ezg0eZr1dhafsydeENkAn26p+wBhktvquWpboFuWgUev98B3tUifgtDby RWFe0Ayf4IlpNDDjElQmD48WrxdIAHmhVXaruEjADy24t8tGvsfncIkkizSUS5aPDI24 eUil+131eplGMB7vL/0TfkfFGYkNAb+Pm+FGEvE4EfpJUCUfVxL4IpOCTV5XCdGXDxsa UC6s7clhOMOOBFybk8tI8AFSqlQMoJ2UM3Q7LIl9aOdTjwYJiw30bYFHl14TzOag2oPs 5KJw== X-Forwarded-Encrypted: i=1; AJvYcCUzkthm+zruZn2rdMfEuF5PivM35LlBo+QXsGk7NTDgHj0Jbr8kK9gs0HNCPY1x66m/0bvS72SUaO2kKcM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxn5xIclyIdDoZT8szJXn9XzCjlurMstk7CuJfidTOjd9gHWYuR kejZTLBx0zbP6k+6KHEvdL2/JJw4g3WpLskn1iAk+ds8EjKYB9hRiorWnjzOl5FHCx9Uanf8eIK O6c5CrvIAYCYpFitjUeKRGofNPzAkLuxv9ex4sLcIstAg/J9hqR4fBKAwQ9vvNdtOStY= X-Gm-Gg: AY/fxX6mpcmVEZkQ1UirA4eg+bW30si9YIEJfDLede5BHaZ/5+juaOiKJaVgSczwYOE yRx3A+dimYWW7GafHyIlTcDqN0CfKH0qkdYDxxuDjydpy3+4lYZog9f8gYmZy2IsVZLcpCVz38l GqkB5dJiicKALZX61z7YGUEmfTWtRE+3N5Sbu5MWZZEBs3HzB3PMZYZ6V+pc9Skn1ciZ0N3M9Ve z1dBDGGZb34pPNvc+/XzjNCzADCfwefBm6Q6ryFTxy6bjwzYlJc01ZuJD4Xv63g56orAAxGMexz rK+GIKYZiqD9qVXm2TCd3BNwVeXEYbQI3Dgveec1hnpwqJjmzcAMNF6YkEIbu1xlpuioVLXPF70 W5gM4mwjRdwnoJ2ear94VHUAToI8wzSWZPpiZN15aQA== X-Received: by 2002:a17:902:db12:b0:2a0:9040:6377 with SMTP id d9443c01a7336-2a2f242aaddmr409853625ad.18.1767359973485; Fri, 02 Jan 2026 05:19:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IE1hlYxp7YshVj7hB0XX1WRZM787D0V9PpumPlGwEaLRUxkh8qU8paZNSAZAb4rM53RY4rTtQ== X-Received: by 2002:a17:902:db12:b0:2a0:9040:6377 with SMTP id d9443c01a7336-2a2f242aaddmr409853425ad.18.1767359973021; Fri, 02 Jan 2026 05:19:33 -0800 (PST) Received: from [10.218.35.45] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c666casm374709145ad.3.2026.01.02.05.19.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jan 2026 05:19:32 -0800 (PST) Message-ID: <4d61e8b3-0d40-4b78-9f40-a68b05284a3d@oss.qualcomm.com> Date: Fri, 2 Jan 2026 18:49:25 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/7] clk: qcom: gcc: Do not turn off PCIe GDSCs during gdsc_disable() To: Konrad Dybcio , Bjorn Andersson , Michael Turquette , Stephen Boyd , Taniya Das , Konrad Dybcio , Bartosz Golaszewski , Shazad Hussain , Sibi Sankar , Bryan O'Donoghue , Melody Olvera , Dmitry Baryshkov , Taniya Das , Dmitry Baryshkov , Imran Shaik , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Rajendra Nayak , manivannan.sadhasivam@oss.qualcomm.com, stable@vger.kernel.org References: <20260102-pci_gdsc_fix-v1-0-b17ed3d175bc@oss.qualcomm.com> <500313f1-51fd-450e-877e-e4626b7652bc@oss.qualcomm.com> Content-Language: en-US From: Krishna Chaitanya Chundru In-Reply-To: <500313f1-51fd-450e-877e-e4626b7652bc@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: dliWoSVNwbqZ9zYTKnIVFQeHeAxcdrQ5 X-Proofpoint-GUID: dliWoSVNwbqZ9zYTKnIVFQeHeAxcdrQ5 X-Authority-Analysis: v=2.4 cv=HNvO14tv c=1 sm=1 tr=0 ts=6957c5e6 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=_935WOAJMPqh-kFyC1gA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTAyMDExOCBTYWx0ZWRfX/TW9HS4CdMBv 8+fnJ4J/KGWLAbZ73nZf3m53ke4bsgizGn74CCj8FPDLCPVtuYJtMPXuaryLv9xe77PvxVLqWE2 CpzU9v2zRR6C0XFncIslmE1I865W/Qt/gotg+EbbZpymX8X6tMTpHZKAvoYOuwjlNycChEN6J4J CCQn19QHMSEFtpSYjjYsSv4hESXBcLDW9HFZVELtTiXcz6jS45QpsRACEu0woXI9UejTY4vKAL0 OL08SDM+FC7OhBZk+PmO5xH/iaBRwyHb9oiTNTMYXeZN/MHG5vz0Aqn9iaiIM0j/02b6J8q3OAy IIycFVBf6qeKIqkj2Cp7fGIiHkCpNUTumviXsXEN9wqixUFVBYSix2SbCvGwd9463gC5js0RQiN O2ghX/WTIlQW652rwNHf43dU5svkpWSb/l+v7xX8ojk3bnapBB49Yb82Rir/jH/KPokwH592dml GePBvsbrJIJIgS0VHdg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-02_01,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 bulkscore=0 adultscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601020118 On 1/2/2026 5:09 PM, Konrad Dybcio wrote: > On 1/2/26 12:36 PM, Krishna Chaitanya Chundru wrote: >> >> On 1/2/2026 5:04 PM, Konrad Dybcio wrote: >>> On 1/2/26 10:43 AM, Krishna Chaitanya Chundru wrote: >>>> With PWRSTS_OFF_ON, PCIe GDSCs are turned off during gdsc_disable(). This >>>> can happen during scenarios such as system suspend and breaks the resume >>>> of PCIe controllers from suspend. >>> Isn't turning the GDSCs off what we want though? At least during system >>> suspend? >> If we are keeping link in D3cold it makes sense, but currently we are not keeping in D3cold >> so we don't expect them to get off. > Since we seem to be tackling that in parallel, it seems to make sense > that adding a mechanism to let the PCIe driver select "on" vs "ret" vs > "off" could be useful for us At least I am not aware of such API where we can tell genpd not to turn off gdsc at runtime if we are keeping the device in D3cold state. But anyway the PCIe gdsc supports Retention, in that case adding this flag here makes more sense as it represents HW. sm8450,sm8650 also had similar problem which are fixed by mani[1]. > FWIW I recall I could turn off the GDSCs on at least makena with the old > suspend patches and the controllers would come back to life afterwards In the suspend patches, we are keeping link in D3cold, so turning off gdsc will not have any effect. But if some reason we skipped D3cold like in S2idle case then gdsc should not be off, in that case in resume PCIe link will be broken. Link [1]: clk: qcom: gcc-sm8650: Do not turn off PCIe GDSCs during gdsc_disable() - kernel/git/torvalds/linux.git - Linux kernel source tree - Krishna Chaitanya. > Konrad