From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A2ED3254A2 for ; Fri, 19 Jun 2026 06:45:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781851511; cv=none; b=eQJwM5m3DubTTP8gPYmWSBbZpDEcN99gceNzgD9Pth7UGSQ0zKRjhUJoJAGJEpVYNCus0sgSUEPIdMriodNjEOoK0alPDuIykv2mjfVm6y1kwakzFeIB+PHedyb7cO6t/H7RtYAADnY4pXZQiL40DqCNN0DKkvDt581eWjDXAbI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781851511; c=relaxed/simple; bh=Hckp7srdJ2LRcrqr9h2hUZOxxARFEJYif+BcJ1ig0xs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kSHEZdQ/oId9xlmoq1Zt8nCPqKGvOO68wsviervblkidJ0prJa8JzZa+pqhhw+YTyspQocwQbfzLoujWouF6A0s1L+nEpyvYDeV/UhF2WZk9yGLFVN5ZJtZ5gElV9QBG9Knw3sTDSJIzhS8AFqg99eJcJZmWt4Pnn4nqHsTb3hE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kYQmekwn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=I9IBjaa6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kYQmekwn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="I9IBjaa6" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65J2sdVF1675771 for ; Fri, 19 Jun 2026 06:45:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RIsplPTUbXHeA4Zorpq7Kgqnq1vnUxBBxXkBvDyePAU=; b=kYQmekwnm3YBbPvH CHfD+dTq6/r0MDn4wLWtczltNYwWQ0Idv7CYwuwzksZ5uvOW7HR+xx4pBRV+Xz5e ynAaBH78oH80nacHIdynm+vCDE0rxuM8r1ZmNJ03rfKKxzXDcraV+SCL+3HeGsxe ng45KSy+CHR0MbWan2VErbHnS1NaHgq6CgnFsRXvNpxPsJCgPp4+aMFHShTSF1BX TLy4hKFwpOInGQ4ImX/LkPGTgViJ8goBMcmub0GUJDIaj/C7EiIp+/ARo4GaRnt9 Cw0TjVa9L9S5/8Chlc1yxd2l7Z9vyH2Ps3zfaCjS6FCBbc4vD+1MoByp4JVDXQNv Kpfcvg== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4evmyraghy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Jun 2026 06:45:08 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c89956023dbso903327a12.0 for ; Thu, 18 Jun 2026 23:45:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781851508; x=1782456308; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RIsplPTUbXHeA4Zorpq7Kgqnq1vnUxBBxXkBvDyePAU=; b=I9IBjaa6QW3SqEGNxALxONNauHdg4Itz/RxVdSzQlDd0lJtgjNLBbL9ahq6P+9FURQ 8cCh/0nUc6dFAyhE010oN7ykrSwJP6z9aGqpFGjQZi+vZ3QMnb1idweDd6fkPhfCwGuU Xf81azcRv5MfC3kzwjWpT+ped/lt11SlnCUXp1N0crCM3DbrvbBRPcUyzlDfWdNdxl4S CCfF6A73wewoCqdO9d2ee++PbNBnU81Ej6jCXmEashM7ZCnEsPqLdvltFLXuVDmLgAL/ DYlSvEbbSAaC4tGflXd64xaoNIYvnxXL07VI4lmZcE5I4uWlvbszDmlWSyWSRLtNtBIr EFnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781851508; x=1782456308; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RIsplPTUbXHeA4Zorpq7Kgqnq1vnUxBBxXkBvDyePAU=; b=Zv3vv1PTfFO23T9PBwi/pe2dDunyqS0akcTG5AcCWIssQUKElCu8dThiflg1AdJZM7 8pYugpD0LR4ikDI1Ah+xCu+mB19iNLueus+r+Sw8fDDXRWxGC8/ajYFjcvN6Gy/QP7RN T4Ji3QeUXZTB8/R59oPJHreATQmI5EsxhkfbWCXQCgtlR1lA1BUDCkgcQFKxGMiGaiyz e1RWrwTYlrU1Cm3bYxYGbvfhbAYagH5nnannMH8wbZuX3lfQprepl5fz5EcMla7AOuuB Qpf7HnPvV4sR8eDkTtZDD0eIJjrP2m+cArnHSUKntg2CAh0RaOtJqHJ7/z8HlIGeeCr6 ZEEw== X-Forwarded-Encrypted: i=1; AFNElJ9pl3gwH6VgVYlcYRLUoGBzncPM2rpCqZ6Iwid7qTczgDAbkQUYnsD64u9ozooOP2nbipp2iQgtOSA855I=@vger.kernel.org X-Gm-Message-State: AOJu0YzihN+H+M0QIBo8jOK8kBgKH5sqeL14wbgvo5HALZrD6sxrJF7f A7xNAXfja9hE/hXuOMHQU/sArbB+KlNeeAGIDY/h8jlC/ZFAboiMSPMCL8Bnpf3LPy9b2BURWfR 6rV1eMGoHhjGMF7MPcqupkxpObErrf5XIsAAcyGeh3FLTs5yp91dQstkSUh5HHvY9rrs= X-Gm-Gg: AfdE7cnyR5Q13KKajyrvAlKWeeNUwd1FAOTioXfFCtmv//aFdIGrnkYt/c8JY5ojiH2 pahG5Kk9HymudYFX5ay5Z1iXDd7cs0PgJnvgljYlcVwaGybtd0zOBWvzMnqEG7nevxzqVHY9A4E A1A2a6w6az4yUWcXdo1Htz6WOVDNDaCJEF+ZEpFYcdNHg0is42w0fyItcfqctoooM3LP3hgaPDi kIimpfs5LpgNynOzM+IelQJbzLHpVqxht/nW2fWKjFH7DB5axch478UhgObp611IDhi+sNtldOD WB2WWn+TEPdxwxNIshWQlD0bUMgkmiDrxjsVLp+KCqd9z71vAGCZ1nwbE+vju96nygapIzgCbRf COzcjn42B1XmfSw5A0uxrwhgxHZW2NZJEOSTDdpIY X-Received: by 2002:a05:6a21:513:b0:398:b433:87ed with SMTP id adf61e73a8af0-3bb34a7d301mr2958752637.44.1781851508017; Thu, 18 Jun 2026 23:45:08 -0700 (PDT) X-Received: by 2002:a05:6a21:513:b0:398:b433:87ed with SMTP id adf61e73a8af0-3bb34a7d301mr2958688637.44.1781851507509; Thu, 18 Jun 2026 23:45:07 -0700 (PDT) Received: from [10.92.184.233] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c8a890ad726sm1286070a12.28.2026.06.18.23.45.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2026 23:45:07 -0700 (PDT) Message-ID: <4d643a18-a044-4350-b7f9-2c61f50cb792@oss.qualcomm.com> Date: Fri, 19 Jun 2026 12:14:58 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: thermal: Add Qualcomm MBG thermal monitor support To: Krzysztof Kozlowski Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Stephen Boyd , Jishnu Prakash , Kamal Wadhwa , Amit Kucheria , Thara Gopinath , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Satya Priya Kakitapalli , Ajit Pandey , Imran Shaik , Taniya Das , Jagadeesh Kona References: <20260601-spmi-mbg-driver-v1-0-b4892b55a17f@oss.qualcomm.com> <20260601-spmi-mbg-driver-v1-1-b4892b55a17f@oss.qualcomm.com> <20260608-sweet-powerful-ibis-8b2adb@quoll> Content-Language: en-US From: Sachin Gupta In-Reply-To: <20260608-sweet-powerful-ibis-8b2adb@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=RZWgzVtv c=1 sm=1 tr=0 ts=6a34e574 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=P-IC7800AAAA:8 a=gEfo2CItAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=0qyGmKY7lCQY0vYQb8sA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 a=d3PnA9EDa4IxuAV0gXij:22 a=sptkURWiP4Gy88Gu7hUp:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: JilErZTDNqRTaDWMnmGXYrTWiXeyltPQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE5MDA2MCBTYWx0ZWRfX9QNEVQ7Ff+jJ vd8knCofHx2p/386jvBzifXXDcis5dg7qPVDSLpihDo0IHB42GXGRvXuuLIay9dwLbNXIyGXsXn GA4B7kvlYrDorR8ISLb8nxpj4xth1bVrtwT25hDyOy4v5XCz0jYHSP8X1aIbk6B19gE7ymKeh9X TILC0g73a4BVr8R9K+fwn1Jq/gGVfjy8Q4sIo/WlSPaensq4l/2TMR/VPQCuzxnOhOpRbjYejvw xcrlLG8hRGU8UvPtFPPu5nl086rpCYxN/Q2rHYstyrXcuMTG3yps0LSppIIeYrXj8UUzAGZCboO 1QDM8UCAS41SYAOUSzClXD5hxhL1PVCSjj+WlvU9dtiysKkiaqimT0T9QtgJCLbipaTKFeyxvGW 3RTMjT6SRsZ3TkiZ/ww2jA7hbJiLzHMHhkSz5S93xeR/+oNsJ+xcg4AqGk3baVjFaItlEIi/wTo tYijndbKkRy41CYgv2g== X-Proofpoint-GUID: JilErZTDNqRTaDWMnmGXYrTWiXeyltPQ X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE5MDA2MCBTYWx0ZWRfX3xHaUgLHrnFA LZlKkJHZodTBAfz/Dkn7ZvRLzyG7Rv2mOJiZlYz0kRTrnu+QrbhK47GfAZBjXsisLu9jrJe4ltp eCX6LYCjibNPFr2vXq08goeF/XUbCkU= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-19_01,2026-06-18_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 bulkscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606190060 On 6/8/2026 3:37 PM, Krzysztof Kozlowski wrote: > On Mon, Jun 01, 2026 at 04:31:18PM +0530, Sachin Gupta wrote: >> From: Satya Priya Kakitapalli >> >> Add bindings for the Qualcomm MBG (Master Bandgap) temperature alarm peripheral > > Feels unwrapped. > > Please wrap commit message according to Linux coding style / submission > process (neither too early nor over the limit): > https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > I will re-wrap the commit message in the next revision. > >> found on the PM8775 PMIC. Unlike the existing SPMI temp alarm peripheral, >> the MBG peripheral supports both hot and cold threshold monitoring across >> two programmable levels (LVL1 and LVL2), with interrupt status reported via >> a fault status register over SPMI. >> >> Signed-off-by: Satya Priya Kakitapalli >> Co-developed-by: Sachin Gupta >> Signed-off-by: Sachin Gupta >> --- >> .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++ >> .../bindings/thermal/qcom-spmi-mbg-tm.yaml | 72 ++++++++++++++++++++++ >> 2 files changed, 76 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml >> index 644c42b5e2e5..5f409fe700b2 100644 >> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml >> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml >> @@ -193,6 +193,10 @@ patternProperties: >> type: object >> $ref: /schemas/thermal/qcom,spmi-temp-alarm.yaml# >> >> + "^temperature-sensor@[0-9a-f]+$": >> + type: object >> + $ref: /schemas/thermal/qcom-spmi-mbg-tm.yaml# >> + >> "^typec@[0-9a-f]+$": >> type: object >> $ref: /schemas/usb/qcom,pmic-typec.yaml# >> diff --git a/Documentation/devicetree/bindings/thermal/qcom-spmi-mbg-tm.yaml b/Documentation/devicetree/bindings/thermal/qcom-spmi-mbg-tm.yaml >> new file mode 100644 >> index 000000000000..a0ecc9f35cf6 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/thermal/qcom-spmi-mbg-tm.yaml > > Filename must match compatible. > Thanks for the review. I can rename this to match the compatible naming, but wanted your preference on scope: Should I use a generic naming scheme (qcom,spmi-mbg-tm.yaml with matching compatible), or make it PMIC-specific (qcom,pm8775-mbg-tm.yaml). Thanks, Sachin >> @@ -0,0 +1,72 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/thermal/qcom-spmi-mbg-tm.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm's SPMI PMIC MBG Thermal Monitoring > > Best regards, > Krzysztof >