From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Kun-Fa Lin <milkfafa@gmail.com>
Cc: mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
avifishman70@gmail.com, tmaimon77@gmail.com,
tali.perry1@gmail.com, venture@google.com, yuenn@google.com,
benjaminfair@google.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, andrzej.p@collabora.com,
kwliu@nuvoton.com, devicetree@vger.kernel.org,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
kflin@nuvoton.com, linux-media@vger.kernel.org
Subject: Re: [PATCH v10 7/7] media: nuvoton: Add driver for NPCM video capture and encode engine
Date: Tue, 3 Jan 2023 13:48:23 +0100 [thread overview]
Message-ID: <4d64e3f9-57a3-c6be-2709-36e9a1617bf9@molgen.mpg.de> (raw)
In-Reply-To: <CADnNmFr1naRfam=z0p-4hEugSDJy_HCK8XZyQJ0eFirnmwuH4A@mail.gmail.com>
Dear Kun-Fa,
Am 29.12.22 um 09:55 schrieb Kun-Fa Lin:
>>> Add driver for Video Capture/Differentiation Engine (VCD) and Encoding
>>> Compression Engine (ECE) present on Nuvoton NPCM SoCs. The VCD can
>>> capture and differentiate video data from digital or analog sources,
>>
>> “differentiate video data” sounds uncommon to me. Am I just ignorant or
>> is there a better term?
>
> How about "The VCD can capture a frame from digital video input and
> compare two frames in memory, then the ECE will compress the frame
> data into HEXTITLE format", is it better?
Yes, I prefer your suggestion.
>> Wich VNC viewer and version?
>
> I used RealVNC version 6.21.1109 to test.
> Do I have to add this information in the commit message?
I do not think there are rules, but I prefer to have the test
environment and procedure information in the commit message in case
there are problems, and you want to reproduce things.
>> Maybe also paste the new dev_ log messages you get from one boot.
>
> Do you mean dev_info/dev_debug messages of the driver?
> If yes, I get these messages from one boot (only dev_info will be
> printed in default):
>
> npcm-video f0810000.video: assigned reserved memory node framebuffer@0x33000000
> npcm-video f0810000.video: NPCM video driver probed
Yes, that is what I meant. Maybe even the debug messages.
>> It’d be great if you noted the datasheet name and revision.
>
> I can note the datasheet name and revision in the commit message but
> can't provide the file link because it is not public.
> Is it ok with you?
Yes, that would be ok with me.
>>> +static unsigned int npcm_video_ece_get_ed_size(struct npcm_video *video,
>>> + u32 offset, u8 *addr)
>>> +{
>>> + struct regmap *ece = video->ece.regmap;
>>> + u32 size, gap, val;
>>
>> Using a fixed size type for variables not needing is, is actually not an
>> optimization [1]. It’d be great, if you went over the whole change-set
>> to use the non-fixed types, where possible. (You can also check the
>> difference with `scripts/bloat-o-meter`.
>
> So what I have to do is replace "u8/u16/u32" with "unsigned int" for
> generic local variables as much as possible.
> Is my understanding correct?
Yes, I would say so.
>>> +MODULE_AUTHOR("Joseph Liu<kwliu@nuvoton.com>");
>>> +MODULE_AUTHOR("Marvin Lin<kflin@nuvoton.com>");
>>
>> Please add a space before the <.
>>
>>> +MODULE_DESCRIPTION("Driver for Nuvoton NPCM Video Capture/Encode Engine");
>>> +MODULE_LICENSE("GPL");
>>
>> Not GPL v2?
>
> I'll correct them in the next patch.
Awesome.
Kind regards,
Paul
next prev parent reply other threads:[~2023-01-03 12:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 9:51 [PATCH v10 0/7] Support Nuvoton NPCM Video Capture/Encode Engine Marvin Lin
2022-12-27 9:51 ` [PATCH v10 1/7] ARM: dts: nuvoton: Add node for NPCM VCD and ECE engine Marvin Lin
2022-12-27 9:51 ` [PATCH v10 2/7] media: dt-binding: nuvoton: Add " Marvin Lin
2022-12-27 9:54 ` Krzysztof Kozlowski
2022-12-28 9:41 ` Kun-Fa Lin
2022-12-27 9:51 ` [PATCH v10 3/7] dt-bindings: arm: nuvoton: Add bindings for NPCM GFXI Marvin Lin
2022-12-27 9:55 ` Krzysztof Kozlowski
2022-12-28 9:52 ` Kun-Fa Lin
2022-12-27 9:51 ` [PATCH v10 4/7] media: v4l: Add HEXTILE compressed format Marvin Lin
2022-12-27 9:51 ` [PATCH v10 5/7] media: v4l2-ctrls: Reserve user control base for NPCM video controls Marvin Lin
2022-12-27 9:51 ` [PATCH v10 6/7] media: uapi: Add controls for NPCM video driver Marvin Lin
2022-12-27 9:51 ` [PATCH v10 7/7] media: nuvoton: Add driver for NPCM video capture and encode engine Marvin Lin
2022-12-28 10:50 ` Paul Menzel
2022-12-29 8:55 ` Kun-Fa Lin
2023-01-03 12:48 ` Paul Menzel [this message]
2023-01-04 9:12 ` Kun-Fa Lin
2023-02-02 3:35 ` Kun-Fa Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d64e3f9-57a3-c6be-2709-36e9a1617bf9@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=andrzej.p@collabora.com \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kflin@nuvoton.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kwliu@nuvoton.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=milkfafa@gmail.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®