mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Matt Turner <mattst88@gmail.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Magnus Lindholm <linmag7@gmail.com>
Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/7] alpha: marvel: report environmental events without VERBOSE_MCHECK
Date: Sat, 14 Nov 2026 15:01:17 -0800	[thread overview]
Message-ID: <4d69d3e9-9e05-485d-87e2-428616cd5d9d@roeck-us.net> (raw)
In-Reply-To: <20261114-marvel-env-v1-1-890328e4b7e5@gmail.com>

On 11/14/26 09:39, Matt Turner wrote:
> The service processors report temperature, fan, voltage and power supply
> alarms as system event (0x680) logout frames. The frame is already
> classified as reportable, but without CONFIG_VERBOSE_MCHECK only the
> header line reaches the log, which does not say which sensor or what
> happened. Print the subpackets unconditionally.
> 
> Assisted-by: Claude:claude-opus-5-5

For all patches: This is obsolete. Please base your patches on the latest
kernel and ask the agent to follow AGENTS.md.

Thanks,
Guenter

> Signed-off-by: Matt Turner <mattst88@gmail.com>
> ---
>   arch/alpha/kernel/err_marvel.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/alpha/kernel/err_marvel.c b/arch/alpha/kernel/err_marvel.c
> index c0c0ccefc467..832567a3ccbb 100644
> --- a/arch/alpha/kernel/err_marvel.c
> +++ b/arch/alpha/kernel/err_marvel.c
> @@ -24,7 +24,6 @@
>   static void
>   marvel_print_680_frame(struct ev7_lf_subpackets *lf_subpackets)
>   {
> -#ifdef CONFIG_VERBOSE_MCHECK
>   	struct ev7_pal_environmental_subpacket *env;
>   	struct { int type; char *name; } ev_packets[] = {
>   		{ EL_TYPE__PAL__ENV__AMBIENT_TEMPERATURE,
> @@ -62,7 +61,6 @@ marvel_print_680_frame(struct ev7_lf_subpackets *lf_subpackets)
>   		       env->unit_id,
>   		       env->condition);
>   	}
> -#endif /* CONFIG_VERBOSE_MCHECK */
>   }
>   
>   static int
> 


  reply	other threads:[~2026-11-14 23:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14 17:39 [PATCH 0/7] alpha: marvel: environmental sensors Matt Turner
2026-11-14 17:39 ` [PATCH 1/7] alpha: marvel: report environmental events without VERBOSE_MCHECK Matt Turner
2026-11-14 23:01   ` Guenter Roeck [this message]
2026-11-14 17:39 ` [PATCH 2/7] alpha: marvel: fix the environmental subpacket layout Matt Turner
2026-11-14 17:39 ` [PATCH 3/7] alpha: marvel: refresh environmental readings through the console Matt Turner
2026-11-14 17:39 ` [PATCH 4/7] alpha: marvel: register a platform device for the environmental sensors Matt Turner
2026-11-14 17:39 ` [PATCH 5/7] hwmon: Add driver for Marvel AlphaServer " Matt Turner
2026-11-14 23:00   ` Guenter Roeck
2026-11-14 17:39 ` [PATCH 6/7] alpha: marvel: notify environmental events Matt Turner
2026-11-14 17:39 ` [PATCH 7/7] hwmon: (marvel-env) Notify userspace of " Matt Turner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d69d3e9-9e05-485d-87e2-428616cd5d9d@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linmag7@gmail.com \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®