From: "Guan Xuetao" <gxt@pku.edu.cn>
To: "eric w. biederman" <ebiederm@xmission.com>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [REVIEW][PATCH 0/3] signal/unicore32: siginfo cleanups
Date: Sat, 29 Sep 2018 21:18:22 +0800 (GMT+08:00) [thread overview]
Message-ID: <4d6cc3dd.4ed8.166257ae39a.Coremail.gxt@pku.edu.cn> (raw)
In-Reply-To: <87lg7q2a2w.fsf@xmission.com>
Hi Eric,
I'll review and check the patches after chinese national day vocation.
Thanks.
Guan Xuetao
> -----Original Messages-----
> From: "Eric W. Biederman" <ebiederm@xmission.com>
> Sent Time: 2018-09-24 23:23:35 (Monday)
> To: linux-kernel@vger.kernel.org
> Cc: linux-arch@vger.kernel.org, "Guan Xuetao" <gxt@pku.edu.cn>
> Subject: [REVIEW][PATCH 0/3] signal/unicore32: siginfo cleanups
>
>
> I have been slowly cleaning up the architectues ever since I discovered
> that the pattern of passing in struct siginfo is error prone, and
> occassionally results in broken siginfo being sent to userspace.
>
> I don't have a clue how to obtain a working unicore32 compiler so the
> following changes have only been reviewed carefully and not compile
> tested. Still I believe they are simple and obviously correct.
>
> Anyone who can review or test these changes please do and let me know
> about any problems you find so that I can correct them.
>
> My intention is to merge this through my siginfo tree. If you feel it
> should go through your arch tree let me know. All of the prerequisites
> should have been merged several releases ago.
>
> Eric W. Biederman (3):
> signal/unicore32: Use send_sig_fault where appropriate
> signal/unicore32: Generate siginfo in ucs32_notify_die
> signal/unicore32: Use force_sig_fault where appropriate
>
> arch/unicore32/include/asm/bug.h | 3 ++-
> arch/unicore32/kernel/fpu-ucf64.c | 12 +++---------
> arch/unicore32/kernel/traps.c | 5 +++--
> arch/unicore32/mm/fault.c | 27 +++++----------------------
> 4 files changed, 13 insertions(+), 34 deletions(-)
>
> Eric
prev parent reply other threads:[~2018-09-29 13:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 15:23 Eric W. Biederman
2018-09-24 15:25 ` [REVIEW][PATCH 1/3] signal/unicore32: Use send_sig_fault where appropriate Eric W. Biederman
2018-09-24 15:25 ` [REVIEW][PATCH 2/3] signal/unicore32: Generate siginfo in ucs32_notify_die Eric W. Biederman
2018-09-24 15:25 ` [REVIEW][PATCH 3/3] signal/unicore32: Use force_sig_fault where appropriate Eric W. Biederman
2018-09-29 13:18 ` Guan Xuetao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d6cc3dd.4ed8.166257ae39a.Coremail.gxt@pku.edu.cn \
--to=gxt@pku.edu.cn \
--cc=ebiederm@xmission.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®