From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFF15EE49B0 for ; Thu, 31 Aug 2023 21:53:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347641AbjHaVxI (ORCPT ); Thu, 31 Aug 2023 17:53:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230425AbjHaVxI (ORCPT ); Thu, 31 Aug 2023 17:53:08 -0400 Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22DA31B0; Thu, 31 Aug 2023 14:53:05 -0700 (PDT) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 06A6286146; Thu, 31 Aug 2023 23:53:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1693518783; bh=7zNiAYmjqejwICsTZJq3BxAP06RQWgh69LgCsjNl+Lc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=uRx7kevIBzaKZHWDa6nk1U95Zv0YF9lq3NYfR21MkcUKxm9SGs2+9OEKa4mlsnSxx Uv1ZgDJ06E4T6qL/KtM8Xf8O7qTviC/0w52I85/NwvasIUO7zJianktiaqRr2ggJHU m4fRDcuG0dzJ9hE9uvAhNDjJvfEYFl8JZT8v0V1do1oQUAnQka3oa+YJAol5Vzafrw BHrEk7zGzyXUH/RKr6tJ2ygnMwvgu7jCbbWRZJaMNXR8AoXgN7sktahRo6moKCxV1B IMllStmHtrXxEmk5A07wpVHCv4ABWenJgVyfcEEwGzcwNw20eLXb+E56lMpqlFE4ln 3OfBfQQu3enEQ== Message-ID: <4d700304-3e10-a19b-d3f0-d0a1aec11580@denx.de> Date: Thu, 31 Aug 2023 23:53:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH V3 2/3] arm64: dts: imx8mp: Add micfil node Content-Language: en-US To: Adam Ford , linux-arm-kernel@lists.infradead.org Cc: aford@beaconembedded.com, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <20230831044431.250338-1-aford173@gmail.com> <20230831044431.250338-2-aford173@gmail.com> From: Marek Vasut In-Reply-To: <20230831044431.250338-2-aford173@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/31/23 06:44, Adam Ford wrote: > The i.MX8MP has a micfil controller which is used for interfacing > with a pulse density microphone. Add the node and mark it as > disabled by default. > > Signed-off-by: Adam Ford > --- > V3: The AUDIOMIX_PDM_ROOT doesn't exist and the real clock is > called IMX8MP_CLK_AUDIOMIX_PDM_SEL, so swap it out. > > V2: No change > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 3167706d81e1..341fd0369ce9 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -1479,6 +1479,27 @@ easrc: easrc@30c90000 { > fsl,asrc-format = <2>; > status = "disabled"; > }; > + > + micfil: audio-controller@30ca0000 { > + compatible = "fsl,imx8mp-micfil"; > + reg = <0x30ca0000 0x10000>; > + #sound-dai-cells = <0>; > + interrupts = , > + , > + , > + ; > + clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_PDM_IPG>, > + <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_PDM_SEL>, > + <&clk IMX8MP_AUDIO_PLL1_OUT>, > + <&clk IMX8MP_AUDIO_PLL2_OUT>, > + <&clk IMX8MP_CLK_EXT3>; > + clock-names = "ipg_clk", "ipg_clk_app", > + "pll8k", "pll11k", "clkext3"; > + dmas = <&sdma2 24 25 0x80000000>; > + dma-names = "rx"; Is dma-names really required if there is only a single DMA channel in DT ?