From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF64735201B for ; Tue, 23 Jun 2026 10:48:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782211690; cv=none; b=dQiFYX9aEIhj4uQwQexZacj+44BfiT4qTdFZAgxdT0rVQ1NCo994/EcGHKo7qzyFhGzJJ0E6XbSpFMGYmNUPVEc8HTJXNnbucd3GDXCNwY9hh9CrFgEotk++2oXzJsg8Q0oVRed5fVgOI2KZZc/ianhg55RmNi0rG8QbcfUQVI8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782211690; c=relaxed/simple; bh=xnN/8QvLP1X1MElPCkZ3aT/2ZO7xrDZDOTBoqCPC+i0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ra/6+0wIqpdnNJmXgsgomLVLjyrpL00gaU1K5VnsCgVvDNGzoE9fN4IJjMcKyHli+1WeZel+ViGY1v5Ljk+Gl20WSGAvlUDbMZXAGrthocwkHcp+O3A18h3ODtDC51cROZBQ7ZkGtRYbn1dI79JjKbkE/iXUqv9NBVN4W+gBVoc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gv4VSbVm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fh1a215M; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gv4VSbVm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fh1a215M" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65N7knH53228431 for ; Tue, 23 Jun 2026 10:48:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yfHADPd3YbiMqVZVRTQ1yGUj997dVMkKh6uX5LLNvXg=; b=gv4VSbVmzNDFWkv6 H/dTQVYHNbaH7RvBatgF1nK8W5YuN486esIJWfXFWZ9sWx+Gw35rv+l8YFNEQRz6 gWpnmpmmmYUzq/xY5vODecFvdVHRMt7uPhSW3aIoWmhn6gPWg0vdNT0LnWY0gVDf /0GJME8xeG2XWf8XtRx2H8IwNxnwR7OUD3u9+TRJV3OF8kiojxQTza9ZTtP3+tWh 5ca49x78i07Et1irFhXQ87zmp1CAgaed+ZW4DwP5KsK+W4Dj7gh5k9SiTwxRG9oL syBRCA3Ex72U7Wgw7HyZhJokwes1OGmYWwlRqWMtRsr3qQmHQc8p490jbjLAJf6S 5NK1OA== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eyp29grcj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 10:48:08 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-37dd27ee7c8so90907a91.1 for ; Tue, 23 Jun 2026 03:48:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782211687; x=1782816487; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yfHADPd3YbiMqVZVRTQ1yGUj997dVMkKh6uX5LLNvXg=; b=fh1a215MWT7RBItuf5QKl2AMpraXlpFfEGyyAZXM27I3E9os+kGSCHxbxHB+R52pfX eil2HlE+KlloFvs9HO6ptR1NoTGbf4allSWKh+1AB5HVnC3HwFrg12NPdjWVPq8CnBsI KXzk8igdkfq0SVf9Ch9xRUQQu64fnvFYxHMrxIWJOjyqrDY/KIOUrHdKk0V/Qtbk5hB9 RU5i1ZaZ2oTXTBBaGtYdkzI0ePem5vIHBcaC/nQSam3xjaBLuayAu6QKSdCuDuyyBINq 4vh7IwCFTg4WTyxzX5T3hpbeIE1WNBSt/4GVD/WbJgDjm3Ex28rUG08OyYgBzwkZzHMh j74w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782211687; x=1782816487; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yfHADPd3YbiMqVZVRTQ1yGUj997dVMkKh6uX5LLNvXg=; b=nAyWAIH0T5HRbGjQCAyqf8ylHOnXvkyxFUOJLekuKGq0iW6ghK4rBK763ZPbTYGMVY dJiLjg34jqj1IDdr0d3b9kx0KDL/UMfQIAFprXcA8qf1CR61KsqChJP4/pvVWx9O4NX3 pafaElFiuW5u01Cjdv4OcAAPRu6cdLN6zYr9mvMNiQRzYrM+6acgF5YLskRPy/mOt3f6 hRu/CL8unZKiktQyVAsDVc5xNHRgRnzOoA9zTGnKcg6tU+NwZWz4/y8FoGQUdQKy9PoH mLMR7kyvMX3iOn41qAkGHrSXb8rquTgtApMn/pdGRh95GCiJ+fQw3iLLcaY43qJsf1C5 XonQ== X-Forwarded-Encrypted: i=1; AHgh+Rp9AFhRoHe82xqtHZR4cNSYMv4iftrTulD4UvuWLsr8ClCkrXAhQi2y03yD+wU7H8HvBPYTFtzz4Ezsxwg=@vger.kernel.org X-Gm-Message-State: AOJu0YwpSjR0Kzv3PqbrIpzScDeGBnTx56Fj5ktpMw+IJHVqroTApBQY YHrgI3/hEzjSvWLpPl8KEpcjVdx2Rdar1NKvF8jeSuYrIjkROXvC/PTv94w/pF4mMY8GmW+bG3Q bTHMEbr9g80SoCKMMb6iHFmw8sR+bGpzn1NUnKlP0n3pWsbLsiSwt/t5eMXhDXkRCiy0= X-Gm-Gg: AfdE7clob0KA/d7ImlUE+RHaOZZgc+kfYuuk2wy6gcGjWc7cjtnqK/S3SaogxV4RQcG LPCqPp3LeENRl3aA6q8onKnn8a3eQWMGrFK3VDLjYmZCdHNFYcsUCKQ6JkhPaJ0RWwRKD74JJh5 d+pmSrHxtF5gehX52hmZmUvB4CRpRJTOWy6dAFruwPEZKhj1NWCH7YtTnVZ11U67dJea5hCQQpl xAxQBJurrKOspQFvbNNmuydiAEO9z9PQaBr8XwHvYDsittwidk3CtiN40jr2AsZpc84uBh1f3az rKsSzoN24WKQwkc2iApHzXkbvitdKRQL7ZXHyNzQkCwKCabXndpk29DJOnWL5hcGdP2bg2guta3 6LNAB0oIMVOkpy6JicOj7Yd5aNKrnTcO1+qHp3prmjcwk0blQVaErASZ85BQjYe6VxvCqcCA/8+ JPiA== X-Received: by 2002:a17:902:c946:b0:2c0:ccdb:e027 with SMTP id d9443c01a7336-2c7bf1ea3e0mr23824425ad.5.1782211687427; Tue, 23 Jun 2026 03:48:07 -0700 (PDT) X-Received: by 2002:a17:902:c946:b0:2c0:ccdb:e027 with SMTP id d9443c01a7336-2c7bf1ea3e0mr23824235ad.5.1782211686935; Tue, 23 Jun 2026 03:48:06 -0700 (PDT) Received: from [10.133.33.161] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c7436f6395sm107070095ad.28.2026.06.23.03.48.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 03:48:06 -0700 (PDT) Message-ID: <4d764907-a3b6-4fd1-8954-8f9b8779c31a@oss.qualcomm.com> Date: Tue, 23 Jun 2026 18:48:02 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/13] Bluetooth: hci_sync: Fix return value of hci_reset_sync() To: Luiz Augusto von Dentz Cc: Marcel Holtmann , Rocky Liao , Bartosz Golaszewski , Ben Young Tae Kim , Balakrishna Godavarthi , Matthias Kaehlcke , Zijun Hu , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Luiz Augusto von Dentz , linux-arm-msm@vger.kernel.org References: <20260622-bt_bugfix-v1-0-11f936d84e72@oss.qualcomm.com> <20260622-bt_bugfix-v1-8-11f936d84e72@oss.qualcomm.com> Content-Language: en-US From: Zijun Hu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=LdAMLDfi c=1 sm=1 tr=0 ts=6a3a6468 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=gI2jydi3O7-V3eHH3HoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: Y6KWv6k2HtBHWIEpJs6g4djuhjJinBT6 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA4OCBTYWx0ZWRfX9tG6/4ReB9s2 /xQg7JgxkmqtkA6+KVp+n4GXwgWdNnmMytCL7W16o80bRovEo9FSJC84PO6KCdYCLwhMibwtcYt lE3L3FRZV5qcNtiymd1/hEsVFVUtta8= X-Proofpoint-ORIG-GUID: Y6KWv6k2HtBHWIEpJs6g4djuhjJinBT6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA4OCBTYWx0ZWRfX7hmgGIEWj2Ey 9r6pDK8BuvTHd79BWW8UyLtHzY+jLjG0AIFBOa5vu90X5TP/zXBUOq0g7dnOHqx219ermDB51Xj LOJaAj48FCIqiEfN17PxelqLitfsF6V8aaNWTiAxDYikn0VvNxBpcV578JwMWHWHIJlaxrGNuRS hG0QdjUlAXaGeiqf1P+gcHUchPBj+kdmSb99i9pcWph+9vR7+OL8WYxCIgmgdyBqOR3lnTCLWxn XumVlkhvaeZ+K9dCo9VvSoxL5Ck6crDCI5MjpddTjlXGXNhgeTBWmUPgQ4ZlSKJqHUEt/qrKOYL SGxBvY1SDukjaJRjlr7RfKcstzEDW8c/yjEYyKIWPTCMk+n/3HJbbV8bd3RpVMARmfudQMd8WlE jQ00PcgBLpa5UbuCaNNBDn4djS9qQ21SgUuPZrnLxT/rJmiu0LM1WGBngVSSe1oBoC2YtjeJtxA zzeCN8pEW3cCppmYvpg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_02,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 clxscore=1015 spamscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230088 On 6/22/2026 11:35 PM, Luiz Augusto von Dentz wrote: >> diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c >> index fce9f9526cb5..601d44ef975f 100644 >> --- a/net/bluetooth/hci_sync.c >> +++ b/net/bluetooth/hci_sync.c >> @@ -3678,8 +3678,10 @@ int hci_reset_sync(struct hci_dev *hdev) >> >> err = __hci_cmd_sync_status(hdev, HCI_OP_RESET, 0, NULL, >> HCI_CMD_TIMEOUT); >> + if (err < 0) >> + return err; >> >> - return err; >> + return -bt_to_errno(err); >> } > There seem to be 2 consecutive changes to hci_reset_sync that conflict > with each other, also the expectation should be that positive errors > are HCI errors and negative errors are stack generated ones, so the > callers should really check `err` and not `err < 0`. Hi Luiz, Checking the full call chains: - hci_reset_sync() → hci_init0_sync() [if (err)] → hci_unconf_init_sync() [if (err < 0)] - hci_reset_sync() → hci_init1_sync() [if (err)] → hci_init_sync() [if (err < 0)] A positive HCI status from hci_reset_sync() propagates through hci_init0_sync()/hci_init1_sync() but is then silently ignored by hci_unconf_init_sync()/hci_init_sync() due to their if (err < 0) checks. Will not change hci_reset_sync(). Any suggestion on how to fix it?