From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CE9BC64E7A for ; Wed, 2 Dec 2020 02:26:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A1D8D206A1 for ; Wed, 2 Dec 2020 02:26:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727761AbgLBC0F (ORCPT ); Tue, 1 Dec 2020 21:26:05 -0500 Received: from linux.microsoft.com ([13.77.154.182]:55964 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727099AbgLBC0E (ORCPT ); Tue, 1 Dec 2020 21:26:04 -0500 Received: from [192.168.0.104] (c-73-42-176-67.hsd1.wa.comcast.net [73.42.176.67]) by linux.microsoft.com (Postfix) with ESMTPSA id D4B6B20B717A; Tue, 1 Dec 2020 18:25:22 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D4B6B20B717A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1606875923; bh=8zAZBN7xMgg91o7+5aZk7oyTbbSqBxC+Lh9bjFbKL7A=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Za7YFMlkQR7YFVFZjNbKLQhXOxaM/Ozhxo8jt2SfQQxYcTOA+iHOJ+LblUiT+K5nG QXKsTQ+mVKJrF2XNnphlFbe6nfQSW0u9kH1FXdbMq0g0mpUAImNAymJzyHFrEWKmXq RQXAnGmoCFzlZNI6drbrZ3X0BF2QGF50y72O/i18= Subject: Re: [PATCH v9 0/8] Carry forward IMA measurement log on kexec on ARM64 To: Mimi Zohar , Rob Herring Cc: bauerman@linux.ibm.com, gregkh@linuxfoundation.org, james.morse@arm.com, catalin.marinas@arm.com, sashal@kernel.org, will@kernel.org, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, frowand.list@gmail.com, vincenzo.frascino@arm.com, mark.rutland@arm.com, dmitry.kasatkin@gmail.com, jmorris@namei.org, serge@hallyn.com, pasha.tatashin@soleen.com, allison@lohutok.net, kstewart@linuxfoundation.org, takahiro.akashi@linaro.org, tglx@linutronix.de, masahiroy@kernel.org, bhsharma@redhat.com, mbrugger@suse.com, hsinyi@chromium.org, tao.li@vivo.com, christophe.leroy@c-s.fr, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, prsriva@linux.microsoft.com, balajib@linux.microsoft.com References: <20201113192243.1993-1-nramas@linux.microsoft.com> <20201121135719.GA2134870@robh.at.kernel.org> <415b4d0b-3d93-40ce-b74e-48fdce7fbf7f@linux.microsoft.com> <76a749ac-8465-1d82-0ff5-0a46e0a29f18@linux.microsoft.com> From: Lakshmi Ramasubramanian Message-ID: <4d776cba-1380-0151-b9b4-4bbbe320742e@linux.microsoft.com> Date: Tue, 1 Dec 2020 18:25:22 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/1/20 11:15 AM, Mimi Zohar wrote: > On Tue, 2020-12-01 at 11:10 -0800, Lakshmi Ramasubramanian wrote: >> On 12/1/20 3:34 AM, Mimi Zohar wrote: >>> On Sat, 2020-11-21 at 06:38 -0800, Lakshmi Ramasubramanian wrote: >>>> On 11/21/20 5:57 AM, Rob Herring wrote: >>>>> On Fri, Nov 13, 2020 at 11:22:35AM -0800, Lakshmi Ramasubramanian wrote: >>> >>>>>> arch/powerpc/include/asm/kexec.h | 1 - >>>>>> arch/powerpc/kexec/Makefile | 7 +- >>>>>> arch/powerpc/kexec/file_load.c | 32 -------- >>>>>> arch/powerpc/kexec/ima.c | 106 ++----------------------- >>>>>> drivers/of/Makefile | 9 +++ >>>>> >>>>>> drivers/of/ima_kexec.c | 91 +++++++++++++++++++++ >>>>>> drivers/of/kexec_fdt.c | 55 +++++++++++++ >>>>> >>>>> Does this need to be 2 files? Just kexec.c? >>>> >>>> Since the functions defined in "ima_kexec.c" and "kexec_fdt.c" are >>>> enabled on 2 different kernel CONFIGs, keeping them in 2 files enables >>>> us to avoid using "#ifdef" in C files. >>> >>> Normally that is true, but just as all of the kexec related functions >>> are co-located in ima/ima_kexec.c, co-locating all of the kexec related >>> functions in drivers/of makes sense. >>> >> >> Sounds good - i'll make the change. >> Instead of "#ifdef" will use "IS_ENABLED" macro, and define the kexec >> related functions in drivers/of/ima_kexec.c > > Perhaps name the file kexec.c, as Rob suggested. > Will do. thanks, -lakshmi