From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752993AbdFWNjB (ORCPT ); Fri, 23 Jun 2017 09:39:01 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:47435 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751496AbdFWNi7 (ORCPT ); Fri, 23 Jun 2017 09:38:59 -0400 Subject: Re: [PATCH 0/7] drivers/hwmon: Add On-Chip Controller (OCC) hwmon driver To: Guenter Roeck , linux-kernel@vger.kernel.org Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, jdelvare@suse.com, mark.rutland@arm.com, robh+dt@kernel.org, gregkh@linuxfoundation.org, cbostic@linux.vnet.ibm.com, jk@ozlabs.org, joel@jms.id.au, andrew@aj.id.au, "Edward A. James" References: <1498171716-26620-1-git-send-email-eajames@linux.vnet.ibm.com> <7806f15f-a594-2cfb-777a-29f1e8a3fd97@roeck-us.net> From: Eddie James Date: Fri, 23 Jun 2017 08:38:50 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <7806f15f-a594-2cfb-777a-29f1e8a3fd97@roeck-us.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 17062313-0008-0000-0000-0000024B6849 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007277; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000214; SDB=6.00878765; UDB=6.00437906; IPR=6.00658917; BA=6.00005438; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015941; XFM=3.00000015; UTC=2017-06-23 13:38:55 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17062313-0009-0000-0000-000035C617FD Message-Id: <4d77d0b7-d7eb-d62f-a10e-63dde83bd407@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-23_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706230230 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/22/2017 11:52 PM, Guenter Roeck wrote: > On 06/22/2017 03:48 PM, Eddie James wrote: >> From: "Edward A. James" >> >> This series adds a hwmon driver to support the OCC on POWER8 and POWER9 >> processors. The OCC is an embedded processor that provides realtime >> power and >> thermal monitoring and management. >> >> This driver has two different platform drivers as a "base" for the >> hwmon stuff, as the means of communicating with the OCC on P8 and P9 is >> completely different. For P8, the driver is an I2C client driver. For >> P9 the >> driver is an FSI-based OCC client driver, and uses the OCC driver >> in-kernel >> API. >> >> There was a previous version of this driver that wasn't written with the >> differences in communication methods between the two versions in >> mind. This >> driver has been considerably simplified. >> > > I thought I did see this before. > > It is customary to use "v2" in such situations, and add a change log. > You expect me to go into the two versions and compare them to figure > out what changed to evaluate if it makes sense. Do you really believe > that > I have enough time to do that, and that I would be willing to spend that > time in the first place ? > > Presumably you know what changed. Why not just tell me ? Hi, This driver does not build upon the previous patch set at all, so I didn't mark it as a v2. It is completely rewritten from scratch. I sent a note saying that the previous patch set was abandoned. There may be some similarities with the previous one, simply because the drivers do the same thing, but I don't think there is any need to compare it with the old driver I mailed out. Thanks for your time, Eddie > > Guenter > >> Edward A. James (7): >> drivers/hwmon: Add On-Chip Controller (OCC) hwmon driver >> drivers/hwmon/occ: Add command transport method for P8 and P9 >> drivers/hwmon/occ: Parse OCC poll response >> drivers/hwmon/occ: Add sensor types and versions >> drivers/hwmon/occ: Add sensor attributes and register hwmon device >> drivers/hwmon/occ: Add non-hwmon attributes >> drivers/hwmon/occ: Add error handling >> >> Documentation/ABI/testing/sysfs-driver-occ-hwmon | 77 ++ >> .../devicetree/bindings/fsi/ibm,p9-occ-hwmon.txt | 18 + >> .../devicetree/bindings/i2c/ibm,p8-occ-hwmon.txt | 25 + >> Documentation/hwmon/occ | 84 ++ >> drivers/hwmon/Kconfig | 2 + >> drivers/hwmon/Makefile | 1 + >> drivers/hwmon/occ/Kconfig | 28 + >> drivers/hwmon/occ/Makefile | 11 + >> drivers/hwmon/occ/common.c | 1242 >> ++++++++++++++++++++ >> drivers/hwmon/occ/common.h | 151 +++ >> drivers/hwmon/occ/p8_i2c.c | 250 ++++ >> drivers/hwmon/occ/p9_sbe.c | 144 +++ >> 12 files changed, 2033 insertions(+) >> create mode 100644 Documentation/ABI/testing/sysfs-driver-occ-hwmon >> create mode 100644 >> Documentation/devicetree/bindings/fsi/ibm,p9-occ-hwmon.txt >> create mode 100644 >> Documentation/devicetree/bindings/i2c/ibm,p8-occ-hwmon.txt >> create mode 100644 Documentation/hwmon/occ >> create mode 100644 drivers/hwmon/occ/Kconfig >> create mode 100644 drivers/hwmon/occ/Makefile >> create mode 100644 drivers/hwmon/occ/common.c >> create mode 100644 drivers/hwmon/occ/common.h >> create mode 100644 drivers/hwmon/occ/p8_i2c.c >> create mode 100644 drivers/hwmon/occ/p9_sbe.c >> >