mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	ppc-dev <linuxppc-dev@lists.ozlabs.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: Regression in 5.1.0-rc2: PowerBook G4 Aluminum fails to boot - bisected to commit 0df977eafc792
Date: Mon, 25 Mar 2019 11:19:15 -0500	[thread overview]
Message-ID: <4d7e3fc5-82d8-5bcf-0891-97445e284c36@lwfinger.net> (raw)
In-Reply-To: <1c1f7eae-0c49-dcb2-f27b-96a83d811df7@c-s.fr>

On 3/25/19 3:46 AM, Christophe Leroy wrote:
> 
> 
> Le 25/03/2019 à 01:49, Larry Finger a écrit :
>> A build of kernel 5.1.0-rc2 resulted in a failure to boot on my PowerBook G4 
>> Aluminum. The bootstrap loads the initial kernel and issues the appropriate 
>> start, but the machine hangs at that point.
>>
>> The problem does not depend on the choice of PPC32 processor type. This 
>> machine has a 7447A according to /proc/cpuinfo.
>>
>> The problem was bisected to the following:
>>
>> commit 0df977eafc792a5365a7f81d8d5920132e03afad
>> Author: Christophe Leroy <christophe.leroy@c-s.fr>
>> Date:   Thu Feb 21 10:37:54 2019 +0000
>>
>>      powerpc/6xx: Don't use SPRN_SPRG2 for storing stack pointer while in RTAS
>>
>>      When calling RTAS, the stack pointer is stored in SPRN_SPRG2
>>      in order to be able to restore it in case of machine check in RTAS.
>>
>>      As machine check is not a perfomance critical path, this patch
>>      frees SPRN_SPRG2 by using a field in thread struct instead.
>>
>>      Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>>      Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>>
>> I reverted this patch and found that the system began execution, and then 
>> failed, likely due to the reassignment of SPRN_SPRG2.
>>
>> I had found this problem with 5.1.0-rc1, but -rc2 was out by the time I 
>> finished the bisection. Unfortunately, none of the changes in -rc2 fixed the 
>> problem.
> 
> I think I identified the issue, see https://patchwork.ozlabs.org/patch/1063962/
> 
> It is now booting properly under QEMU with your .config
> 
> Could you please test it on your target ?

Thanks. That patch fixes the issue.

Larry




      reply	other threads:[~2019-03-25 16:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-25  0:49 Larry Finger
2019-03-25  6:53 ` Christophe Leroy
2019-03-25 15:54   ` Larry Finger
2019-03-25  8:46 ` Christophe Leroy
2019-03-25 16:19   ` Larry Finger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d7e3fc5-82d8-5bcf-0891-97445e284c36@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=benh@kernel.crashing.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®