From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753550AbcKYI4m (ORCPT ); Fri, 25 Nov 2016 03:56:42 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:57783 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753985AbcKYIzU (ORCPT ); Fri, 25 Nov 2016 03:55:20 -0500 Subject: Re: [PATCH 3/4] net: stmmac: dwmac-generic: add missing compatible strings To: Niklas Cassel , Alexandre Torgue References: <1479911104-19864-1-git-send-email-niklass@axis.com> CC: Niklas Cassel , , From: Giuseppe CAVALLARO Message-ID: <4d7e4ba0-d212-6a11-85fa-04babd7da35b@st.com> Date: Fri, 25 Nov 2016 09:54:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1479911104-19864-1-git-send-email-niklass@axis.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.139.54] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-25_01:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Niklas On 11/23/2016 3:25 PM, Niklas Cassel wrote: > From: Niklas Cassel > > devicetree binding for stmmac states: > - compatible: Should be "snps,dwmac-", "snps,dwmac" > For backwards compatibility: "st,spear600-gmac" is also supported. > > Since dwmac-generic.c calls stmmac_probe_config_dt explicitly, > another alternative would have been to remove all compatible strings > other than "snps,dwmac" and "st,spear600-gmac" from dwmac-generic.c. > > However, that would probably do more good than harm, since when trying > to figure out what hardware a certain driver supports, you usually look > at the compatible strings in the struct of_device_id, and not in some > function defined in a completely different file. > > No functional change intended. > > Signed-off-by: Niklas Cassel Acked-by: Giuseppe Cavallaro > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c > index b1e5f24708c9..52cd365b8e5e 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c > @@ -58,9 +58,12 @@ static int dwmac_generic_probe(struct platform_device *pdev) > > static const struct of_device_id dwmac_generic_match[] = { > { .compatible = "st,spear600-gmac"}, > + { .compatible = "snps,dwmac-3.50a"}, > { .compatible = "snps,dwmac-3.610"}, > { .compatible = "snps,dwmac-3.70a"}, > { .compatible = "snps,dwmac-3.710"}, > + { .compatible = "snps,dwmac-4.00"}, > + { .compatible = "snps,dwmac-4.10a"}, > { .compatible = "snps,dwmac"}, > { } > }; >