From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: Colin Ian King <colin.i.king@gmail.com>, <ntfs3@lists.linux.dev>
Cc: <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<llvm@lists.linux.dev>
Subject: Re: [PATCH] fs/ntfs3: remove redundant assignment to variable frame
Date: Tue, 7 Jun 2022 19:22:31 +0300 [thread overview]
Message-ID: <4d81ad89-57c4-88a9-8730-14c0fd9bb075@paragon-software.com> (raw)
In-Reply-To: <20211230155952.379721-1-colin.i.king@gmail.com>
On 12/30/21 18:59, Colin Ian King wrote:
> Variable frame is assigned a value that is never read. The
> assignment is redundant and can be removed. Cleans up the
> clang-scan build warning:
>
> fs/ntfs3/file.c:995:3: warning: Value stored to 'frame' is
> never read [deadcode.DeadStores]
> frame = pos >> frame_bits;
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> fs/ntfs3/file.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ntfs3/file.c b/fs/ntfs3/file.c
> index 3bae76930e68..27c32692513c 100644
> --- a/fs/ntfs3/file.c
> +++ b/fs/ntfs3/file.c
> @@ -992,7 +992,6 @@ static ssize_t ntfs_compress_write(struct kiocb *iocb, struct iov_iter *from)
> if (bytes > count)
> bytes = count;
>
> - frame = pos >> frame_bits;
> frame_vbo = pos & ~(frame_size - 1);
> index = frame_vbo >> PAGE_SHIFT;
>
Applied, thanks!
prev parent reply other threads:[~2022-06-07 16:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 15:59 Colin Ian King
2022-06-07 16:22 ` Konstantin Komarov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d81ad89-57c4-88a9-8730-14c0fd9bb075@paragon-software.com \
--to=almaz.alexandrovich@paragon-software.com \
--cc=colin.i.king@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®