mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: aacraid@adaptec.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [BUG] drivers/scsi/dpt_i2o: a possible sleep-in-atomic bug in adpt_isr
Date: Tue, 12 Dec 2017 09:57:48 +0800	[thread overview]
Message-ID: <4d8d01b4-10c3-653b-e7b0-0603f6287322@gmail.com> (raw)

According to drivers/scsi/dpt_i2o.c, the kernel module may sleep in the 
interrupt handler.
The function call path is:
adpt_isr (interrupt handler)
   adpt_send_nop
     schedule_timeout_uninterruptible --> may sleep

A possible fixing is to replace "schedule_timeout_uninterruptible" with 
"mdelay".
If this fixing is correct, I can send a patch.
This possible is found by my static analysis tool (DSAC) and checked by 
my code review.


Thanks,
Jia-Ju Bai

                 reply	other threads:[~2017-12-12  1:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d8d01b4-10c3-653b-e7b0-0603f6287322@gmail.com \
    --to=baijiaju1990@gmail.com \
    --cc=aacraid@adaptec.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®